Skip to content

Commit d9ad1ca

Browse files
authored
Move global variable to the pipeline level (Azure#18288)
To ensure we always include the global variables in all our pipeline jobs and stages we should import the variables at the highest pipeline level to ensure we don't miss setting these variables in any jobs.
1 parent e12cbc6 commit d9ad1ca

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

eng/pipelines/templates/jobs/archetype-sdk-client.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ parameters:
3131

3232
jobs:
3333
- job: Build
34-
variables:
35-
- template: ../variables/globals.yml
3634
pool:
3735
name: ${{ parameters.WindowsPool }} # Comment this line back-out to switch to public pools.
3836
# vmImage: windows-2019 # Comment this line back-in to switch to public pools.
@@ -97,8 +95,6 @@ jobs:
9795

9896
- job: "Analyze"
9997
condition: and(succeededOrFailed(), ne(variables['Skip.Analyze'], true))
100-
variables:
101-
- template: ../variables/globals.yml
10298
pool:
10399
name: ${{ parameters.LinuxPool }}
104100
vmImage:
@@ -151,8 +147,6 @@ jobs:
151147
- job: "Test"
152148
timeoutInMinutes: ${{ parameters.TestTimeoutInMinutes }}
153149
condition: and(succeededOrFailed(), ne(variables['Skip.Test'], true))
154-
variables:
155-
- template: ../variables/globals.yml
156150
strategy:
157151
maxParallel: $[ variables['MaxParallelTestJobs'] ]
158152
matrix:

eng/pipelines/templates/jobs/archetype-sdk-tests-jobs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ jobs:
5353
matrix: $[ ${{ parameters.Matrix }} ]
5454

5555
variables:
56-
- template: ../variables/globals.yml
5756
# ServiceDirectory references must get passed down by the caller as variable references
5857
- name: ServiceDirectory
5958
value: ${{ parameters.ServiceDirectory }}

eng/pipelines/templates/stages/archetype-sdk-client.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ parameters:
4343
type: number
4444
default: 60
4545

46+
variables:
47+
- template: ../variables/globals.yml
48+
4649
stages:
4750
- stage: Build
4851
jobs:

eng/pipelines/templates/stages/archetype-sdk-tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ parameters:
8585
pathToPublish: '$(Build.ArtifactStagingDirectory)/SessionRecords'
8686
artifactName: SessionRecords
8787

88+
variables:
89+
- template: ../variables/globals.yml
8890

8991
stages:
9092
- ${{ each cloud in parameters.CloudConfig }}:

0 commit comments

Comments
 (0)