[Storage] Unbound connection limit in NET FX test suite (Azure#16876)

kasobol-msft · web-flow · commit d690aeb5e703 · 2020-11-11T17:05:07.000Z
Bump connection limit to int.Max . We already run tests with int.Max on .netcore . Revisiting this setting when when we change parallelization/volume of tests is annoying.
diff --git a/sdk/storage/Azure.Storage.Common/tests/Shared/StorageTestBase.cs b/sdk/storage/Azure.Storage.Common/tests/Shared/StorageTestBase.cs
@@ -30,7 +30,7 @@ static StorageTestBase()
             // https://github.com/Azure/azure-sdk-for-net/issues/9087
             // .NET framework defaults to 2, which causes issues for the parallel upload/download tests.
 #if !NETCOREAPP
-            ServicePointManager.DefaultConnectionLimit = 200;
+            ServicePointManager.DefaultConnectionLimit = int.MaxValue;
 #endif
         }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ static StorageTestBase()`
`30`	`30`	`// https://github.com/Azure/azure-sdk-for-net/issues/9087`
`31`	`31`	`// .NET framework defaults to 2, which causes issues for the parallel upload/download tests.`
`32`	`32`	`#if !NETCOREAPP`
`33`		`- ServicePointManager.DefaultConnectionLimit = 200;`
	`33`	`+ ServicePointManager.DefaultConnectionLimit = int.MaxValue;`
`34`	`34`	`#endif`
`35`	`35`	`}`
`36`	`36`