Skip to content

Commit d59569d

Browse files
[Communication] - PhoneNumbers & Sms - Addressing board review comments (Azure#19738)
* [Communication] - PhoneNumbers - Move models out of Models namespace and rename ISO to Iso * Update the threeLetterISOCountryName parameter name to twoLetterIsoCountryName * Add model factory for PhoneNumberSearchResult * Update the model factory for sms
1 parent 4006c07 commit d59569d

File tree

55 files changed

+273
-224
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+273
-224
lines changed

sdk/communication/Azure.Communication.PhoneNumbers/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Added protected constructor to PurchasePhoneNumbersOperation and ReleasePhoneNumberOperation for mocking.
77

88
### Breaking Changes
9+
- All models are moved from Azure.Communication.PhoneNumbers.Models namespace to Azure.Communication.PhoneNumbers.
910
- AcquiredPhoneNumber class is renamed to PurchasedPhoneNumber.
1011
- PhoneNumbersClient methods renamed:
1112
- GetPhoneNumber -> GetPurchasedPhoneNumber.
@@ -15,15 +16,15 @@
1516
- PhoneNumbersModelFactory static method AcquiredPhoneNumber is renamed to PurchasedPhoneNumber.
1617
- PurchasePhoneNumbersOperation and ReleasePhoneNumberOperation extend Operation instead of Operation<Response>.
1718
- Removed PhoneNumberOperationStatus and PhoneNumberOperationType.
19+
- Renamed ISOCurrencySymbol property to IsoCurrencySymbol in PhoneNumberCost.
20+
- Renamed threeLetterISOCountryName parameter to twoLetterIsoCountryName in PhoneNumbersClient.StartSearchAvailablePhoneNumbers and PhoneNumbersClient.StartSearchAvailablePhoneNumbersAsync.
1821

1922
## 1.0.0-beta.5 (2021-03-09)
2023

2124
### Added
2225
- Added PhoneNumbersClient (originally was part of the Azure.Communication.Administration package).
2326
- Added support for Azure Active Directory Authentication.
2427

25-
26-
2728
### Breaking Changes
2829
- PhoneNumberAdministrationClient has been replaced with PhoneNumbersClient, which has the same functionality but different APIs. To learn more about how PhoneNumbersClient works, refer to the [README.md][read_me]
2930

sdk/communication/Azure.Communication.PhoneNumbers/api/Azure.Communication.PhoneNumbers.netstandard2.0.cs

Lines changed: 127 additions & 129 deletions
Large diffs are not rendered by default.

sdk/communication/Azure.Communication.PhoneNumbers/src/ClientDiagnostics.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
using System.Collections.Generic;
66
using System.Text;
77
using System.Text.Json;
8-
using Azure.Communication.PhoneNumbers.Models;
8+
using Azure.Communication.PhoneNumbers;
99
using Azure.Core;
1010

1111
namespace Azure.Core.Pipeline

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/InternalPhoneNumbersClient.cs

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/InternalPhoneNumbersRestClient.cs

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/Models/BillingFrequency.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/Models/CommunicationError.Serialization.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/Models/CommunicationError.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/Models/CommunicationErrorResponse.Serialization.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/communication/Azure.Communication.PhoneNumbers/src/Generated/Models/CommunicationErrorResponse.cs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)