Remove copied test shared code from Tables extension (Azure#25998)

Author: pakrym

sdk/tables/Microsoft.Azure.WebJobs.Extensions.Tables/tests/Microsoft.Azure.WebJobs.Extensions.Tables.Tests.csproj

@@ -10,6 +10,7 @@
     <PackageReference Include="NUnit3TestAdapter" />
     <PackageReference Include="Microsoft.Azure.WebJobs" />
     <PackageReference Include="Microsoft.Azure.WebJobs.Extensions.Http" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Json" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" />
     <PackageReference Include="Moq" />
   </ItemGroup>
@@ -24,7 +25,7 @@
     <Compile Remove="EntityPropertyToTConverterFactoryTests.cs" />
     <Compile Remove="TToEntityPropertyConverterFactoryTests.cs" />
 
-    <Compile Include="..\..\Azure.Data.Tables\tests\TablesTestEnvironment.cs" />
+    <Compile Include="..\..\Azure.Data.Tables\tests\TablesTestEnvironment.cs" LinkBase="Shared" />
+    <Compile Include="..\..\..\extensions\Microsoft.Azure.WebJobs.Extensions.Clients\tests\shared\*.cs" LinkBase="Shared" />
   </ItemGroup>
-
 </Project>

sdk/tables/Microsoft.Azure.WebJobs.Extensions.Tables/tests/PocoToTableEntityConverterTests.cs

@@ -25,67 +25,72 @@ public void Create_ReturnsInstance()
         public void Create_IfPartitionKeyIsNonString_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new PocoToTableEntityConverter<PocoWithNonStringPartitionKey>(),
-                "If the PartitionKey property is present, it must be a String.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithNonStringPartitionKey>());
+
+            Assert.AreEqual("If the PartitionKey property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfPartitionKeyHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new PocoToTableEntityConverter<PocoWithIndexerPartitionKey>(),
-                "If the PartitionKey property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithIndexerPartitionKey>());
+
+            Assert.AreEqual(exception.Message, "If the PartitionKey property is present, it must not be an indexer.");
         }
 
         [Test]
         public void Create_IfRowKeyIsNonString_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new PocoToTableEntityConverter<PocoWithNonStringRowKey>(),
-                "If the RowKey property is present, it must be a String.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithNonStringRowKey>());
+
+            Assert.AreEqual("If the RowKey property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfRowKeyHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new PocoToTableEntityConverter<PocoWithIndexerRowKey>(),
-                "If the RowKey property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithIndexerRowKey>());
+
+            Assert.AreEqual("If the RowKey property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]
         public void Create_IfTimestampIsNonDateTimeOffset_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new PocoToTableEntityConverter<PocoWithNonDateTimeOffsetTimestamp>(),
-                "If the Timestamp property is present, it must be a DateTimeOffset.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithNonDateTimeOffsetTimestamp>());
+
+            Assert.AreEqual("If the Timestamp property is present, it must be a DateTimeOffset.", exception.Message);
         }
 
         [Test]
         public void Create_IfTimestampHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new PocoToTableEntityConverter<PocoWithIndexerTimestamp>(),
-                "If the Timestamp property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithIndexerTimestamp>());
+
+            Assert.AreEqual("If the Timestamp property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]
         public void Create_IfETagIsNonString_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new PocoToTableEntityConverter<PocoWithNonStringETag>(),
-                "If the ETag property is present, it must be a String.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithNonStringETag>());
+
+            Assert.AreEqual("If the ETag property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfETagHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new PocoToTableEntityConverter<PocoWithIndexerETag>(),
-                "If the ETag property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new PocoToTableEntityConverter<PocoWithIndexerETag>());
+
+            Assert.AreEqual("If the ETag property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]

sdk/tables/Microsoft.Azure.WebJobs.Extensions.Tables/tests/TableEntityToPocoConverterTests.cs

@@ -24,68 +24,73 @@ public void Create_ReturnsInstance()
         [Test]
         public void Create_IfPartitionKeyIsNonString_Throws()
         {
-            // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new TableEntityToPocoConverter<PocoWithNonStringPartitionKey>(),
-                "If the PartitionKey property is present, it must be a String.");
+            // Act & Asset;
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithNonStringPartitionKey>());
+
+            Assert.AreEqual("If the PartitionKey property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfPartitionKeyHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new TableEntityToPocoConverter<PocoWithIndexerPartitionKey>(),
-                "If the PartitionKey property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithIndexerPartitionKey>());
+
+            Assert.AreEqual("If the PartitionKey property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]
         public void Create_IfRowKeyIsNonString_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new TableEntityToPocoConverter<PocoWithNonStringRowKey>(),
-                "If the RowKey property is present, it must be a String.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithNonStringRowKey>());
+
+            Assert.AreEqual("If the RowKey property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfRowKeyHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new TableEntityToPocoConverter<PocoWithIndexerRowKey>(),
-                "If the RowKey property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithIndexerRowKey>());
+
+            Assert.AreEqual("If the RowKey property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]
         public void Create_IfTimestampIsNonDateTimeOffset_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(
-                () => new TableEntityToPocoConverter<PocoWithNonDateTimeOffsetTimestamp>(),
-                "If the Timestamp property is present, it must be a DateTimeOffset.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithNonDateTimeOffsetTimestamp>());
+
+            Assert.AreEqual("If the Timestamp property is present, it must be a DateTimeOffset.", exception.Message);
         }
 
         [Test]
         public void Create_IfTimestampHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new TableEntityToPocoConverter<PocoWithIndexerTimestamp>(),
-                "If the Timestamp property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithIndexerTimestamp>());
+
+            Assert.AreEqual("If the Timestamp property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]
         public void Create_IfETagIsNonString_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new TableEntityToPocoConverter<PocoWithNonStringETag>(),
-                "If the ETag property is present, it must be a String.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithNonStringETag>());
+
+            Assert.AreEqual("If the ETag property is present, it must be a String.", exception.Message);
         }
 
         [Test]
         public void Create_IfETagHasIndexParameters_Throws()
         {
             // Act & Assert
-            ExceptionAssert.ThrowsInvalidOperation(() => new TableEntityToPocoConverter<PocoWithIndexerETag>(),
-                "If the ETag property is present, it must not be an indexer.");
+            var exception = Assert.Throws<InvalidOperationException>(() => new TableEntityToPocoConverter<PocoWithIndexerETag>());
+
+            Assert.AreEqual("If the ETag property is present, it must not be an indexer.", exception.Message);
         }
 
         [Test]