Skip to content

Commit b47775d

Browse files
[Communication] - PhoneNumbers - Rename API methods (Azure#19408)
* Rename API methods * Update changelog
1 parent c5c5570 commit b47775d

18 files changed

+147
-126
lines changed

sdk/communication/Azure.Communication.PhoneNumbers/CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@
33
## 1.0.0-beta.6 (Unreleased)
44

55

6+
### Breaking Changes
7+
- AcquiredPhoneNumber class is renamed to PurchasedPhoneNumber
8+
- PhoneNumbersClient methods renamed:
9+
- GetPhoneNumber -> GetPurchasedPhoneNumber
10+
- GetPhoneNumberAsync -> GetPurchasedPhoneNumberAsync
11+
- GetPhoneNumbers -> GetPurchasedPhoneNumbers
12+
- GetPhoneNumbersAsync -> GetPurchasedPhoneNumbersAsync
13+
- PhoneNumbersModelFactory static method AcquiredPhoneNumber is renamed to PurchasedPhoneNumber
14+
615
## 1.0.0-beta.5 (2021-03-09)
716

817
### Added

sdk/communication/Azure.Communication.PhoneNumbers/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -116,14 +116,14 @@ var purchaseOperation = await client.StartPurchasePhoneNumbersAsync(searchOperat
116116
await purchaseOperation.WaitForCompletionAsync();
117117
```
118118

119-
## Listing acquired phone numbers
119+
## Listing purchased phone numbers
120120

121-
You can list all phone numbers that have been acquired for your resource.
121+
You can list all phone numbers that have been purchased for your resource.
122122

123-
```C# Snippet:ListAcquiredPhoneNumbersAsync
124-
var acquiredPhoneNumbers = client.GetPhoneNumbersAsync();
123+
```C# Snippet:GetPurchasedPhoneNumbersAsync
124+
var purchasedPhoneNumbers = client.GetPurchasedPhoneNumbersAsync();
125125

126-
await foreach (var phoneNumber in acquiredPhoneNumbers)
126+
await foreach (var phoneNumber in purchasedPhoneNumbers)
127127
{
128128
Console.WriteLine($"Phone number: {phoneNumber.PhoneNumber}, monthly cost: {phoneNumber.Cost}");
129129
}
@@ -134,8 +134,8 @@ await foreach (var phoneNumber in acquiredPhoneNumbers)
134134
If you no longer need a phone number you can release it.
135135

136136
```C# Snippet:ReleasePhoneNumbersAsync
137-
var acquiredPhoneNumber = "<acquired_phone_number>";
138-
var releaseOperation = client.StartReleasePhoneNumber(acquiredPhoneNumber);
137+
var purchasedPhoneNumber = "<purchased_phone_number>";
138+
var releaseOperation = client.StartReleasePhoneNumber(purchasedPhoneNumber);
139139
await releaseOperation.WaitForCompletionAsync();
140140
```
141141

sdk/communication/Azure.Communication.PhoneNumbers/api/Azure.Communication.PhoneNumbers.netstandard2.0.cs

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ public PhoneNumbersClient(string connectionString) { }
77
public PhoneNumbersClient(string connectionString, Azure.Communication.PhoneNumbers.PhoneNumbersClientOptions options) { }
88
public PhoneNumbersClient(System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.Communication.PhoneNumbers.PhoneNumbersClientOptions options = null) { }
99
public PhoneNumbersClient(System.Uri endpoint, Azure.Core.TokenCredential tokenCredential, Azure.Communication.PhoneNumbers.PhoneNumbersClientOptions options = null) { }
10-
public virtual Azure.Response<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber> GetPhoneNumber(string phoneNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
11-
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber>> GetPhoneNumberAsync(string phoneNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
12-
public virtual Azure.Pageable<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber> GetPhoneNumbers(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
13-
public virtual Azure.AsyncPageable<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber> GetPhoneNumbersAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
10+
public virtual Azure.Response<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber> GetPurchasedPhoneNumber(string phoneNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
11+
public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber>> GetPurchasedPhoneNumberAsync(string phoneNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
12+
public virtual Azure.Pageable<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber> GetPurchasedPhoneNumbers(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
13+
public virtual Azure.AsyncPageable<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber> GetPurchasedPhoneNumbersAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
1414
public virtual Azure.Communication.PhoneNumbers.PurchasePhoneNumbersOperation StartPurchasePhoneNumbers(string searchId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
1515
public virtual System.Threading.Tasks.Task<Azure.Communication.PhoneNumbers.PurchasePhoneNumbersOperation> StartPurchasePhoneNumbersAsync(string searchId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
1616
public virtual Azure.Communication.PhoneNumbers.ReleasePhoneNumberOperation StartReleasePhoneNumber(string phoneNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
@@ -73,34 +73,22 @@ internal SearchAvailablePhoneNumbersOperation() { }
7373
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.PhoneNumberSearchResult>> WaitForCompletionAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
7474
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.PhoneNumberSearchResult>> WaitForCompletionAsync(System.TimeSpan pollingInterval, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
7575
}
76-
public partial class UpdatePhoneNumberCapabilitiesOperation : Azure.Operation<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber>
76+
public partial class UpdatePhoneNumberCapabilitiesOperation : Azure.Operation<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber>
7777
{
7878
internal UpdatePhoneNumberCapabilitiesOperation() { }
7979
public override bool HasCompleted { get { throw null; } }
8080
public override bool HasValue { get { throw null; } }
8181
public override string Id { get { throw null; } }
82-
public override Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber Value { get { throw null; } }
82+
public override Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber Value { get { throw null; } }
8383
public override Azure.Response GetRawResponse() { throw null; }
8484
public override Azure.Response UpdateStatus(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
8585
public override System.Threading.Tasks.ValueTask<Azure.Response> UpdateStatusAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
86-
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber>> WaitForCompletionAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
87-
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber>> WaitForCompletionAsync(System.TimeSpan pollingInterval, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
86+
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber>> WaitForCompletionAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
87+
public override System.Threading.Tasks.ValueTask<Azure.Response<Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber>> WaitForCompletionAsync(System.TimeSpan pollingInterval, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
8888
}
8989
}
9090
namespace Azure.Communication.PhoneNumbers.Models
9191
{
92-
public partial class AcquiredPhoneNumber
93-
{
94-
internal AcquiredPhoneNumber() { }
95-
public Azure.Communication.PhoneNumbers.Models.PhoneNumberAssignmentType AssignmentType { get { throw null; } }
96-
public Azure.Communication.PhoneNumbers.Models.PhoneNumberCapabilities Capabilities { get { throw null; } }
97-
public Azure.Communication.PhoneNumbers.Models.PhoneNumberCost Cost { get { throw null; } }
98-
public string CountryCode { get { throw null; } }
99-
public string Id { get { throw null; } }
100-
public string PhoneNumber { get { throw null; } }
101-
public Azure.Communication.PhoneNumbers.Models.PhoneNumberType PhoneNumberType { get { throw null; } }
102-
public System.DateTimeOffset PurchaseDate { get { throw null; } }
103-
}
10492
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
10593
public readonly partial struct BillingFrequency : System.IEquatable<Azure.Communication.PhoneNumbers.Models.BillingFrequency>
10694
{
@@ -222,8 +210,8 @@ internal PhoneNumberSearchResult() { }
222210
}
223211
public static partial class PhoneNumbersModelFactory
224212
{
225-
public static Azure.Communication.PhoneNumbers.Models.AcquiredPhoneNumber AcquiredPhoneNumber(string id, string phoneNumber, string countryCode, Azure.Communication.PhoneNumbers.Models.PhoneNumberType phoneNumberType, Azure.Communication.PhoneNumbers.Models.PhoneNumberCapabilities capabilities, Azure.Communication.PhoneNumbers.Models.PhoneNumberAssignmentType assignmentType, System.DateTimeOffset purchaseDate, Azure.Communication.PhoneNumbers.Models.PhoneNumberCost cost) { throw null; }
226213
public static Azure.Communication.PhoneNumbers.Models.PhoneNumberCost PhoneNumberCost(double amount, string currencyCode, string billingFrequency) { throw null; }
214+
public static Azure.Communication.PhoneNumbers.Models.PurchasedPhoneNumber PurchasedPhoneNumber(string id, string phoneNumber, string countryCode, Azure.Communication.PhoneNumbers.Models.PhoneNumberType phoneNumberType, Azure.Communication.PhoneNumbers.Models.PhoneNumberCapabilities capabilities, Azure.Communication.PhoneNumbers.Models.PhoneNumberAssignmentType assignmentType, System.DateTimeOffset purchaseDate, Azure.Communication.PhoneNumbers.Models.PhoneNumberCost cost) { throw null; }
227215
}
228216
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
229217
public readonly partial struct PhoneNumberType : System.IEquatable<Azure.Communication.PhoneNumbers.Models.PhoneNumberType>
@@ -243,4 +231,16 @@ public static partial class PhoneNumbersModelFactory
243231
public static bool operator !=(Azure.Communication.PhoneNumbers.Models.PhoneNumberType left, Azure.Communication.PhoneNumbers.Models.PhoneNumberType right) { throw null; }
244232
public override string ToString() { throw null; }
245233
}
234+
public partial class PurchasedPhoneNumber
235+
{
236+
internal PurchasedPhoneNumber() { }
237+
public Azure.Communication.PhoneNumbers.Models.PhoneNumberAssignmentType AssignmentType { get { throw null; } }
238+
public Azure.Communication.PhoneNumbers.Models.PhoneNumberCapabilities Capabilities { get { throw null; } }
239+
public Azure.Communication.PhoneNumbers.Models.PhoneNumberCost Cost { get { throw null; } }
240+
public string CountryCode { get { throw null; } }
241+
public string Id { get { throw null; } }
242+
public string PhoneNumber { get { throw null; } }
243+
public Azure.Communication.PhoneNumbers.Models.PhoneNumberType PhoneNumberType { get { throw null; } }
244+
public System.DateTimeOffset PurchaseDate { get { throw null; } }
245+
}
246246
}

sdk/communication/Azure.Communication.PhoneNumbers/samples/Sample_PhoneNumbersClient.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,14 @@ while (!purchaseOperation.HasCompleted)
4545
}
4646
```
4747

48-
## Listing acquired phone numbers
48+
## Listing purchased phone numbers
4949

5050
You can list all phone numbers that have been acquired for your resource.
5151

52-
```C# Snippet:ListAcquiredPhoneNumbers
53-
var acquiredPhoneNumbers = client.GetPhoneNumbers();
52+
```C# Snippet:GetPurchasedPhoneNumbers
53+
var purchasedPhoneNumbers = client.GetPurchasedPhoneNumbers();
5454

55-
foreach (var phoneNumber in acquiredPhoneNumbers)
55+
foreach (var phoneNumber in purchasedPhoneNumbers)
5656
{
5757
Console.WriteLine($"Phone number: {phoneNumber.PhoneNumber}, monthly cost: {phoneNumber.Cost}");
5858
}
@@ -63,7 +63,7 @@ foreach (var phoneNumber in acquiredPhoneNumbers)
6363
Phone number's capabilities can be updated by started by `StartUpdateCapabilities` function.
6464

6565
```C# Snippet:UpdateCapabilitiesNumbers
66-
var updateCapabilitiesOperation = client.StartUpdateCapabilities(acquiredPhoneNumber, calling:PhoneNumberCapabilityType.Outbound, sms:PhoneNumberCapabilityType.InboundOutbound);
66+
var updateCapabilitiesOperation = client.StartUpdateCapabilities(purchasedPhoneNumber, calling:PhoneNumberCapabilityType.Outbound, sms:PhoneNumberCapabilityType.InboundOutbound);
6767

6868
while (!updateCapabilitiesOperation.HasCompleted)
6969
{
@@ -77,8 +77,8 @@ while (!updateCapabilitiesOperation.HasCompleted)
7777
If you no longer need a phone number you can release it.
7878

7979
```C# Snippet:ReleasePhoneNumbers
80-
var acquiredPhoneNumber = "<acquired_phone_number>";
81-
var releaseOperation = client.StartReleasePhoneNumber(acquiredPhoneNumber);
80+
var purchasedPhoneNumber = "<purchased_phone_number>";
81+
var releaseOperation = client.StartReleasePhoneNumber(purchasedPhoneNumber);
8282

8383
while (!releaseOperation.HasCompleted)
8484
{

sdk/communication/Azure.Communication.PhoneNumbers/samples/Sample_PhoneNumbersClientAsync.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,14 @@ var purchaseOperation = await client.StartPurchasePhoneNumbersAsync(searchOperat
3535
await purchaseOperation.WaitForCompletionAsync();
3636
```
3737

38-
## Listing acquired phone numbers
38+
## Listing purchased phone numbers
3939

4040
You can list all phone numbers that have been acquired for your resource.
4141

42-
```C# Snippet:ListAcquiredPhoneNumbersAsync
43-
var acquiredPhoneNumbers = client.GetPhoneNumbersAsync();
42+
```C# Snippet:GetPurchasedPhoneNumbersAsync
43+
var purchasedPhoneNumbers = client.GetPurchasedPhoneNumbersAsync();
4444

45-
await foreach (var phoneNumber in acquiredPhoneNumbers)
45+
await foreach (var phoneNumber in purchasedPhoneNumbers)
4646
{
4747
Console.WriteLine($"Phone number: {phoneNumber.PhoneNumber}, monthly cost: {phoneNumber.Cost}");
4848
}
@@ -53,7 +53,7 @@ await foreach (var phoneNumber in acquiredPhoneNumbers)
5353
Phone number's capabilities can be updated by started by `StartUpdateCapabilities` function.
5454

5555
```C# Snippet:UpdateCapabilitiesNumbersAsync
56-
var updateCapabilitiesOperation = client.StartUpdateCapabilities(acquiredPhoneNumber, calling: PhoneNumberCapabilityType.Outbound, sms: PhoneNumberCapabilityType.InboundOutbound);
56+
var updateCapabilitiesOperation = client.StartUpdateCapabilities(purchasedPhoneNumber, calling: PhoneNumberCapabilityType.Outbound, sms: PhoneNumberCapabilityType.InboundOutbound);
5757

5858
await updateCapabilitiesOperation.WaitForCompletionAsync();
5959
```
@@ -63,7 +63,7 @@ await updateCapabilitiesOperation.WaitForCompletionAsync();
6363
If you no longer need a phone number you can release it.
6464

6565
```C# Snippet:ReleasePhoneNumbersAsync
66-
var acquiredPhoneNumber = "<acquired_phone_number>";
67-
var releaseOperation = client.StartReleasePhoneNumber(acquiredPhoneNumber);
66+
var purchasedPhoneNumber = "<purchased_phone_number>";
67+
var releaseOperation = client.StartReleasePhoneNumber(purchasedPhoneNumber);
6868
await releaseOperation.WaitForCompletionAsync();
6969
```

0 commit comments

Comments
 (0)