Skip to content

Commit b17df4a

Browse files
annelo-msftannelo-msft
authored
Rename CoreResponseClassifier (Azure#27379)
* rename CoreResponseClassifier * export api * pr fb * API feedback * export API
1 parent 9a1a68e commit b17df4a

11 files changed

+44
-44
lines changed

‎sdk/core/Azure.Core/api/Azure.Core.net461.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,6 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
380380
public static bool operator !=(Azure.Core.ContentType left, Azure.Core.ContentType right) { throw null; }
381381
public override string ToString() { throw null; }
382382
}
383-
public partial class CoreResponseClassifier : Azure.Core.ResponseClassifier
384-
{
385-
public CoreResponseClassifier(System.ReadOnlySpan<ushort> successCodes) { }
386-
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
387-
}
388383
public static partial class DelegatedTokenCredential
389384
{
390385
public static Azure.Core.TokenCredential Create(System.Func<Azure.Core.TokenRequestContext, System.Threading.CancellationToken, Azure.Core.AccessToken> getToken) { throw null; }
@@ -651,6 +646,11 @@ internal RetryOptions() { }
651646
public Azure.Core.RetryMode Mode { get { throw null; } set { } }
652647
public System.TimeSpan NetworkTimeout { get { throw null; } set { } }
653648
}
649+
public partial class StatusCodeClassifier : Azure.Core.ResponseClassifier
650+
{
651+
public StatusCodeClassifier(System.ReadOnlySpan<ushort> successStatusCodes) { }
652+
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
653+
}
654654
public delegate System.Threading.Tasks.Task SyncAsyncEventHandler<T>(T e) where T : Azure.SyncAsyncEventArgs;
655655
public abstract partial class TokenCredential
656656
{

‎sdk/core/Azure.Core/api/Azure.Core.net5.0.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,6 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
380380
public static bool operator !=(Azure.Core.ContentType left, Azure.Core.ContentType right) { throw null; }
381381
public override string ToString() { throw null; }
382382
}
383-
public partial class CoreResponseClassifier : Azure.Core.ResponseClassifier
384-
{
385-
public CoreResponseClassifier(System.ReadOnlySpan<ushort> successCodes) { }
386-
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
387-
}
388383
public static partial class DelegatedTokenCredential
389384
{
390385
public static Azure.Core.TokenCredential Create(System.Func<Azure.Core.TokenRequestContext, System.Threading.CancellationToken, Azure.Core.AccessToken> getToken) { throw null; }
@@ -651,6 +646,11 @@ internal RetryOptions() { }
651646
public Azure.Core.RetryMode Mode { get { throw null; } set { } }
652647
public System.TimeSpan NetworkTimeout { get { throw null; } set { } }
653648
}
649+
public partial class StatusCodeClassifier : Azure.Core.ResponseClassifier
650+
{
651+
public StatusCodeClassifier(System.ReadOnlySpan<ushort> successStatusCodes) { }
652+
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
653+
}
654654
public delegate System.Threading.Tasks.Task SyncAsyncEventHandler<T>(T e) where T : Azure.SyncAsyncEventArgs;
655655
public abstract partial class TokenCredential
656656
{

‎sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,6 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
380380
public static bool operator !=(Azure.Core.ContentType left, Azure.Core.ContentType right) { throw null; }
381381
public override string ToString() { throw null; }
382382
}
383-
public partial class CoreResponseClassifier : Azure.Core.ResponseClassifier
384-
{
385-
public CoreResponseClassifier(System.ReadOnlySpan<ushort> successCodes) { }
386-
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
387-
}
388383
public static partial class DelegatedTokenCredential
389384
{
390385
public static Azure.Core.TokenCredential Create(System.Func<Azure.Core.TokenRequestContext, System.Threading.CancellationToken, Azure.Core.AccessToken> getToken) { throw null; }
@@ -651,6 +646,11 @@ internal RetryOptions() { }
651646
public Azure.Core.RetryMode Mode { get { throw null; } set { } }
652647
public System.TimeSpan NetworkTimeout { get { throw null; } set { } }
653648
}
649+
public partial class StatusCodeClassifier : Azure.Core.ResponseClassifier
650+
{
651+
public StatusCodeClassifier(System.ReadOnlySpan<ushort> successStatusCodes) { }
652+
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
653+
}
654654
public delegate System.Threading.Tasks.Task SyncAsyncEventHandler<T>(T e) where T : Azure.SyncAsyncEventArgs;
655655
public abstract partial class TokenCredential
656656
{

‎sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -380,11 +380,6 @@ public void AddPolicy(Azure.Core.Pipeline.HttpPipelinePolicy policy, Azure.Core.
380380
public static bool operator !=(Azure.Core.ContentType left, Azure.Core.ContentType right) { throw null; }
381381
public override string ToString() { throw null; }
382382
}
383-
public partial class CoreResponseClassifier : Azure.Core.ResponseClassifier
384-
{
385-
public CoreResponseClassifier(System.ReadOnlySpan<ushort> successCodes) { }
386-
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
387-
}
388383
public static partial class DelegatedTokenCredential
389384
{
390385
public static Azure.Core.TokenCredential Create(System.Func<Azure.Core.TokenRequestContext, System.Threading.CancellationToken, Azure.Core.AccessToken> getToken) { throw null; }
@@ -651,6 +646,11 @@ internal RetryOptions() { }
651646
public Azure.Core.RetryMode Mode { get { throw null; } set { } }
652647
public System.TimeSpan NetworkTimeout { get { throw null; } set { } }
653648
}
649+
public partial class StatusCodeClassifier : Azure.Core.ResponseClassifier
650+
{
651+
public StatusCodeClassifier(System.ReadOnlySpan<ushort> successStatusCodes) { }
652+
public override bool IsErrorResponse(Azure.Core.HttpMessage message) { throw null; }
653+
}
654654
public delegate System.Threading.Tasks.Task SyncAsyncEventHandler<T>(T e) where T : Azure.SyncAsyncEventArgs;
655655
public abstract partial class TokenCredential
656656
{

‎sdk/core/Azure.Core/src/ChainingClassifier.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ namespace Azure.Core
88
{
99
/// <summary>
1010
/// Implements chaining of classifiers for the general case where the end-of-chain
11-
/// <see cref="ResponseClassifier"/> is not a <see cref="CoreResponseClassifier"/>.
12-
/// <see cref="CoreResponseClassifier"/> is preferred due to its enhanced performance
11+
/// <see cref="ResponseClassifier"/> is not a <see cref="StatusCodeClassifier"/>.
12+
/// <see cref="StatusCodeClassifier"/> is preferred due to its enhanced performance
1313
/// characteristics.
1414
/// The classifier chain is a series of <see cref="ResponseClassificationHandler"/> classifiers
1515
/// followed by the "end-of-chain" <see cref="ResponseClassifier"/>. The handlers are

‎sdk/core/Azure.Core/src/RequestContext.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ internal ResponseClassifier Apply(ResponseClassifier classifier)
128128
return classifier;
129129
}
130130

131-
if (classifier is CoreResponseClassifier coreClassifier)
131+
if (classifier is StatusCodeClassifier statusCodeClassifier)
132132
{
133-
CoreResponseClassifier clone = coreClassifier.Clone();
133+
StatusCodeClassifier clone = statusCodeClassifier.Clone();
134134
clone.Handlers = _handlers;
135135

136136
if (_statusCodes != null)

sdk/core/Azure.Core/src/CoreResponseClassifier.cs renamed to sdk/core/Azure.Core/src/StatusCodeClassifier.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ namespace Azure.Core
1212
/// This type inherits from ResponseClassifier and is designed to work
1313
/// efficiently with classifier customizations specified in <see cref="RequestContext"/>.
1414
/// </summary>
15-
public class CoreResponseClassifier : ResponseClassifier
15+
public class StatusCodeClassifier : ResponseClassifier
1616
{
1717
// We need 10 ulongs to represent status codes 100 - 599.
1818
private const int Length = 10;
@@ -21,21 +21,21 @@ public class CoreResponseClassifier : ResponseClassifier
2121
internal ResponseClassificationHandler[]? Handlers { get; set; }
2222

2323
/// <summary>
24-
/// Creates a new instance of <see cref="CoreResponseClassifier"/>
24+
/// Creates a new instance of <see cref="StatusCodeClassifier"/>
2525
/// </summary>
26-
/// <param name="successCodes">The status codes that this classifier will consider
26+
/// <param name="successStatusCodes">The status codes that this classifier will consider
2727
/// not to be errors.</param>
28-
public CoreResponseClassifier(ReadOnlySpan<ushort> successCodes)
28+
public StatusCodeClassifier(ReadOnlySpan<ushort> successStatusCodes)
2929
{
3030
_successCodes = new ulong[Length];
3131

32-
foreach (int statusCode in successCodes)
32+
foreach (int statusCode in successStatusCodes)
3333
{
3434
AddClassifier(statusCode, isError: false);
3535
}
3636
}
3737

38-
private CoreResponseClassifier(ulong[] successCodes, ResponseClassificationHandler[]? handlers)
38+
private StatusCodeClassifier(ulong[] successCodes, ResponseClassificationHandler[]? handlers)
3939
{
4040
Debug.Assert(successCodes?.Length == Length);
4141

@@ -62,12 +62,12 @@ public override bool IsErrorResponse(HttpMessage message)
6262
return !IsSuccessCode(message.Response.Status);
6363
}
6464

65-
internal virtual CoreResponseClassifier Clone()
65+
internal virtual StatusCodeClassifier Clone()
6666
{
6767
ulong[] successCodes = new ulong[Length];
6868
Array.Copy(_successCodes, successCodes, Length);
6969

70-
return new CoreResponseClassifier(successCodes, Handlers);
70+
return new StatusCodeClassifier(successCodes, Handlers);
7171
}
7272

7373
internal void AddClassifier(int statusCode, bool isError)

‎sdk/core/Azure.Core/tests/HttpMessageTests.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ public void SettingResponseClassifierReplacesBaseClassifier()
117117

118118
// This replaces the base classifier with one that thinks
119119
// only 404 is a non-error.
120-
message.ResponseClassifier = new CoreResponseClassifier(stackalloc ushort[] { 404 });
120+
message.ResponseClassifier = new StatusCodeClassifier(stackalloc ushort[] { 404 });
121121

122122
message.Response = new MockResponse(204);
123123
Assert.IsTrue(message.ResponseClassifier.IsErrorResponse(message));
@@ -147,7 +147,7 @@ public void SettingResponseClassifierReplacesBaseClassifier_PerCallCustomization
147147

148148
// This replaces the base classifier with one that only thinks 404 is a non-error
149149
// and doesn't have opinions on anything else.
150-
message.ResponseClassifier = new CoreResponseClassifier(stackalloc ushort[] { 404 });
150+
message.ResponseClassifier = new StatusCodeClassifier(stackalloc ushort[] { 404 });
151151

152152
message.Response = new MockResponse(304);
153153
Assert.IsTrue(message.ResponseClassifier.IsErrorResponse(message));
@@ -166,7 +166,7 @@ public void SettingResponseClassifierReplacesBaseClassifier_PerClientCustomizati
166166
ClientOptions.Default,
167167
new HttpPipelinePolicy[] { },
168168
new HttpPipelinePolicy[] { },
169-
new CoreResponseClassifier(stackalloc ushort[] { 404 }));
169+
new StatusCodeClassifier(stackalloc ushort[] { 404 }));
170170

171171
var message = pipeline.CreateMessage();
172172

@@ -176,7 +176,7 @@ public void SettingResponseClassifierReplacesBaseClassifier_PerClientCustomizati
176176
message.Response = new MockResponse(404);
177177
Assert.IsFalse(message.ResponseClassifier.IsErrorResponse(message));
178178

179-
message.ResponseClassifier = new CoreResponseClassifier(stackalloc ushort[] { 304 });
179+
message.ResponseClassifier = new StatusCodeClassifier(stackalloc ushort[] { 304 });
180180

181181
message.Response = new MockResponse(304);
182182
Assert.IsFalse(message.ResponseClassifier.IsErrorResponse(message));
@@ -242,7 +242,7 @@ public void AppliesHandlerBeforeResponseClassifier()
242242
}
243243

244244
[Test]
245-
public void AppliesNonCoreResponseClassifier_HeadResponseClassifier()
245+
public void AppliesNonStatusCodeClassifier_HeadResponseClassifier()
246246
{
247247
HttpMessage message = new HttpMessage(new MockRequest(), default);
248248
message.ApplyRequestContext(new RequestContext(), HeadResponseClassifier.Instance);
@@ -357,7 +357,7 @@ public override bool TryClassify(HttpMessage message, out bool isError)
357357

358358
// Example DPG classifier for testing purposes.
359359
private static ResponseClassifier _responseClassifier200204304;
360-
private static ResponseClassifier ResponseClassifier200204304 => _responseClassifier200204304 ??= new CoreResponseClassifier(stackalloc ushort[] { 200, 204, 304 });
360+
private static ResponseClassifier ResponseClassifier200204304 => _responseClassifier200204304 ??= new StatusCodeClassifier(stackalloc ushort[] { 200, 204, 304 });
361361

362362
private sealed class HeadResponseClassifier : ResponseClassifier
363363
{

‎sdk/core/Azure.Core/tests/HttpPipelineTests.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ public override bool IsErrorResponse(HttpMessage message)
376376

377377
// How classifiers will be generated in DPG.
378378
private static ResponseClassifier _responseClassifier200204304;
379-
private static ResponseClassifier ResponseClassifier200204304 => _responseClassifier200204304 ??= new CoreResponseClassifier(stackalloc ushort[] { 200, 204, 304 });
379+
private static ResponseClassifier ResponseClassifier200204304 => _responseClassifier200204304 ??= new StatusCodeClassifier(stackalloc ushort[] { 200, 204, 304 });
380380
#endregion
381381

382382
}

‎sdk/core/Azure.Core/tests/RequestContextTests.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public async Task CanSuppressLoggingAsError()
227227
var response = new MockResponse(404);
228228
var mockTransport = new MockTransport(response);
229229

230-
var classifier = new CoreResponseClassifier(stackalloc ushort[] { 200, 204, 304 });
230+
var classifier = new StatusCodeClassifier(stackalloc ushort[] { 200, 204, 304 });
231231
var pipeline = new HttpPipeline(mockTransport, new[] { new LoggingPolicy(logContent: true, int.MaxValue, HttpMessageSanitizer.Default, "Test SDK") });
232232

233233
var context = new RequestContext();
@@ -262,7 +262,7 @@ public async Task CanSuppressTracingAsError()
262262
return mockResponse;
263263
});
264264

265-
var classifier = new CoreResponseClassifier(stackalloc ushort[] { 200, 204, 304 });
265+
var classifier = new StatusCodeClassifier(stackalloc ushort[] { 200, 204, 304 });
266266
var pipeline = new HttpPipeline(mockTransport, new[] { new RequestActivityPolicy(true, "Azure.Core.Tests", HttpMessageSanitizer.Default) });
267267
var context = new RequestContext();
268268
context.AddClassifier(409, isError: false);

0 commit comments

Comments
 (0)