fix GetValuesAsync validation bug (Azure#24421)

Author: maririos

sdk/textanalytics/Azure.AI.TextAnalytics/CHANGELOG.md

@@ -7,6 +7,7 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- `AnalyzeActionsOperation.GetValuesAsync()` and `AnalyzeHealthcareEntitiesOperation.GetValuesAsync()` are now validating that the operation has completed successfully before attempting to return any values. An `InvalidOperationException` is thrown if this is not true.
 
 ### Other Changes
 

sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeActionsOperation.cs

@@ -228,7 +228,12 @@ public override async ValueTask<Response<AsyncPageable<AnalyzeActionsResult>>> W
         /// <remarks>
         /// Operation must complete successfully (HasValue is true) for it to provide values.
         /// </remarks>
-        public override AsyncPageable<AnalyzeActionsResult> GetValuesAsync(CancellationToken cancellationToken = default) => CreateOperationValueAsync(cancellationToken);
+        public override AsyncPageable<AnalyzeActionsResult> GetValuesAsync(CancellationToken cancellationToken = default)
+        {
+            // Validates that the operation has completed successfully.
+            _ = _operationInternal.Value;
+            return CreateOperationValueAsync(cancellationToken);
+        }
 
         /// <summary>
         /// Gets the final result of the long-running operation synchronously.

sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeHealthcareEntitiesOperation.cs

@@ -260,7 +260,12 @@ public virtual async Task CancelAsync(CancellationToken cancellationToken = defa
         /// <remarks>
         /// Operation must complete successfully (HasValue is true) for it to provide values.
         /// </remarks>
-        public override AsyncPageable<AnalyzeHealthcareEntitiesResultCollection> GetValuesAsync(CancellationToken cancellationToken = default) => CreateOperationValueAsync(cancellationToken);
+        public override AsyncPageable<AnalyzeHealthcareEntitiesResultCollection> GetValuesAsync(CancellationToken cancellationToken = default)
+        {
+            // Validates that the operation has completed successfully.
+            _ = _operationInternal.Value;
+            return CreateOperationValueAsync(cancellationToken);
+        }
 
         /// <summary>
         /// Gets the final result of the long-running operation in synchronously.

sdk/textanalytics/Azure.AI.TextAnalytics/tests/AnalyzeOperationTests.cs

@@ -318,7 +318,7 @@ public async Task AnalyzeOperationWithPagination()
             Assert.IsFalse(operation.HasValue);
 
             Assert.ThrowsAsync<InvalidOperationException>(async () => await Task.Run(() => operation.Value));
-            Assert.Throws<InvalidOperationException>(() => operation.GetValues());
+            Assert.ThrowsAsync<InvalidOperationException>(async () => await Task.Run(() => operation.GetValuesAsync()));
 
             await operation.WaitForCompletionAsync();
 

sdk/textanalytics/Azure.AI.TextAnalytics/tests/RecognizeHealthcareEntitiesTests.cs

@@ -400,7 +400,7 @@ public async Task AnalyzeHealthcareEntitiesPagination()
             Assert.IsFalse(operation.HasValue);
 
             Assert.ThrowsAsync<InvalidOperationException>(async () => await Task.Run(() => operation.Value));
-            Assert.Throws<InvalidOperationException>(() => operation.GetValues());
+            Assert.ThrowsAsync<InvalidOperationException>(async () => await Task.Run(() => operation.GetValuesAsync()));
 
             await operation.WaitForCompletionAsync();