Minor tweak and comment for DtmiConventions in models repository SDK (Azure#19429)

digimaun · web-flow · commit a6c95037fcc1 · 2021-03-10T10:55:30.000-08:00
* Increment changelog with date.
diff --git a/sdk/modelsrepository/Azure.Iot.ModelsRepository/CHANGELOG.md b/sdk/modelsrepository/Azure.Iot.ModelsRepository/CHANGELOG.md
@@ -1,6 +1,6 @@
 # Release History
 
-## 1.0.0-preview.1 (Unreleased)
+## 1.0.0-preview.1 (2021-03-10)
 
 ### New features
 
diff --git a/sdk/modelsrepository/Azure.Iot.ModelsRepository/src/DtmiConventions.cs b/sdk/modelsrepository/Azure.Iot.ModelsRepository/src/DtmiConventions.cs
@@ -50,7 +50,10 @@ public static Uri GetModelUri(string dtmi, Uri repositoryUri, bool expanded = fa
                     ModelsRepositoryConstants.ExpandedJsonFileExtension);
             }
 
-            UriBuilder repositoryUriBuilder = new UriBuilder(repositoryUri);
+            var repositoryUriBuilder = new UriBuilder(repositoryUri);
+
+            // If the base URI (repositoryUri in this case) path segment does not end in slash
+            // that segment will be dropped and not properly anchored to by the intended relative URI.
             if (!repositoryUriBuilder.Path.EndsWith("/", StringComparison.InvariantCultureIgnoreCase))
             {
                 repositoryUriBuilder.Path += "/";

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,10 @@ public static Uri GetModelUri(string dtmi, Uri repositoryUri, bool expanded = fa`
`50`	`50`	`ModelsRepositoryConstants.ExpandedJsonFileExtension);`
`51`	`51`	`}`
`52`	`52`
`53`		`- UriBuilder repositoryUriBuilder = new UriBuilder(repositoryUri);`
	`53`	`+ var repositoryUriBuilder = new UriBuilder(repositoryUri);`
	`54`	`+`
	`55`	`+ // If the base URI (repositoryUri in this case) path segment does not end in slash`
	`56`	`+ // that segment will be dropped and not properly anchored to by the intended relative URI.`
`54`	`57`	`if (!repositoryUriBuilder.Path.EndsWith("/", StringComparison.InvariantCultureIgnoreCase))`
`55`	`58`	`{`
`56`	`59`	`repositoryUriBuilder.Path += "/";`