remove IgnoreOnNet5Attribute and NoWarn exceptions (Azure#17793)

* remove IgnoreOnNet5Attribute and NoWarn exceptions

* re-record after adjusting double values for test data

Author: christothes

sdk/tables/Azure.Data.Tables/src/Azure.Data.Tables.csproj

@@ -6,8 +6,6 @@
     <DefineConstants>TableSDK;$(DefineConstants)</DefineConstants>
     <PackageTags>Microsoft Azure Tables;Microsoft;Azure;Tables;Table;$(PackageCommonTags)</PackageTags>
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
-    <!-- These supressions should be removed in a production library -->
-    <NoWarn>$(NoWarn);CA1812;CS1591</NoWarn>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
   <ItemGroup>

sdk/tables/Azure.Data.Tables/src/ITableEntity.cs

@@ -5,6 +5,13 @@
 
 namespace Azure.Data.Tables
 {
+    /// <summary>
+    /// An interface defining the required properties for a table entity model. Custom entity model types must implement this interface.
+    /// </summary>
+    ///
+    /// <remarks>
+    /// Two options exist for impelemtations of <see cref="ITableEntity"/>: Strongly typed custom entity model classes, and the provided <see cref="TableEntity"/> model.
+    /// </remarks>
     public interface ITableEntity
     {
         /// <summary>

sdk/tables/Azure.Data.Tables/src/Sas/TableSasQueryParameters.cs

@@ -41,6 +41,9 @@ public sealed class TableSasQueryParameters : TableAccountSasQueryParameters
         /// </summary>
         public string EndRowKey { get; set; }
 
+        /// <summary>
+        /// Gets empty shared access signature query parameters.
+        /// </summary>
         public static TableSasQueryParameters Empty => new TableSasQueryParameters();
 
         internal TableSasQueryParameters()
@@ -96,7 +99,7 @@ internal TableSasQueryParameters(
         internal TableSasQueryParameters(
             IDictionary<string, string> values)
             : base(values)
-        {}
+        { }
 
         /// <summary>
         /// Convert the SAS query parameters into a URL encoded query string.

sdk/tables/Azure.Data.Tables/src/TableBatchResponse.cs

@@ -8,7 +8,10 @@
 
 namespace Azure.Data.Tables.Models
 {
-    public partial class TableBatchResponse
+    /// <summary>
+    /// The response from <see cref="TableTransactionalBatch.SubmitBatch(System.Threading.CancellationToken)"/> or <see cref="TableTransactionalBatch.SubmitBatchAsync(System.Threading.CancellationToken)"/>.
+    /// </summary>
+    public class TableBatchResponse
     {
         internal IDictionary<string, (HttpMessage Message, RequestType RequestType)> _requestLookup;
 

sdk/tables/Azure.Data.Tables/src/TableClientOptions.cs

@@ -6,11 +6,26 @@
 
 namespace Azure.Data.Tables
 {
+    /// <summary>
+    /// Options to configure the requests to the Table service.
+    /// </summary>
     public class TableClientOptions : ClientOptions
     {
+        /// <summary>
+        /// The versions of Azure Tables supported by this client
+        /// library.
+        /// </summary>
         private const ServiceVersion Latest = ServiceVersion.V2019_02_02;
         internal static TableClientOptions Default { get; } = new TableClientOptions();
 
+        /// <summary>
+        /// Initializes a new instance of the <see cref="TableClientOptions"/> class.
+        /// class.
+        /// </summary>
+        /// <param name="serviceVersion">
+        /// The <see cref="ServiceVersion"/> of the service API used when
+        /// making requests.
+        /// </param>
         public TableClientOptions(ServiceVersion serviceVersion = Latest)
         {
             VersionString = serviceVersion switch
@@ -22,11 +37,17 @@ public TableClientOptions(ServiceVersion serviceVersion = Latest)
 
         internal string VersionString { get; }
 
+        /// <summary>
+        /// Gets the <see cref="ServiceVersion"/> of the service API used when making requests.
+        /// </summary>
         public enum ServiceVersion
         {
-#pragma warning disable CA1707
+#pragma warning disable CA1707 // Identifiers should not contain underscores
+            /// <summary>
+            /// The Tables API version 20019-02-02
+            /// </summary>
             V2019_02_02 = 1
-#pragma warning restore CA1707
+#pragma warning restore CA1707 // Identifiers should not contain underscores
         }
     }
 }

sdk/tables/Azure.Data.Tables/src/TableServiceClient.cs

@@ -12,6 +12,9 @@
 
 namespace Azure.Data.Tables
 {
+    /// <summary>
+    /// The <see cref="TableServiceClient"/> provides synchronous and asynchronous methods to perform table level operations with Azure Tables hosted in either Azure storage accounts or Azure Cosmos DB table API.
+    /// </summary>
     public class TableServiceClient
     {
         private readonly ClientDiagnostics _diagnostics;
@@ -199,6 +202,11 @@ public virtual TableAccountSasBuilder GetSasBuilder(string rawPermissions, Table
             return new TableAccountSasBuilder(rawPermissions, resourceTypes, expiresOn) { Version = _version };
         }
 
+        /// <summary>
+        /// Gets an instance of a <see cref="TableClient"/> configured with the current <see cref="TableServiceClient"/> options, affinitized to the specified <paramref name="tableName"/>.
+        /// </summary>
+        /// <param name="tableName"></param>
+        /// <returns></returns>
         public virtual TableClient GetTableClient(string tableName)
         {
             Argument.AssertNotNull(tableName, nameof(tableName));
@@ -218,44 +226,44 @@ public virtual TableClient GetTableClient(string tableName)
         /// <returns>An <see cref="AsyncPageable{T}"/> containing a collection of <see cref="TableItem"/>s.</returns>
         public virtual AsyncPageable<TableItem> GetTablesAsync(string filter = null, int? maxPerPage = null, CancellationToken cancellationToken = default)
         {
-                return PageableHelpers.CreateAsyncEnumerable(
-                    async pageSizeHint =>
+            return PageableHelpers.CreateAsyncEnumerable(
+                async pageSizeHint =>
+                {
+                    using DiagnosticScope scope = _diagnostics.CreateScope($"{nameof(TableServiceClient)}.{nameof(GetTables)}");
+                    scope.Start();
+                    try
                     {
-                        using DiagnosticScope scope = _diagnostics.CreateScope($"{nameof(TableServiceClient)}.{nameof(GetTables)}");
-                        scope.Start();
-                        try
-                        {
-                            var response = await _tableOperations.QueryAsync(
-                                null,
-                                new QueryOptions() { Filter = filter, Select = null, Top = pageSizeHint, Format = _format },
-                                cancellationToken).ConfigureAwait(false);
-                            return Page.FromValues(response.Value.Value, response.Headers.XMsContinuationNextTableName, response.GetRawResponse());
-                        }
-                        catch (Exception ex)
-                        {
-                            scope.Failed(ex);
-                            throw;
-                        }
-                    },
-                    async (nextLink, pageSizeHint) =>
+                        var response = await _tableOperations.QueryAsync(
+                            null,
+                            new QueryOptions() { Filter = filter, Select = null, Top = pageSizeHint, Format = _format },
+                            cancellationToken).ConfigureAwait(false);
+                        return Page.FromValues(response.Value.Value, response.Headers.XMsContinuationNextTableName, response.GetRawResponse());
+                    }
+                    catch (Exception ex)
                     {
-                        using DiagnosticScope scope = _diagnostics.CreateScope($"{nameof(TableServiceClient)}.{nameof(GetTables)}");
-                        scope.Start();
-                        try
-                        {
-                            var response = await _tableOperations.QueryAsync(
-                                nextTableName: nextLink,
-                                new QueryOptions() { Filter = filter, Select = null, Top = pageSizeHint, Format = _format },
-                                cancellationToken).ConfigureAwait(false);
-                            return Page.FromValues(response.Value.Value, response.Headers.XMsContinuationNextTableName, response.GetRawResponse());
-                        }
-                        catch (Exception ex)
-                        {
-                            scope.Failed(ex);
-                            throw;
-                        }
-                    },
-                    maxPerPage);
+                        scope.Failed(ex);
+                        throw;
+                    }
+                },
+                async (nextLink, pageSizeHint) =>
+                {
+                    using DiagnosticScope scope = _diagnostics.CreateScope($"{nameof(TableServiceClient)}.{nameof(GetTables)}");
+                    scope.Start();
+                    try
+                    {
+                        var response = await _tableOperations.QueryAsync(
+                            nextTableName: nextLink,
+                            new QueryOptions() { Filter = filter, Select = null, Top = pageSizeHint, Format = _format },
+                            cancellationToken).ConfigureAwait(false);
+                        return Page.FromValues(response.Value.Value, response.Headers.XMsContinuationNextTableName, response.GetRawResponse());
+                    }
+                    catch (Exception ex)
+                    {
+                        scope.Failed(ex);
+                        throw;
+                    }
+                },
+                maxPerPage);
         }
 
         /// <summary>

sdk/tables/Azure.Data.Tables/src/TableTransactionalBatch.cs

@@ -16,7 +16,10 @@
 
 namespace Azure.Data.Tables
 {
-    public partial class TableTransactionalBatch
+    /// <summary>
+    /// Provides synchronous and asynchronous methods for creating and submitting table transactional batch requests.
+    /// </summary>
+    public class TableTransactionalBatch
     {
         private readonly TableRestClient _tableOperations;
         private readonly TableRestClient _batchOperations;