[Communication] - New version of Identity Service (Azure#18066)

* Adding new Identity API design

* Rename token to access token

* Use some of the previous type names

* Update the livetest recordings

* Communication - Extract the Identity Client out of the Administration library

* Remove optional properties of CommunicationIdentityClientOptions.ctor

* Update the Changelogs

* Update ReadMe

* Remove unused files

* Use the approved swagger

* Update the status code in the chat recorded tests

* Update the Administration package README

* Update README

Co-authored-by: Minnie Liu <peiliu@microsoft.com>
Co-authored-by: Dominik <domessin@microsoft.com>

Author: 3 people

sdk/communication/Azure.Communication.Administration/CHANGELOG.md

@@ -3,16 +3,14 @@
 ## 1.0.0-beta.4 (Unreleased)
 
 ### Added
-- Added support to create CommunicationIdentityClient with TokenCredential.
-- Added support to create CommunicationIdentityClient with AzureKeyCredential.
 - Added support to create PhoneNumberAdministrationClient with AzureKeyCredential.
 - Added support to create PhoneNumberAdministrationClient with TokenCredential
 
 ### Fixed
 - Issue with paging results not pulling next pages
 
 ### Breaking
-- CommunicationTokenScope.Pstn is removed.
+- CommunicationIdentityClient is moved to a new NuGet package, `Azure.Communication.Identity`.
 
 
 ## 1.0.0-beta.3 (2020-11-16)

sdk/communication/Azure.Communication.Administration/README.md

@@ -1,11 +1,10 @@
 # Azure Communication Administration client library for .NET
 
 > Server Version:
-> Identity client: 2020-07-20-preview2
 
 > Phone number administration client: 2020-07-20-preview1
 
-Azure Communication Administration is managing tokens and phone numbers for Azure Communication Services.
+Azure Communication Administration is managing phone numbers for Azure Communication Services.
 
 [Source code][source] | [Package (NuGet)][package] | [Product documentation][product_docs] | [Samples][source_samples]
 
@@ -33,90 +32,13 @@ Here's an example using the Azure CLI:
 ```
 -->
 
-### Authenticate the client
-
-Administration clients can be authenticated using connection string acquired from an Azure Communication Resources in the [Azure Portal][azure_portal].
-
-```C# Snippet:CreateCommunicationIdentityClient
-// Get a connection string to our Azure Communication resource.
-var connectionString = "<connection_string>";
-var client = new CommunicationIdentityClient(connectionString);
-```
-
-Clients also have the option to authenticate using a valid token.
-
-```C# Snippet:CreateCommunicationIdentityFromToken
-var endpoint = new Uri("https://my-resource.communication.azure.com");
-TokenCredential tokenCredential = new DefaultAzureCredential();
-var client = new CommunicationIdentityClient(endpoint, tokenCredential);
-```
-
 ### Key concepts
 
-`CommunicationIdentityClient` provides the functionalities to manage user access tokens: creating new ones, renewing and revoking them.
-
-## Examples
-
-### Create a new identity
-
-```C# Snippet:CreateCommunicationUserAsync
-Response<CommunicationUserIdentifier> userResponse = await client.CreateUserAsync();
-CommunicationUserIdentifier user = userResponse.Value;
-Console.WriteLine($"User id: {user.Id}");
-```
-
-### Issuing or Refreshing a token for an existing identity
-
-```C# Snippet:CreateCommunicationTokenAsync
-Response<CommunicationUserToken> tokenResponse = await client.IssueTokenAsync(user, scopes: new[] { CommunicationTokenScope.Chat });
-string token = tokenResponse.Value.Token;
-DateTimeOffset expiresOn = tokenResponse.Value.ExpiresOn;
-Console.WriteLine($"Token: {token}");
-Console.WriteLine($"Expires On: {expiresOn}");
-```
-
-### Revoking a user's tokens
-
-In case a user's tokens are compromised or need to be revoked:
-
-```C# Snippet:RevokeCommunicationUserToken
-Response revokeResponse = client.RevokeTokens(
-    user,
-    issuedBefore: DateTimeOffset.UtcNow.AddDays(-1) /* optional */);
-```
-
-### Deleting a user
-
-```C# Snippet:DeleteACommunicationUser
-Response deleteResponse = client.DeleteUser(user);
-```
-
-## Troubleshooting
-
-All User token service operations will throw a RequestFailedException on failure.
-
-```C# Snippet:CommunicationIdentityClient_Troubleshooting
-// Get a connection string to our Azure Communication resource.
-var connectionString = "<connection_string>";
-var client = new CommunicationIdentityClient(connectionString);
-
-try
-{
-    Response<CommunicationUserIdentifier> response = await client.CreateUserAsync();
-}
-catch (RequestFailedException ex)
-{
-    Console.WriteLine(ex.Message);
-}
-```
-
-### Phone plans overview
-
 Phone plans come in two types; Geographic and Toll-Free. Geographic phone plans are phone plans associated with a location, whose phone numbers' area codes are associated with the area code of a geographic location. Toll-Free phone plans are phone plans not associated location. For example, in the US, toll-free numbers can come with area codes such as 800 or 888.
 
 All geographic phone plans within the same country are grouped into a phone plan group with a Geographic phone number type. All Toll-Free phone plans within the same country are grouped into a phone plan group.
 
-### Authenticate the Phone Number Administration client
+### Authenticate the client
 
 Phone Number Administration clients can be authenticated using connection string acquired from an Azure Communication Resources in the [Azure Portal][azure_portal].
 
@@ -256,6 +178,7 @@ await releasePhoneNumberOperation.WaitForCompletionAsync().ConfigureAwait(false)
 
 Console.WriteLine($"ReleaseId: {releasePhoneNumberOperation.Value.ReleaseId}, Status: {releasePhoneNumberOperation.Value.Status}");
 ```
+## Troubleshooting
 
 ## Next steps
 
@@ -280,7 +203,6 @@ This project has adopted the [Microsoft Open Source Code of Conduct][coc]. For m
 [package]: https://www.nuget.org/packages/Azure.Communication.Administration
 [product_docs]: https://docs.microsoft.com/azure/communication-services/overview
 [nuget]: https://www.nuget.org/
-[user_access_token]: https://docs.microsoft.com/azure/communication-services/quickstarts/access-tokens?pivots=programming-language-csharp
 [communication_resource_docs]: https://docs.microsoft.com/azure/communication-services/quickstarts/create-communication-resource?tabs=windows&pivots=platform-azp
 [communication_resource_create_portal]: https://docs.microsoft.com/azure/communication-services/quickstarts/create-communication-resource?tabs=windows&pivots=platform-azp
 [communication_resource_create_power_shell]: https://docs.microsoft.com/powershell/module/az.communication/new-azcommunicationservice

sdk/communication/Azure.Communication.Administration/api/Azure.Communication.Administration.netstandard2.0.cs

@@ -1,52 +1,10 @@
 namespace Azure.Communication.Administration
 {
-    public partial class CommunicationIdentityClient
-    {
-        protected CommunicationIdentityClient() { }
-        public CommunicationIdentityClient(string connectionString, Azure.Communication.Administration.CommunicationIdentityClientOptions? options = null) { }
-        public CommunicationIdentityClient(System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.Communication.Administration.CommunicationIdentityClientOptions? options = null) { }
-        public CommunicationIdentityClient(System.Uri endpoint, Azure.Core.TokenCredential tokenCredential, Azure.Communication.Administration.CommunicationIdentityClientOptions? options = null) { }
-        public virtual Azure.Response<Azure.Communication.CommunicationUserIdentifier> CreateUser(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.CommunicationUserIdentifier>> CreateUserAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.Response DeleteUser(Azure.Communication.CommunicationUserIdentifier communicationUser, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response> DeleteUserAsync(Azure.Communication.CommunicationUserIdentifier communicationUser, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.Response<Azure.Communication.Administration.Models.CommunicationUserToken> IssueToken(Azure.Communication.CommunicationUserIdentifier communicationUser, System.Collections.Generic.IEnumerable<Azure.Communication.Administration.CommunicationTokenScope> scopes, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.Administration.Models.CommunicationUserToken>> IssueTokenAsync(Azure.Communication.CommunicationUserIdentifier communicationUser, System.Collections.Generic.IEnumerable<Azure.Communication.Administration.CommunicationTokenScope> scopes, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.Response RevokeTokens(Azure.Communication.CommunicationUserIdentifier communicationUser, System.DateTimeOffset? issuedBefore = default(System.DateTimeOffset?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response> RevokeTokensAsync(Azure.Communication.CommunicationUserIdentifier communicationUser, System.DateTimeOffset? issuedBefore = default(System.DateTimeOffset?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-    }
-    public partial class CommunicationIdentityClientOptions : Azure.Core.ClientOptions
-    {
-        public const Azure.Communication.Administration.CommunicationIdentityClientOptions.ServiceVersion LatestVersion = Azure.Communication.Administration.CommunicationIdentityClientOptions.ServiceVersion.V1;
-        public CommunicationIdentityClientOptions(Azure.Communication.Administration.CommunicationIdentityClientOptions.ServiceVersion version = Azure.Communication.Administration.CommunicationIdentityClientOptions.ServiceVersion.V1, Azure.Core.RetryOptions? retryOptions = null, Azure.Core.Pipeline.HttpPipelineTransport? transport = null) { }
-        public enum ServiceVersion
-        {
-            V1 = 1,
-        }
-    }
-    [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
-    public readonly partial struct CommunicationTokenScope : System.IEquatable<Azure.Communication.Administration.CommunicationTokenScope>
-    {
-        private readonly object _dummy;
-        private readonly int _dummyPrimitive;
-        public CommunicationTokenScope(string value) { throw null; }
-        public static Azure.Communication.Administration.CommunicationTokenScope Chat { get { throw null; } }
-        public static Azure.Communication.Administration.CommunicationTokenScope VoIP { get { throw null; } }
-        public bool Equals(Azure.Communication.Administration.CommunicationTokenScope other) { throw null; }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public override bool Equals(object obj) { throw null; }
-        [System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
-        public override int GetHashCode() { throw null; }
-        public static bool operator ==(Azure.Communication.Administration.CommunicationTokenScope left, Azure.Communication.Administration.CommunicationTokenScope right) { throw null; }
-        public static implicit operator Azure.Communication.Administration.CommunicationTokenScope (string value) { throw null; }
-        public static bool operator !=(Azure.Communication.Administration.CommunicationTokenScope left, Azure.Communication.Administration.CommunicationTokenScope right) { throw null; }
-        public override string ToString() { throw null; }
-    }
     public partial class PhoneNumberAdministrationClient
     {
         protected PhoneNumberAdministrationClient() { }
         public PhoneNumberAdministrationClient(string connectionString, Azure.Communication.Administration.PhoneNumberAdministrationClientOptions? options = null) { }
-        public PhoneNumberAdministrationClient(System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.Communication.Administration.CommunicationIdentityClientOptions? options = null) { }
+        public PhoneNumberAdministrationClient(System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.Communication.Administration.PhoneNumberAdministrationClientOptions? options = null) { }
         public PhoneNumberAdministrationClient(System.Uri endpoint, Azure.Core.TokenCredential tokenCredential, Azure.Communication.Administration.PhoneNumberAdministrationClientOptions? options = null) { }
         public virtual Azure.Response CancelReservation(string reservationId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
         public virtual System.Threading.Tasks.Task<Azure.Response> CancelReservationAsync(string reservationId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
@@ -137,7 +95,6 @@ public static partial class AdministrationModelFactory
         public static Azure.Communication.Administration.Models.AcquiredPhoneNumber AcquiredPhoneNumber(string phoneNumber, System.Collections.Generic.IEnumerable<Azure.Communication.Administration.Models.PhoneNumberCapability> acquiredCapabilities, System.Collections.Generic.IEnumerable<Azure.Communication.Administration.Models.PhoneNumberCapability> availableCapabilities) { throw null; }
         public static Azure.Communication.Administration.Models.AreaCodes AreaCodes(System.Collections.Generic.IReadOnlyList<string> primaryAreaCodes, System.Collections.Generic.IReadOnlyList<string> secondaryAreaCodes, string nextLink) { throw null; }
         public static Azure.Communication.Administration.Models.CarrierDetails CarrierDetails(string name, string localizedName) { throw null; }
-        public static Azure.Communication.Administration.Models.CommunicationUserToken CommunicationUserToken(string id, string token, System.DateTimeOffset expiresOn) { throw null; }
         public static Azure.Communication.Administration.Models.LocationOptions LocationOptions(string labelId, string labelName, System.Collections.Generic.IList<Azure.Communication.Administration.Models.LocationOptionsDetails> options) { throw null; }
         public static Azure.Communication.Administration.Models.LocationOptionsDetails LocationOptionsDetails(string name, string value, System.Collections.Generic.IList<Azure.Communication.Administration.Models.LocationOptions> locationOptions) { throw null; }
         public static Azure.Communication.Administration.Models.LocationOptionsResponse LocationOptionsResponse(Azure.Communication.Administration.Models.LocationOptions locationOptions) { throw null; }
@@ -213,13 +170,6 @@ internal CarrierDetails() { }
         public string LocalizedName { get { throw null; } }
         public string Name { get { throw null; } }
     }
-    public partial class CommunicationUserToken
-    {
-        internal CommunicationUserToken() { }
-        public System.DateTimeOffset ExpiresOn { get { throw null; } }
-        public string Token { get { throw null; } }
-        public Azure.Communication.CommunicationUserIdentifier User { get { throw null; } }
-    }
     public partial class CreateReservationOptions
     {
         public CreateReservationOptions(string displayName, string description, System.Collections.Generic.IEnumerable<string> phonePlanIds, string areaCode) { }