Skip to content

Commit 8ba6846

Browse files
Remove LinkCloseMode (Azure#16996)
* Remove LinkCloseMode * Export API
1 parent acc8c80 commit 8ba6846

File tree

6 files changed

+6
-18
lines changed

6 files changed

+6
-18
lines changed

sdk/servicebus/Azure.Messaging.ServiceBus/api/Azure.Messaging.ServiceBus.netstandard2.0.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ public CreateMessageBatchOptions() { }
1111
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
1212
public override string ToString() { throw null; }
1313
}
14-
public enum LinkCloseMode
15-
{
16-
Detach = 0,
17-
}
1814
public sealed partial class ProcessErrorEventArgs : System.EventArgs
1915
{
2016
public ProcessErrorEventArgs(System.Exception exception, Azure.Messaging.ServiceBus.ServiceBusErrorSource errorSource, string fullyQualifiedNamespace, string entityPath, System.Threading.CancellationToken cancellationToken) { }
@@ -212,7 +208,7 @@ protected ServiceBusProcessor() { }
212208
public Azure.Messaging.ServiceBus.ServiceBusReceiveMode ReceiveMode { get { throw null; } }
213209
public event System.Func<Azure.Messaging.ServiceBus.ProcessErrorEventArgs, System.Threading.Tasks.Task> ProcessErrorAsync { add { } remove { } }
214210
public event System.Func<Azure.Messaging.ServiceBus.ProcessMessageEventArgs, System.Threading.Tasks.Task> ProcessMessageAsync { add { } remove { } }
215-
public virtual System.Threading.Tasks.Task CloseAsync(Azure.Messaging.ServiceBus.LinkCloseMode closeMode = Azure.Messaging.ServiceBus.LinkCloseMode.Detach, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
211+
public virtual System.Threading.Tasks.Task CloseAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
216212
public System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
217213
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
218214
public override bool Equals(object obj) { throw null; }
@@ -281,7 +277,7 @@ protected ServiceBusReceiver() { }
281277
public int PrefetchCount { get { throw null; } }
282278
public Azure.Messaging.ServiceBus.ServiceBusReceiveMode ReceiveMode { get { throw null; } }
283279
public virtual System.Threading.Tasks.Task AbandonMessageAsync(Azure.Messaging.ServiceBus.ServiceBusReceivedMessage message, System.Collections.Generic.IDictionary<string, object> propertiesToModify = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
284-
public virtual System.Threading.Tasks.Task CloseAsync(Azure.Messaging.ServiceBus.LinkCloseMode closeMode = Azure.Messaging.ServiceBus.LinkCloseMode.Detach, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
280+
public virtual System.Threading.Tasks.Task CloseAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
285281
public virtual System.Threading.Tasks.Task CompleteMessageAsync(Azure.Messaging.ServiceBus.ServiceBusReceivedMessage message, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
286282
public virtual System.Threading.Tasks.Task DeadLetterMessageAsync(Azure.Messaging.ServiceBus.ServiceBusReceivedMessage message, System.Collections.Generic.IDictionary<string, object> propertiesToModify = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
287283
public virtual System.Threading.Tasks.Task DeadLetterMessageAsync(Azure.Messaging.ServiceBus.ServiceBusReceivedMessage message, string deadLetterReason, string deadLetterErrorDescription = null, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
@@ -350,7 +346,7 @@ protected ServiceBusSender() { }
350346
public bool IsClosed { get { throw null; } }
351347
public virtual System.Threading.Tasks.Task CancelScheduledMessageAsync(long sequenceNumber, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
352348
public virtual System.Threading.Tasks.Task CancelScheduledMessagesAsync(System.Collections.Generic.IEnumerable<long> sequenceNumbers, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
353-
public virtual System.Threading.Tasks.Task CloseAsync(Azure.Messaging.ServiceBus.LinkCloseMode closeMode = Azure.Messaging.ServiceBus.LinkCloseMode.Detach, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
349+
public virtual System.Threading.Tasks.Task CloseAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
354350
public virtual System.Threading.Tasks.ValueTask<Azure.Messaging.ServiceBus.ServiceBusMessageBatch> CreateMessageBatchAsync(Azure.Messaging.ServiceBus.CreateMessageBatchOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
355351
public virtual System.Threading.Tasks.ValueTask<Azure.Messaging.ServiceBus.ServiceBusMessageBatch> CreateMessageBatchAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
356352
public virtual System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
@@ -383,7 +379,7 @@ protected ServiceBusSessionProcessor() { }
383379
public event System.Func<Azure.Messaging.ServiceBus.ProcessSessionMessageEventArgs, System.Threading.Tasks.Task> ProcessMessageAsync { add { } remove { } }
384380
public event System.Func<Azure.Messaging.ServiceBus.ProcessSessionEventArgs, System.Threading.Tasks.Task> SessionClosingAsync { add { } remove { } }
385381
public event System.Func<Azure.Messaging.ServiceBus.ProcessSessionEventArgs, System.Threading.Tasks.Task> SessionInitializingAsync { add { } remove { } }
386-
public virtual System.Threading.Tasks.Task CloseAsync(Azure.Messaging.ServiceBus.LinkCloseMode closeMode = Azure.Messaging.ServiceBus.LinkCloseMode.Detach, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
382+
public virtual System.Threading.Tasks.Task CloseAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
387383
public System.Threading.Tasks.ValueTask DisposeAsync() { throw null; }
388384
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
389385
public override bool Equals(object obj) { throw null; }

sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/LinkCloseMode.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace Azure.Messaging.ServiceBus
66
/// <summary>
77
/// The mode in which links will be closed.
88
/// </summary>
9-
public enum LinkCloseMode
9+
internal enum LinkCloseMode
1010
{
1111
/// <summary>
1212
/// The link will be detached when closing.

sdk/servicebus/Azure.Messaging.ServiceBus/src/Processor/ServiceBusProcessor.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -718,11 +718,9 @@ internal void EnsureNotRunningAndInvoke(Action action)
718718
/// <summary>
719719
/// Performs the task needed to clean up resources used by the <see cref="ServiceBusProcessor" />.
720720
/// </summary>
721-
/// <param name="closeMode">The mode indicating what should happen to the link when closing.</param>
722721
/// <param name="cancellationToken"> An optional<see cref="CancellationToken"/> instance to signal the
723722
/// request to cancel the operation.</param>
724723
public virtual async Task CloseAsync(
725-
LinkCloseMode closeMode = LinkCloseMode.Detach,
726724
CancellationToken cancellationToken = default)
727725
{
728726
IsClosed = true;

sdk/servicebus/Azure.Messaging.ServiceBus/src/Processor/ServiceBusSessionProcessor.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -223,13 +223,11 @@ public virtual async Task StopProcessingAsync(CancellationToken cancellationToke
223223
/// <summary>
224224
/// Performs the task needed to clean up resources used by the <see cref="ServiceBusSessionProcessor" />.
225225
/// </summary>
226-
/// <param name="closeMode">The mode indicating what should happen to the link when closing.</param>
227226
/// <param name="cancellationToken"> An optional<see cref="CancellationToken"/> instance to signal the
228227
/// request to cancel the operation.</param>
229228
public virtual async Task CloseAsync(
230-
LinkCloseMode closeMode = LinkCloseMode.Detach,
231229
CancellationToken cancellationToken = default) =>
232-
await _innerProcessor.CloseAsync(closeMode).ConfigureAwait(false);
230+
await _innerProcessor.CloseAsync().ConfigureAwait(false);
233231

234232
/// <summary>
235233
/// Performs the task needed to clean up resources used by the <see cref="ServiceBusSessionProcessor" />.

sdk/servicebus/Azure.Messaging.ServiceBus/src/Receiver/ServiceBusReceiver.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,11 +195,9 @@ protected ServiceBusReceiver() { }
195195
/// <summary>
196196
/// Performs the task needed to clean up resources used by the <see cref="ServiceBusReceiver" />.
197197
/// </summary>
198-
/// <param name="closeMode">The mode indicating what should happen to the link when closing.</param>
199198
/// <param name="cancellationToken"> An optional<see cref="CancellationToken"/> instance to signal the
200199
/// request to cancel the operation.</param>
201200
public virtual async Task CloseAsync(
202-
LinkCloseMode closeMode = LinkCloseMode.Detach,
203201
CancellationToken cancellationToken = default)
204202
{
205203
IsClosed = true;

sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -542,11 +542,9 @@ public virtual async Task CancelScheduledMessagesAsync(
542542
/// <summary>
543543
/// Performs the task needed to clean up resources used by the <see cref="ServiceBusSender" />.
544544
/// </summary>
545-
/// <param name="closeMode">The mode indicating what should happen to the link when closing.</param>
546545
/// <param name="cancellationToken"> An optional<see cref="CancellationToken"/> instance to signal the
547546
/// request to cancel the operation.</param>
548547
public virtual async Task CloseAsync(
549-
LinkCloseMode closeMode = LinkCloseMode.Detach,
550548
CancellationToken cancellationToken = default)
551549
{
552550
IsClosed = true;

0 commit comments

Comments
 (0)