Update Roslyn Analyzers (Azure#23793)

heaths · web-flow · commit 8ba15b38b60e · 2021-09-22T00:37:19.000Z
* Update Roslyn Analyzers Update Azure.ClientSdk.Analyzers and suppress newly-added AZC0016. Relates to Azure/azure-sdk-tools#1961 * Suppress or otherwise deal with AZC0016 violations * Fix typo * Fix CLU test build break from rename * Update public APIs for CLU
diff --git a/eng/Packages.Data.props b/eng/Packages.Data.props
@@ -134,11 +134,11 @@
 
   <!--
     Build time packages
-    All should have PrivateAssets="All" set so they don't become pacakge dependencies
+    All should have PrivateAssets="All" set so they don't become package dependencies
   -->
   <ItemGroup>
     <PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20210915.2" PrivateAssets="All" />
-    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210601.1" PrivateAssets="All" />
+    <PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20210903.4" PrivateAssets="All" />
     <PackageReference Update="coverlet.collector" Version="1.3.0" PrivateAssets="All" />
     <PackageReference Update="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1" PrivateAssets="All" />
     <PackageReference Update="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.2" PrivateAssets="All" />
diff --git a/eng/service.proj b/eng/service.proj
@@ -20,7 +20,7 @@
     <PerfProjects Include="..\sdk\$(ServiceDirectory)\$(Project)\perf\**\*.csproj" />
     <StressProjects Include="..\sdk\$(ServiceDirectory)\$(Project)\stress\**\*.csproj" />
     <SampleApplications Include="..\samples\**\*.csproj" />
-    <SrcProjects Include="..\sdk\$(ServiceDirectory)\$(Project)\*.csproj" Exclude="@(TestProjects);@(SamplesProjects)"/>
+    <SrcProjects Include="..\sdk\$(ServiceDirectory)\$(Project)\src\**\*.csproj" />
     <ProjectReference Include="@(TestProjects)" Exclude="@(MgmtExcludePaths)" Condition="'$(IncludeTests)' == 'true'" />
     <ProjectReference Include="@(SamplesProjects)" Exclude="@(MgmtExcludePaths)" Condition="'$(IncludeSamples)' == 'true'" />
     <ProjectReference Include="@(PerfProjects)" Exclude="@(MgmtExcludePaths)" Condition="'$(IncludePerf)' == 'true'" />
diff --git a/sdk/agrifood/Azure.Verticals.AgriFood.Farming/src/GlobalSuppressions.cs b/sdk/agrifood/Azure.Verticals.AgriFood.Farming/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Verticals.AgriFood.Farming.FarmBeatsClientOptions.ServiceVersion")]
diff --git a/sdk/anomalydetector/Azure.AI.AnomalyDetector/src/GlobalSuppressions.cs b/sdk/anomalydetector/Azure.AI.AnomalyDetector/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.AI.AnomalyDetector.AnomalyDetectorClientOptions.ServiceVersion")]
diff --git a/sdk/cognitivelanguage/Azure.AI.Language.Conversations/api/Azure.AI.Language.Conversations.netstandard2.0.cs b/sdk/cognitivelanguage/Azure.AI.Language.Conversations/api/Azure.AI.Language.Conversations.netstandard2.0.cs
@@ -25,10 +25,10 @@ public ConversationAnalysisClient(System.Uri endpoint, Azure.AzureKeyCredential
     }
     public partial class ConversationAnalysisClientOptions : Azure.Core.ClientOptions
     {
-        public ConversationAnalysisClientOptions(Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion version = Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_preview) { }
+        public ConversationAnalysisClientOptions(Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion version = Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_Preview) { }
         public enum ServiceVersion
         {
-            V2021_07_15_preview = 1,
+            V2021_07_15_Preview = 1,
         }
     }
 }
diff --git a/sdk/cognitivelanguage/Azure.AI.Language.Conversations/src/ConversationAnalysisClientOptions.cs b/sdk/cognitivelanguage/Azure.AI.Language.Conversations/src/ConversationAnalysisClientOptions.cs
@@ -11,7 +11,7 @@ namespace Azure.AI.Language.Conversations
     /// </summary>
     public partial class ConversationAnalysisClientOptions : ClientOptions
     {
-        private const ServiceVersion LatestVersion = ServiceVersion.V2021_07_15_preview;
+        private const ServiceVersion LatestVersion = ServiceVersion.V2021_07_15_Preview;
 
         /// <summary>
         /// The version of the service to use.
@@ -22,7 +22,7 @@ public enum ServiceVersion
             /// <summary>
             /// Service version "2021-07-15-preview".
             /// </summary>
-            V2021_07_15_preview = 1,
+            V2021_07_15_Preview = 1,
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
 
@@ -35,7 +35,7 @@ public ConversationAnalysisClientOptions(ServiceVersion version = LatestVersion)
         {
             Version = version switch
             {
-                ServiceVersion.V2021_07_15_preview => "2021-07-15-preview",
+                ServiceVersion.V2021_07_15_Preview => "2021-07-15-preview",
                 _ => throw new NotSupportedException()
             };
 
diff --git a/sdk/cognitivelanguage/Azure.AI.Language.Conversations/tests/Infrastructure/ConversationAnalysisTestBase.cs b/sdk/cognitivelanguage/Azure.AI.Language.Conversations/tests/Infrastructure/ConversationAnalysisTestBase.cs
@@ -9,7 +9,7 @@ namespace Azure.AI.Language.Conversations.Tests
     /// Base class for live client tests using different service versions.
     /// </summary>
     /// <typeparam name="TClient">The type of client being tested.</typeparam>
-    [ClientTestFixture(ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_preview)]
+    [ClientTestFixture(ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_Preview)]
     public abstract class ConversationAnalysisTestBase<TClient> : RecordedTestBase<ConversationAnalysisTestEnvironment> where TClient : class
     {
         protected ConversationAnalysisTestBase(bool isAsync, ConversationAnalysisClientOptions.ServiceVersion serviceVersion, RecordedTestMode? mode)
diff --git a/sdk/cognitivelanguage/Azure.AI.Language.QuestionAnswering/src/QuestionAnsweringClientOptions.cs b/sdk/cognitivelanguage/Azure.AI.Language.QuestionAnswering/src/QuestionAnsweringClientOptions.cs
@@ -22,7 +22,9 @@ public enum ServiceVersion
             /// <summary>
             /// Service version "2021-05-01-preview".
             /// </summary>
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V2021_05_01_preview = 1,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
 
diff --git a/sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClientOptions.cs b/sdk/communication/Azure.Communication.Identity/src/CommunicationIdentityClientOptions.cs
@@ -44,7 +44,9 @@ public enum ServiceVersion
             /// <summary>
             /// The V2021_03_31_preview1 of the identity service.
             /// </summary>
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V2021_03_31_preview1 = 2,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
     }
diff --git a/sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClientOptions.cs b/sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClientOptions.cs
@@ -39,7 +39,9 @@ public enum ServiceVersion
             /// <summary>
             /// The V2021_06_21_preview of the networking service.
             /// </summary>
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V2021_06_21_preview = 1,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
     }
diff --git a/sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/GlobalSuppressions.cs b/sdk/confidentialledger/Azure.Security.ConfidentialLedger/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Security.ConfidentialLedger.ConfidentialLedgerClientOptions.ServiceVersion")]
diff --git a/sdk/mixedreality/Azure.MixedReality.Authentication/src/MixedRealityStsClientOptions.cs b/sdk/mixedreality/Azure.MixedReality.Authentication/src/MixedRealityStsClientOptions.cs
@@ -37,7 +37,9 @@ public enum ServiceVersion
             /// Version 2019-02-28-preview of the Mixed Reality STS service.
             /// </summary>
 #pragma warning disable CA1707 // Identifiers should not contain underscores
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V2019_02_28_preview = 1,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
     }
diff --git a/sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/ObjectAnchorsConversionClientOptions.cs b/sdk/objectanchors/Azure.MixedReality.ObjectAnchors.Conversion/src/ObjectAnchorsConversionClientOptions.cs
@@ -73,7 +73,9 @@ public enum ServiceVersion
             /// Version 0.2-preview.0 of the Azure Object Anchors service.
             /// </summary>
 #pragma warning disable CA1707 // Identifiers should not contain underscores
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V0_2_preview_0 = 1,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
     }
diff --git a/sdk/personalizer/Azure.AI.Personalizer/src/GlobalSuppressions.cs b/sdk/personalizer/Azure.AI.Personalizer/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.AI.Personalizer.PersonalizerClientOptions.ServiceVersion")]
diff --git a/sdk/purview/Azure.Analytics.Purview.Account/src/GlobalSuppressions.cs b/sdk/purview/Azure.Analytics.Purview.Account/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Analytics.Purview.Account.PurviewAccountClientOptions.ServiceVersion")]
diff --git a/sdk/purview/Azure.Analytics.Purview.Catalog/src/GlobalSuppressions.cs b/sdk/purview/Azure.Analytics.Purview.Catalog/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Analytics.Purview.Catalog.PurviewCatalogClientOptions.ServiceVersion")]
diff --git a/sdk/purview/Azure.Analytics.Purview.Scanning/src/GlobalSuppressions.cs b/sdk/purview/Azure.Analytics.Purview.Scanning/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Analytics.Purview.Scanning.PurviewScanningServiceClientOptions.ServiceVersion")]
diff --git a/sdk/schemaregistry/Azure.Data.SchemaRegistry/src/SchemaRegistryClientOptions.cs b/sdk/schemaregistry/Azure.Data.SchemaRegistry/src/SchemaRegistryClientOptions.cs
@@ -39,7 +39,9 @@ public enum ServiceVersion
             /// <summary>
             /// Version 2020-09-01-preview of the Schema Registry service.
             /// </summary>
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             V2020_09_01_preview = 2
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore
         }
     }
diff --git a/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/GlobalSuppressions.cs b/sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Analytics.Synapse.Artifacts.ArtifactsClientOptions.ServiceVersion")]
diff --git a/sdk/synapse/Azure.Analytics.Synapse.Monitoring/src/GlobalSuppressions.cs b/sdk/synapse/Azure.Analytics.Synapse.Monitoring/src/GlobalSuppressions.cs
@@ -0,0 +1,6 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Usage", "AZC0016:Invalid ServiceVersion member name.", Justification = "Generated code: https://github.com/Azure/autorest.csharp/issues/1524", Scope = "type", Target = "~T:Azure.Analytics.Synapse.Monitoring.MonitoringClientOptions.ServiceVersion")]
diff --git a/sdk/webpubsub/Azure.Messaging.WebPubSub/src/WebPubSubServiceClientOptions.ServiceVersion.cs b/sdk/webpubsub/Azure.Messaging.WebPubSub/src/WebPubSubServiceClientOptions.ServiceVersion.cs
@@ -24,10 +24,12 @@ public partial class WebPubSubServiceClientOptions : ClientOptions
         public enum ServiceVersion
         {
 #pragma warning disable CA1707 // Identifiers should not contain underscores
+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             /// <summary> The 2021_05_01_preview version of the Azure WebPubSub service. </summary>
             V2021_05_01_preview = 1,
             /// <summary> The 2021_08_01_preview version of the Azure WebPubSub service. </summary>
             V2021_08_01_preview = 2,
+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }
 

Original file line number	Diff line number	Diff line change
`@@ -25,10 +25,10 @@ public ConversationAnalysisClient(System.Uri endpoint, Azure.AzureKeyCredential`
`25`	`25`	`}`
`26`	`26`	`public partial class ConversationAnalysisClientOptions : Azure.Core.ClientOptions`
`27`	`27`	`{`
`28`		`- public ConversationAnalysisClientOptions(Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion version = Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_preview) { }`
	`28`	`+ public ConversationAnalysisClientOptions(Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion version = Azure.AI.Language.Conversations.ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_Preview) { }`
`29`	`29`	`public enum ServiceVersion`
`30`	`30`	`{`
`31`		`- V2021_07_15_preview = 1,`
	`31`	`+ V2021_07_15_Preview = 1,`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace Azure.AI.Language.Conversations`
`11`	`11`	`/// </summary>`
`12`	`12`	`public partial class ConversationAnalysisClientOptions : ClientOptions`
`13`	`13`	`{`
`14`		`- private const ServiceVersion LatestVersion = ServiceVersion.V2021_07_15_preview;`
	`14`	`+ private const ServiceVersion LatestVersion = ServiceVersion.V2021_07_15_Preview;`
`15`	`15`
`16`	`16`	`/// <summary>`
`17`	`17`	`/// The version of the service to use.`
`@@ -22,7 +22,7 @@ public enum ServiceVersion`
`22`	`22`	`/// <summary>`
`23`	`23`	`/// Service version "2021-07-15-preview".`
`24`	`24`	`/// </summary>`
`25`		`- V2021_07_15_preview = 1,`
	`25`	`+ V2021_07_15_Preview = 1,`
`26`	`26`	`#pragma warning restore CA1707 // Identifiers should not contain underscores`
`27`	`27`	`}`
`28`	`28`
`@@ -35,7 +35,7 @@ public ConversationAnalysisClientOptions(ServiceVersion version = LatestVersion)`
`35`	`35`	`{`
`36`	`36`	`Version = version switch`
`37`	`37`	`{`
`38`		`- ServiceVersion.V2021_07_15_preview => "2021-07-15-preview",`
	`38`	`+ ServiceVersion.V2021_07_15_Preview => "2021-07-15-preview",`
`39`	`39`	`_ => throw new NotSupportedException()`
`40`	`40`	`};`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace Azure.AI.Language.Conversations.Tests`
`9`	`9`	`/// Base class for live client tests using different service versions.`
`10`	`10`	`/// </summary>`
`11`	`11`	`/// <typeparam name="TClient">The type of client being tested.</typeparam>`
`12`		`- [ClientTestFixture(ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_preview)]`
	`12`	`+ [ClientTestFixture(ConversationAnalysisClientOptions.ServiceVersion.V2021_07_15_Preview)]`
`13`	`13`	`public abstract class ConversationAnalysisTestBase<TClient> : RecordedTestBase<ConversationAnalysisTestEnvironment> where TClient : class`
`14`	`14`	`{`
`15`	`15`	`protected ConversationAnalysisTestBase(bool isAsync, ConversationAnalysisClientOptions.ServiceVersion serviceVersion, RecordedTestMode? mode)`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ public enum ServiceVersion`
`22`	`22`	`/// <summary>`
`23`	`23`	`/// Service version "2021-05-01-preview".`
`24`	`24`	`/// </summary>`
	`25`	`+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.`
`25`	`26`	`V2021_05_01_preview = 1,`
	`27`	`+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.`
`26`	`28`	`#pragma warning restore CA1707 // Identifiers should not contain underscores`
`27`	`29`	`}`
`28`	`30`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@ public enum ServiceVersion`
`44`	`44`	`/// <summary>`
`45`	`45`	`/// The V2021_03_31_preview1 of the identity service.`
`46`	`46`	`/// </summary>`
	`47`	`+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.`
`47`	`48`	`V2021_03_31_preview1 = 2,`
	`49`	`+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.`
`48`	`50`	`#pragma warning restore CA1707 // Identifiers should not contain underscores`
`49`	`51`	`}`
`50`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,9 @@ public enum ServiceVersion`
`39`	`39`	`/// <summary>`
`40`	`40`	`/// The V2021_06_21_preview of the networking service.`
`41`	`41`	`/// </summary>`
	`42`	`+#pragma warning disable AZC0016 // Invalid ServiceVersion member name.`
`42`	`43`	`V2021_06_21_preview = 1,`
	`44`	`+#pragma warning restore AZC0016 // Invalid ServiceVersion member name.`
`43`	`45`	`#pragma warning restore CA1707 // Identifiers should not contain underscores`
`44`	`46`	`}`
`45`	`47`	`}`