[TA] Change error in analyze (Azure#19197)

Fixes: Azure#18714

Author: maririos

sdk/textanalytics/Azure.AI.TextAnalytics/CHANGELOG.md

@@ -19,6 +19,7 @@
 - For `PiiEntity.Category` the type of the property is now `PiiEntityCategory` instead of `EntityCategory`.
 - Removed `RelatedEntities`.
 - `RecognizePiiEntitiesOptions.Domain` is now a nullable type.
+- In `StartAnalyzeBatchActions` when all actions return status `failed` the SDK will no longer throw an exception. The request will succeed and the errors will be located at the specific action level. 
 
 ### Fixes
 - `RecognizePiiEntities` and `TextAnalyticsActions.RecognizePiiEntitiesOptions` were always passing `PiiEntityDomainType.PHI`. Now, it is only passed when requested by the user [19086](https://github.com/Azure/azure-sdk-for-net/issues/19086).

sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeBatchActionsOperation.cs

@@ -105,11 +105,6 @@ public class AnalyzeBatchActionsOperation : PageableOperation<AnalyzeBatchAction
         /// </summary>
         public override bool HasCompleted => _hasCompleted;
 
-        /// <summary>
-        /// If the operation has an exception, this property saves its information.
-        /// </summary>
-        private RequestFailedException _requestFailedException;
-
         /// <summary>
         /// The last HTTP response received from the server. <c>null</c> until the first response is received.
         /// </summary>
@@ -263,20 +258,17 @@ private async ValueTask<Response> UpdateStatusAsync(bool async, CancellationToke
                     _totalActions = update.Value.Tasks.Total;
 
                     // TODO - Remove PartiallySucceeded once service deploys this to WestUS2
-                    if (update.Value.Status == TextAnalyticsOperationStatus.Succeeded || update.Value.Status == TextAnalyticsOperationStatus.PartiallySucceeded || update.Value.Status == TextAnalyticsOperationStatus.PartiallyCompleted)
+                    if (update.Value.Status == TextAnalyticsOperationStatus.Succeeded ||
+                        update.Value.Status == TextAnalyticsOperationStatus.PartiallySucceeded ||
+                        update.Value.Status == TextAnalyticsOperationStatus.PartiallyCompleted ||
+                        update.Value.Status == TextAnalyticsOperationStatus.Failed)
                     {
                         // we need to first assign a value and then mark the operation as completed to avoid race conditions
                         var nextLink = update.Value.NextLink;
                         var value = Transforms.ConvertToAnalyzeOperationResult(update.Value, _idToIndexMap);
                         _firstPage = Page.FromValues(new List<AnalyzeBatchActionsResult>() { value }, nextLink, _response);
                         _hasCompleted = true;
                     }
-                    else if (update.Value.Status == TextAnalyticsOperationStatus.Failed)
-                    {
-                        _requestFailedException = await ClientCommon.CreateExceptionForFailedOperationAsync(async, _diagnostics, _response, update.Value.Errors).ConfigureAwait(false);
-                        _hasCompleted = true;
-                        throw _requestFailedException;
-                    }
                 }
                 catch (Exception e)
                 {
@@ -350,8 +342,6 @@ private void ValidateOperationStatus()
         {
             if (!HasCompleted)
                 throw new InvalidOperationException("The operation has not completed yet.");
-            if (!HasValue)
-                throw _requestFailedException;
         }
     }
 }

sdk/textanalytics/Azure.AI.TextAnalytics/tests/AnalyzeOperationTests.cs

@@ -449,6 +449,41 @@ public async Task AnalyzeOperationBatchWithErrorTest()
             Assert.AreEqual(TextAnalyticsErrorCode.InvalidRequest, linkedEntitiesActions[1].Error.ErrorCode.ToString());
         }
 
+        [Test]
+        public async Task AnalyzeOperationBatchWithAllErrorsTest()
+        {
+            TextAnalyticsClient client = GetClient();
+
+            var documents = new List<string>
+            {
+                "Subject is taking 100mg of ibuprofen twice daily",
+                "",
+            };
+            TextAnalyticsActions batchActions = new TextAnalyticsActions()
+            {
+                ExtractKeyPhrasesOptions = new List<ExtractKeyPhrasesOptions>()
+                {
+                    new ExtractKeyPhrasesOptions()
+                    {
+                        ModelVersion = "InvalidVersion"
+                    }
+                }
+            };
+
+            AnalyzeBatchActionsOperation operation = await client.StartAnalyzeBatchActionsAsync(documents, batchActions, "en");
+            await operation.WaitForCompletionAsync(PollingInterval);
+
+            //Take the first page
+            AnalyzeBatchActionsResult resultCollection = operation.Value.ToEnumerableAsync().Result.FirstOrDefault();
+
+            //Key phrases
+            var keyPhrasesActions = resultCollection.ExtractKeyPhrasesActionsResults.ToList();
+
+            Assert.AreEqual(1, keyPhrasesActions.Count);
+            Assert.IsTrue(keyPhrasesActions[0].HasError);
+            Assert.AreEqual(TextAnalyticsErrorCode.InvalidRequest, keyPhrasesActions[0].Error.ErrorCode.ToString());
+        }
+
         [Test]
         public async Task AnalyzeOperationBatchWithPHIDomain()
         {