Use UnauthorizedAccessException (Azure#16846)

Author: JoshLove-msft

sdk/servicebus/Azure.Messaging.ServiceBus/api/Azure.Messaging.ServiceBus.netstandard2.0.cs

@@ -154,8 +154,7 @@ public enum ServiceBusFailureReason
         ServiceCommunicationProblem = 9,
         SessionCannotBeLocked = 10,
         SessionLockLost = 11,
-        Unauthorized = 12,
-        MessagingEntityAlreadyExists = 13,
+        MessagingEntityAlreadyExists = 12,
     }
     public partial class ServiceBusMessage
     {

sdk/servicebus/Azure.Messaging.ServiceBus/src/Administration/HttpRequestAndResponse.cs

@@ -53,10 +53,9 @@ internal async Task ThrowIfRequestFailedAsync(Request request, Response response
             RequestFailedException ex = await _diagnostics.CreateRequestFailedExceptionAsync(response).ConfigureAwait(false);
             if (response.Status == (int)HttpStatusCode.Unauthorized)
             {
-                throw new ServiceBusException(
+                throw new UnauthorizedAccessException(
                     ex.Message,
-                    ServiceBusFailureReason.Unauthorized,
-                    innerException: ex);
+                    inner: ex);
             }
 
             if (response.Status == (int)HttpStatusCode.NotFound)

sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpExceptionHelper.cs

@@ -121,7 +121,7 @@ public static Exception ToMessagingContractException(string condition, string me
             if (string.Equals(condition, AmqpErrorCode.UnauthorizedAccess.Value, StringComparison.InvariantCultureIgnoreCase) ||
                 string.Equals(condition, AmqpClientConstants.AuthorizationFailedError.Value, StringComparison.InvariantCultureIgnoreCase))
             {
-                return new ServiceBusException(message, ServiceBusFailureReason.Unauthorized);
+                return new UnauthorizedAccessException(message);
             }
 
             if (string.Equals(condition, AmqpClientConstants.ServerBusyError.Value, StringComparison.InvariantCultureIgnoreCase))

sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusFailureReason.cs

@@ -68,11 +68,6 @@ public enum ServiceBusFailureReason
         /// </summary>
         SessionLockLost,
 
-        /// <summary>
-        /// The user doesn't have access to the entity.
-        /// </summary>
-        Unauthorized,
-
         /// <summary>
         /// An entity with the same name exists under the same namespace.
         /// </summary>

sdk/servicebus/Azure.Messaging.ServiceBus/tests/Administration/RequestResponseTests.cs

@@ -31,12 +31,13 @@ public async Task ThrowsUnauthorizedOn401()
                 MockResponse response = new MockResponse((int)HttpStatusCode.Unauthorized);
                 await _requestResponse.ThrowIfRequestFailedAsync(new MockRequest(), response);
             }
-            catch (ServiceBusException ex)
+            catch (UnauthorizedAccessException ex)
             {
-                Assert.AreEqual(ServiceBusFailureReason.Unauthorized, ex.Reason);
                 var inner = (RequestFailedException)ex.InnerException;
                 Assert.AreEqual((int)HttpStatusCode.Unauthorized, inner.Status);
+                return;
             }
+            Assert.Fail($"Expected exception not thrown");
         }
 
         [Test]