GA release for NetworkTraversal (Azure#26758)

* GA new version of swagger autorest code and fixing serialization/deserialization issue

* Allow expires on to be nullable

* Fix code checks

* Fix version string in csproj file

* Add testing for Serialization/deserialization

* Add new recordings

* Remove nullable of ExpiresOn

* Update PR

* Update date

Author: AriZavala2

sdk/communication/Azure.Communication.NetworkTraversal/CHANGELOG.md

@@ -1,11 +1,14 @@
 # Release History
 
-## 1.0.0-beta.4 (Unreleased)
+## 1.0.0 (2022-02-08)
 
 ### Features Added
 
 ### Breaking Changes
 
+- Removing GetRelayConfigurationOptions to call GetRelayConfiguration and GetRelayConfigurationAsync passing 
+  RouteType and CommunicationUserIdentifier explicitly.
+
 ### Bugs Fixed
 
 ### Other Changes

sdk/communication/Azure.Communication.NetworkTraversal/README.md

@@ -10,7 +10,7 @@ Azure Communication Network Traversal enables high bandwidth, low latency connec
 Install the Azure Communication Network Traversal client library for .NET with [NuGet][nuget]:
 
 ```dotnetcli
-dotnet add package Azure.Communication.NetworkTraversal --version 1.0.0-beta.3
+dotnet add package Azure.Communication.NetworkTraversal --version 1.0.0
 ```
 
 ### Prerequisites
@@ -70,7 +70,7 @@ We guarantee that all client instance methods are thread-safe and independent of
 ```C# Snippet:GetRelayConfigurationAsync
 Response<CommunicationRelayConfiguration> relayConfiguration = await client.GetRelayConfigurationAsync();
 DateTimeOffset turnTokenExpiresOn = relayConfiguration.Value.ExpiresOn;
-IReadOnlyList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
+IList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
 Console.WriteLine($"Expires On: {turnTokenExpiresOn}");
 foreach (CommunicationIceServer iceServer in iceServers)
 {
@@ -87,9 +87,9 @@ foreach (CommunicationIceServer iceServer in iceServers)
 ## Getting a Relay Configuration for a user with a specified routeType
 
 ```C# Snippet:GetRelayConfigurationAsyncWithNearestRouteType
-Response<CommunicationRelayConfiguration> relayConfiguration = await client.GetRelayConfigurationAsync(new GetRelayConfigurationOptions { CommunicationUser = user, RouteType = RouteType.Nearest });
+Response<CommunicationRelayConfiguration> relayConfiguration = await client.GetRelayConfigurationAsync(user,RouteType.Nearest);
 DateTimeOffset turnTokenExpiresOn = relayConfiguration.Value.ExpiresOn;
-IReadOnlyList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
+IList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
 Console.WriteLine($"Expires On: {turnTokenExpiresOn}");
 foreach (CommunicationIceServer iceServer in iceServers)
 {

sdk/communication/Azure.Communication.NetworkTraversal/api/Azure.Communication.NetworkTraversal.netstandard2.0.cs

@@ -2,11 +2,11 @@ namespace Azure.Communication.NetworkTraversal
 {
     public partial class CommunicationIceServer
     {
-        internal CommunicationIceServer() { }
-        public string Credential { get { throw null; } }
-        public Azure.Communication.NetworkTraversal.RouteType RouteType { get { throw null; } }
-        public System.Collections.Generic.IReadOnlyList<string> Urls { get { throw null; } }
-        public string Username { get { throw null; } }
+        public CommunicationIceServer(System.Collections.Generic.IEnumerable<string> urls, string username, string credential, Azure.Communication.NetworkTraversal.RouteType routeType) { }
+        public string Credential { get { throw null; } set { } }
+        public Azure.Communication.NetworkTraversal.RouteType RouteType { get { throw null; } set { } }
+        public System.Collections.Generic.IList<string> Urls { get { throw null; } }
+        public string Username { get { throw null; } set { } }
     }
     public partial class CommunicationRelayClient
     {
@@ -15,29 +15,22 @@ public CommunicationRelayClient(string connectionString) { }
         public CommunicationRelayClient(string connectionString, Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions options) { }
         public CommunicationRelayClient(System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions options = null) { }
         public CommunicationRelayClient(System.Uri endpoint, Azure.Core.TokenCredential tokenCredential, Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions options = null) { }
-        public virtual Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration> GetRelayConfiguration(Azure.Communication.NetworkTraversal.Models.GetRelayConfigurationOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration> GetRelayConfiguration(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration>> GetRelayConfigurationAsync(Azure.Communication.NetworkTraversal.Models.GetRelayConfigurationOptions options, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration>> GetRelayConfigurationAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration> GetRelayConfiguration(Azure.Communication.CommunicationUserIdentifier communicationUser = null, Azure.Communication.NetworkTraversal.RouteType? routeType = default(Azure.Communication.NetworkTraversal.RouteType?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration>> GetRelayConfigurationAsync(Azure.Communication.CommunicationUserIdentifier communicationUser = null, Azure.Communication.NetworkTraversal.RouteType? routeType = default(Azure.Communication.NetworkTraversal.RouteType?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
     }
     public partial class CommunicationRelayClientOptions : Azure.Core.ClientOptions
     {
-        public CommunicationRelayClientOptions(Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions.ServiceVersion version = Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions.ServiceVersion.V2021_10_08_preview) { }
+        public CommunicationRelayClientOptions(Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions.ServiceVersion version = Azure.Communication.NetworkTraversal.CommunicationRelayClientOptions.ServiceVersion.V2022_02_01) { }
         public enum ServiceVersion
         {
-            V2021_10_08_preview = 1,
+            V2022_02_01 = 1,
         }
     }
     public partial class CommunicationRelayConfiguration
     {
-        internal CommunicationRelayConfiguration() { }
-        public System.DateTimeOffset ExpiresOn { get { throw null; } }
-        public System.Collections.Generic.IReadOnlyList<Azure.Communication.NetworkTraversal.CommunicationIceServer> IceServers { get { throw null; } }
-    }
-    public static partial class NetworkTraversalModelFactory
-    {
-        public static Azure.Communication.NetworkTraversal.CommunicationIceServer CommunicationIceServer(System.Collections.Generic.IEnumerable<string> urls = null, string username = null, string credential = null, Azure.Communication.NetworkTraversal.RouteType routeType = default(Azure.Communication.NetworkTraversal.RouteType)) { throw null; }
-        public static Azure.Communication.NetworkTraversal.CommunicationRelayConfiguration CommunicationRelayConfiguration(System.DateTimeOffset expiresOn = default(System.DateTimeOffset), System.Collections.Generic.IEnumerable<Azure.Communication.NetworkTraversal.CommunicationIceServer> iceServers = null) { throw null; }
+        public CommunicationRelayConfiguration(System.DateTimeOffset expiresOn, System.Collections.Generic.IEnumerable<Azure.Communication.NetworkTraversal.CommunicationIceServer> iceServers) { }
+        public System.DateTimeOffset ExpiresOn { get { throw null; } set { } }
+        public System.Collections.Generic.IList<Azure.Communication.NetworkTraversal.CommunicationIceServer> IceServers { get { throw null; } }
     }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct RouteType : System.IEquatable<Azure.Communication.NetworkTraversal.RouteType>
@@ -58,12 +51,3 @@ public static partial class NetworkTraversalModelFactory
         public override string ToString() { throw null; }
     }
 }
-namespace Azure.Communication.NetworkTraversal.Models
-{
-    public partial class GetRelayConfigurationOptions
-    {
-        public GetRelayConfigurationOptions() { }
-        public Azure.Communication.CommunicationUserIdentifier CommunicationUser { get { throw null; } set { } }
-        public Azure.Communication.NetworkTraversal.RouteType? RouteType { get { throw null; } set { } }
-    }
-}

sdk/communication/Azure.Communication.NetworkTraversal/samples/Sample1_CommunicationRelayClient.md

@@ -42,7 +42,7 @@ Every relay configuration has an expiry date and time stamped on it, indicating
 ```C# Snippet:GetRelayConfiguration
 Response<CommunicationRelayConfiguration> relayConfiguration = client.GetRelayConfiguration();
 DateTimeOffset turnTokenExpiresOn = relayConfiguration.Value.ExpiresOn;
-IReadOnlyList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
+IList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
 Console.WriteLine($"Expires On: {turnTokenExpiresOn}");
 foreach (CommunicationIceServer iceServer in iceServers)
 {

sdk/communication/Azure.Communication.NetworkTraversal/samples/Sample1_CommunicationRelayClientAsync.md

@@ -42,7 +42,7 @@ Every relay configuration has an expiry date and time stamped on it, indicating
 ```C# Snippet:GetRelayConfigurationAsync
 Response<CommunicationRelayConfiguration> relayConfiguration = await client.GetRelayConfigurationAsync();
 DateTimeOffset turnTokenExpiresOn = relayConfiguration.Value.ExpiresOn;
-IReadOnlyList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
+IList<CommunicationIceServer> iceServers = relayConfiguration.Value.IceServers;
 Console.WriteLine($"Expires On: {turnTokenExpiresOn}");
 foreach (CommunicationIceServer iceServer in iceServers)
 {

sdk/communication/Azure.Communication.NetworkTraversal/src/Azure.Communication.NetworkTraversal.csproj

@@ -5,7 +5,7 @@
       For this release, see notes - https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/communication/Azure.Communication.NetworkTraversal/README.md and https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/communication/Azure.Communication.NetworkTraversal/CHANGELOG.md.
     </Description>
     <AssemblyTitle>Azure Communication Network Traversal Service</AssemblyTitle>
-    <Version>1.0.0-beta.4</Version>
+    <Version>1.0.0</Version>
     <PackageTags>Microsoft Azure Communication Network Traversal Service;Microsoft;Azure;Azure Communication Service;Azure Communication Network Traversal Service;Network Traversal;Communication;$(PackageCommonTags)</PackageTags>
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
   </PropertyGroup>

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationIceServer.cs

@@ -0,0 +1,19 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Azure.Core;
+
+namespace Azure.Communication.NetworkTraversal
+{
+    /// <summary>
+    /// The user should be able to serialize or deserialize CommunicationIceServer
+    /// for better experience.
+    /// </summary>
+    [CodeGenModel(Usage = new[] { "input", "converter" })]
+    public partial class CommunicationIceServer
+    {
+    }
+}

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClient.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Threading;
 using System.Threading.Tasks;
-using Azure.Communication.NetworkTraversal.Models;
 using Azure.Communication.Pipeline;
 using Azure.Core;
 using Azure.Core.Pipeline;
@@ -92,34 +91,17 @@ protected CommunicationRelayClient()
         }
 
         /// <summary>Gets a Relay Configuration for a <see cref="CommunicationUserIdentifier"/>.</summary>
-        /// <param name="options"> The <see cref="GetRelayConfigurationOptions"/> for the request. </param>
+        /// <param name="communicationUser">The <see cref="CommunicationUserIdentifier"/> for whom to issue a token.</param>
+        /// <param name="routeType"> The specified <see cref="RouteType"/> for the relay request </param>
         /// <param name="cancellationToken">The cancellation token to use.</param>
         /// <exception cref="RequestFailedException">The server returned an error.</exception>
-        public virtual Response<CommunicationRelayConfiguration> GetRelayConfiguration(GetRelayConfigurationOptions options, CancellationToken cancellationToken = default)
+        public virtual Response<CommunicationRelayConfiguration> GetRelayConfiguration(CommunicationUserIdentifier communicationUser = null, RouteType? routeType = null, CancellationToken cancellationToken = default)
         {
             using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CommunicationRelayClient)}.{nameof(GetRelayConfiguration)}");
             scope.Start();
             try
             {
-                return RestClient.IssueRelayConfiguration(options.CommunicationUser?.Id, options?.RouteType, cancellationToken);
-            }
-            catch (Exception ex)
-            {
-                scope.Failed(ex);
-                throw;
-            }
-        }
-
-        /// <summary>Gets a Relay Configuration for a <see cref="CommunicationUserIdentifier"/>.</summary>
-        /// <param name="cancellationToken">The cancellation token to use.</param>
-        /// <exception cref="RequestFailedException">The server returned an error.</exception>
-        public virtual Response<CommunicationRelayConfiguration> GetRelayConfiguration(CancellationToken cancellationToken = default)
-        {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CommunicationRelayClient)}.{nameof(GetRelayConfiguration)}");
-            scope.Start();
-            try
-            {
-                return RestClient.IssueRelayConfiguration(cancellationToken: cancellationToken);
+                return RestClient.IssueRelayConfiguration(communicationUser?.Id, routeType, cancellationToken);
             }
             catch (Exception ex)
             {
@@ -129,32 +111,16 @@ public virtual Response<CommunicationRelayConfiguration> GetRelayConfiguration(C
         }
 
         /// <summary>Asynchronously gets a Relay Configuration for a <see cref="CommunicationUserIdentifier"/>.</summary>
-        /// <param name="options"> The <see cref="GetRelayConfigurationOptions"/> for the request. </param>
-        /// <param name="cancellationToken"> The cancellation token to use. </param>
-        public virtual async Task<Response<CommunicationRelayConfiguration>> GetRelayConfigurationAsync(GetRelayConfigurationOptions options, CancellationToken cancellationToken = default)
-        {
-            using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CommunicationRelayClient)}.{nameof(GetRelayConfiguration)}");
-            scope.Start();
-            try
-            {
-                return await RestClient.IssueRelayConfigurationAsync(options?.CommunicationUser?.Id, options?.RouteType, cancellationToken).ConfigureAwait(false);
-            }
-            catch (Exception ex)
-            {
-                scope.Failed(ex);
-                throw;
-            }
-        }
-
-        /// <summary>Asynchronously gets a Relay Configuration for a <see cref="CommunicationUserIdentifier"/>.</summary>
-        /// <param name="cancellationToken"> The cancellation token to use. </param>
-        public virtual async Task<Response<CommunicationRelayConfiguration>> GetRelayConfigurationAsync(CancellationToken cancellationToken = default)
+        /// <param name="communicationUser">The <see cref="CommunicationUserIdentifier"/> for whom to issue a token.</param>
+        /// <param name="routeType"> The specified <see cref="RouteType"/> for the relay request </param>
+        /// <param name="cancellationToken">The cancellation token to use.</param>
+        public virtual async Task<Response<CommunicationRelayConfiguration>> GetRelayConfigurationAsync(CommunicationUserIdentifier communicationUser = null, RouteType? routeType = null, CancellationToken cancellationToken = default)
         {
             using DiagnosticScope scope = _clientDiagnostics.CreateScope($"{nameof(CommunicationRelayClient)}.{nameof(GetRelayConfiguration)}");
             scope.Start();
             try
             {
-                return await RestClient.IssueRelayConfigurationAsync(cancellationToken: cancellationToken).ConfigureAwait(false);
+                return await RestClient.IssueRelayConfigurationAsync(communicationUser?.Id, routeType, cancellationToken).ConfigureAwait(false);
             }
             catch (Exception ex)
             {

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClientOptions.cs

@@ -14,7 +14,7 @@ public class CommunicationRelayClientOptions : ClientOptions
         /// <summary>
         /// The latest version of the networking service.
         /// </summary>
-        internal const ServiceVersion LatestVersion = ServiceVersion.V2021_10_08_preview;
+        internal const ServiceVersion LatestVersion = ServiceVersion.V2022_02_01;
 
         internal string ApiVersion { get; }
 
@@ -25,7 +25,7 @@ public CommunicationRelayClientOptions(ServiceVersion version = LatestVersion)
         {
             ApiVersion = version switch
             {
-                ServiceVersion.V2021_10_08_preview  => "2021-10-08-preview",
+                ServiceVersion.V2022_02_01 => "2022-02-01",
                 _ => throw new ArgumentOutOfRangeException(nameof(version)),
             };
         }
@@ -38,9 +38,9 @@ public enum ServiceVersion
 #pragma warning disable CA1707 // Identifiers should not contain underscores
 #pragma warning disable AZC0016 // Invalid ServiceVersion member name.
             /// <summary>
-            /// The V2021_10_08_preview of the networking service.
+            /// The V2022_02_01 GA version of the networking service.
             /// </summary>
-            V2021_10_08_preview = 1,
+            V2022_02_01 = 1,
 #pragma warning restore AZC0016 // Invalid ServiceVersion member name.
 #pragma warning restore CA1707 // Identifiers should not contain underscores
         }

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayConfiguration.cs

@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Azure.Core;
+
+namespace Azure.Communication.NetworkTraversal
+{
+    [CodeGenModel(Usage = new[] { "input", "converter" })]
+    public partial class CommunicationRelayConfiguration
+    {
+    }
+}