[synapse] Correct tests to work on TestResources instances or disable if require uploads (Azure#18833)

Author: chamons

sdk/synapse/Azure.Analytics.Synapse.AccessControl/tests/AccessControlClientLiveTests.cs

@@ -34,12 +34,12 @@ private DisposableClientRole (RoleAssignmentsClient assignmentsClient, RoleDefin
                 Assignment = assignment;
             }
 
-            public static async ValueTask<DisposableClientRole> Create (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient) =>
-                new DisposableClientRole (assignmentsClient, definitionsClient, await CreateResource (assignmentsClient, definitionsClient));
+            public static async ValueTask<DisposableClientRole> Create (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient, SynapseTestEnvironment testEnvironment) =>
+                new DisposableClientRole (assignmentsClient, definitionsClient, await CreateResource (assignmentsClient, definitionsClient, testEnvironment));
 
-            public static async ValueTask<RoleAssignmentDetails> CreateResource (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient)
+            public static async ValueTask<RoleAssignmentDetails> CreateResource (RoleAssignmentsClient assignmentsClient, RoleDefinitionsClient definitionsClient, SynapseTestEnvironment testEnvironment)
             {
-                string scope = "workspaces/workspacechhamosynapse";
+                string scope = "workspaces/" + testEnvironment.WorkspaceName;
 
                 Guid? roleID = (await definitionsClient.ListRoleDefinitionsAsync()).Value.First (x => x.Name == "Synapse Administrator").Id;
                 Guid principalId = Guid.NewGuid();
@@ -81,7 +81,7 @@ public async Task CreateRoleAssignment()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, TestEnvironment);
 
             Assert.NotNull(role.Assignment.Id);
             Assert.NotNull(role.Assignment.RoleDefinitionId);
@@ -94,7 +94,7 @@ public async Task GetRoleAssignment()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, TestEnvironment);
 
             RoleAssignmentDetails roleAssignment = await assignmentsClient.GetRoleAssignmentByIdAsync(role.Assignment.Id);
 
@@ -108,7 +108,7 @@ public async Task ListRoleAssignments()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient);
+            await using DisposableClientRole role = await DisposableClientRole.Create (assignmentsClient, definitionsClient, TestEnvironment);
 
             Response<IReadOnlyList<SynapseRoleDefinition>> roleAssignments = await definitionsClient.ListRoleDefinitionsAsync();
             foreach (SynapseRoleDefinition expected in roleAssignments.Value)
@@ -126,7 +126,7 @@ public async Task DeleteRoleAssignments()
             RoleAssignmentsClient assignmentsClient = CreateAssignmentClient();
             RoleDefinitionsClient definitionsClient = CreateDefinitionsClient();
 
-            RoleAssignmentDetails assignment = await DisposableClientRole.CreateResource (assignmentsClient, definitionsClient);
+            RoleAssignmentDetails assignment = await DisposableClientRole.CreateResource (assignmentsClient, definitionsClient, TestEnvironment);
 
             Response response = await assignmentsClient.DeleteRoleAssignmentByIdAsync (assignment.Id);
             response.AssertSuccess();

sdk/synapse/Azure.Analytics.Synapse.AccessControl/tests/samples/Sample1_HelloWorld.cs

@@ -37,7 +37,7 @@ public void AddAndRemoveRoleAssignmentSync()
             Guid roleId = role.Id.Value;
 
             string assignedScope = "workspaces/<my-workspace-name>";
-            /*@@*/assignedScope = "workspaces/workspacechhamosynapse";
+            /*@@*/assignedScope = "workspaces/" + TestEnvironment.WorkspaceName;
 
             // Replace the string below with the ID you'd like to assign the role.
             Guid principalId = /*<my-principal-id>"*/ Guid.NewGuid();

sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/SparkJobDefinitionClientLiveTests.cs

@@ -19,7 +19,7 @@ namespace Azure.Analytics.Synapse.Artifacts.Tests
     /// These tests have a dependency on live Azure services and may incur costs for the associated
     /// Azure subscription.
     /// </remarks>
-    // [Ignore("This test case cannot be automated due to the inability to configure infrastructure to test against.")]
+    [LiveOnly] // Requires uploaded application on associated storage (wordcount.zip sample)
     public class SparkJobDefinitionClientLiveTests : RecordedTestBase<SynapseTestEnvironment>
     {
         internal class DisposableSparkJobDefinition : IAsyncDisposable

sdk/synapse/Azure.Analytics.Synapse.Monitoring/tests/samples/Sample1_PipelineMonitoring.cs

@@ -19,6 +19,7 @@ namespace Azure.Analytics.Synapse.Monitoring.Samples
     /// </summary>
     public partial class Sample1_PipelineMonitoring : SamplesBase<SynapseTestEnvironment>
     {
+        [LiveOnly] // https://github.com/Azure/azure-sdk-for-net/issues/18832 - Fails on nightly lane due to unreproducable NRE
         [Test]
         public void MonitorPipelineRuns()
         {