Enable log forwarding from Azure SDK. (Azure#20632)

* Enable log forwarding from Azure SDK.

* Update comment

Author: JoshLove-msft

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Config/ServiceBusClientFactory.cs

@@ -22,11 +22,13 @@ internal class ServiceBusClientFactory
         public ServiceBusClientFactory(
             IConfiguration configuration,
             AzureComponentFactory componentFactory,
-            MessagingProvider messagingProvider)
+            MessagingProvider messagingProvider,
+            AzureEventSourceLogForwarder logForwarder)
         {
             _configuration = configuration;
             _componentFactory = componentFactory;
             _messagingProvider = messagingProvider;
+            logForwarder.Start();
         }
 
         internal ServiceBusClient CreateClientFromSetting(string connection)

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Bindings/ServiceBusAttributeBindingProviderTests.cs

@@ -12,6 +12,7 @@
 using Microsoft.Azure.WebJobs.ServiceBus.Bindings;
 using Microsoft.Extensions.Azure;
 using Microsoft.Extensions.Configuration;
+using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Options;
 using Moq;
 using NUnit.Framework;
@@ -30,7 +31,7 @@ public ServiceBusAttributeBindingProviderTests()
             Mock<INameResolver> mockResolver = new Mock<INameResolver>(MockBehavior.Strict);
             ServiceBusOptions config = new ServiceBusOptions();
             var messagingProvider = new MessagingProvider(new OptionsWrapper<ServiceBusOptions>(config));
-            var factory = new ServiceBusClientFactory(_configuration, new Mock<AzureComponentFactory>().Object, messagingProvider);
+            var factory = new ServiceBusClientFactory(_configuration, new Mock<AzureComponentFactory>().Object, messagingProvider, new AzureEventSourceLogForwarder(new NullLoggerFactory()));
             _provider = new ServiceBusAttributeBindingProvider(mockResolver.Object, messagingProvider, factory);
         }
 

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Bindings/ServiceBusTriggerAttributeBindingProviderTests.cs

@@ -34,7 +34,7 @@ public ServiceBusTriggerAttributeBindingProviderTests()
 
             Mock<IConverterManager> convertManager = new Mock<IConverterManager>(MockBehavior.Default);
             var provider = new MessagingProvider(new OptionsWrapper<ServiceBusOptions>(options));
-            var factory = new ServiceBusClientFactory(configuration, new Mock<AzureComponentFactory>().Object, provider);
+            var factory = new ServiceBusClientFactory(configuration, new Mock<AzureComponentFactory>().Object, provider, new AzureEventSourceLogForwarder(new NullLoggerFactory()));
             _provider = new ServiceBusTriggerAttributeBindingProvider(mockResolver.Object, options, provider, NullLoggerFactory.Instance, convertManager.Object, factory);
         }
 

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Config/ServiceBusClientFactoryTests.cs

@@ -13,6 +13,7 @@
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
+using Microsoft.Extensions.Logging.Abstractions;
 
 namespace Microsoft.Azure.WebJobs.ServiceBus.Tests.Config
 {
@@ -34,7 +35,7 @@ public void ReadDefaultConnectionString(string defaultConnectionString, string d
                 p => p.CreateClient(expectedValue))
                 .Returns(Mock.Of<ServiceBusClient>());
 
-            var factory = new ServiceBusClientFactory(configuration, Mock.Of<AzureComponentFactory>(), mockProvider.Object);
+            var factory = new ServiceBusClientFactory(configuration, Mock.Of<AzureComponentFactory>(), mockProvider.Object, new AzureEventSourceLogForwarder(new NullLoggerFactory()));
             if (expectedValue == null)
             {
                 Assert.That(

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Listeners/ServiceBusListenerTests.cs

@@ -50,7 +50,7 @@ public ServiceBusListenerTests()
             _mockMessageProcessor = new Mock<MessageProcessor>(MockBehavior.Strict, processor, receiver);
 
             _mockMessagingProvider = new Mock<MessagingProvider>(new OptionsWrapper<ServiceBusOptions>(config));
-            _mockClientFactory = new Mock<ServiceBusClientFactory>(configuration, Mock.Of<AzureComponentFactory>(), _mockMessagingProvider.Object);
+            _mockClientFactory = new Mock<ServiceBusClientFactory>(configuration, Mock.Of<AzureComponentFactory>(), _mockMessagingProvider.Object, new AzureEventSourceLogForwarder(new NullLoggerFactory()));
             _mockMessagingProvider
                 .Setup(p => p.CreateMessageProcessor(It.IsAny<ServiceBusClient>(), _entityPath))
                 .Returns(_mockMessageProcessor.Object);

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/Listeners/ServiceBusScaleMonitorTests.cs

@@ -52,7 +52,7 @@ public void Setup()
 
             _serviceBusOptions = new ServiceBusOptions();
             _mockProvider = new Mock<MessagingProvider>(new OptionsWrapper<ServiceBusOptions>(new ServiceBusOptions()));
-            _mockClientFactory = new Mock<ServiceBusClientFactory>(configuration, Mock.Of<AzureComponentFactory>(), _mockProvider.Object);
+            _mockClientFactory = new Mock<ServiceBusClientFactory>(configuration, Mock.Of<AzureComponentFactory>(), _mockProvider.Object, new AzureEventSourceLogForwarder(new NullLoggerFactory()));
 
             _mockProvider
                 .Setup(p => p.CreateMessageProcessor(_client, _entityPath))

sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/tests/ServiceBusEndToEndTests.cs

@@ -13,8 +13,6 @@
 using Azure.Messaging.ServiceBus.Tests;
 using Microsoft.Azure.WebJobs.Host.TestCommon;
 using Microsoft.Azure.WebJobs.ServiceBus;
-using Microsoft.Extensions.Azure;
-using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
@@ -360,15 +358,15 @@ private async Task ServiceBusEndToEndInternal<T>(IHost host)
             Assert.AreEqual("E2E-SBQueue2SBQueue-SBQueue2SBTopic-topic-2", _resultMessage2);
 
             IEnumerable<LogMessage> logMessages = host.GetTestLoggerProvider()
-                .GetAllLogMessages();
+                // Filter out Azure SDK and custom processor logs for easier validation. Intentionally do the error check after as the
+                // Service Bus SDK currently logs errors when stopping the processor.
+                .GetAllLogMessages().Where(m =>
+                    !m.Category.StartsWith("Azure.") &&
+                    m.Category != CustomMessagingProvider.CustomMessagingCategory);
 
-            Assert.False(logMessages.Where(p => p.Level == LogLevel.Error).Any());
+            Assert.False(logMessages.Any(p => p.Level == LogLevel.Error));
 
-            // filter out anything from the custom processor for easier validation.
-            IEnumerable<LogMessage> consoleOutput = logMessages
-               .Where(m => m.Category != CustomMessagingProvider.CustomMessagingCategory);
-
-            string[] consoleOutputLines = consoleOutput
+            string[] consoleOutputLines = logMessages
                 .Where(p => p.FormattedMessage != null)
                 .SelectMany(p => p.FormattedMessage.Split(Environment.NewLine.ToCharArray(), StringSplitOptions.RemoveEmptyEntries))
                 .OrderBy(p => p)