use common switch (Azure#26003)

m-nash · web-flow · commit 3407ced67ccc · 2021-12-20T09:20:28.000-08:00
diff --git a/common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs b/common/ManagementTestShared/Redesign/ManagementRecordedTestBase.cs
@@ -34,14 +34,14 @@ public abstract class ManagementRecordedTestBase<TEnvironment> : RecordedTestBas
         private ArmClient _cleanupClient;
         private bool _waitForCleanup;
 
-        protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = false) : base(isAsync, useLegacyTransport: useLegacyTransport)
+        protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = true) : base(isAsync, useLegacyTransport: useLegacyTransport)
         {
             SessionEnvironment = new TEnvironment();
             SessionEnvironment.Mode = Mode;
             Initialize();
         }
 
-        protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = false) : base(isAsync, mode, useLegacyTransport)
+        protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = true) : base(isAsync, mode, useLegacyTransport)
         {
             SessionEnvironment = new TEnvironment();
             SessionEnvironment.Mode = Mode;
diff --git a/sdk/compute/Azure.ResourceManager.Compute/tests/ComputeTestBase.cs b/sdk/compute/Azure.ResourceManager.Compute/tests/ComputeTestBase.cs
@@ -15,11 +15,11 @@ public class ComputeTestBase : ManagementRecordedTestBase<ComputeTestEnvironment
         protected Location DefaultLocation => Location.WestUS2;
         protected ArmClient Client { get; private set; }
         protected Subscription DefaultSubscription { get; private set; }
-        public ComputeTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
+        public ComputeTestBase(bool isAsync) : base(isAsync)
         {
         }
 
-        public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
+        public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
         {
         }
 
diff --git a/sdk/deviceupdate/Azure.ResourceManager.DeviceUpdate/tests/DeviceUpdateManagementTestBase.cs b/sdk/deviceupdate/Azure.ResourceManager.DeviceUpdate/tests/DeviceUpdateManagementTestBase.cs
@@ -18,12 +18,12 @@ public class DeviceUpdateManagementTestBase : ManagementRecordedTestBase<DeviceU
         protected ArmClient Client { get; private set; }
 
         protected DeviceUpdateManagementTestBase(bool isAsync, RecordedTestMode mode)
-        : base(isAsync, mode, useLegacyTransport: true)
+        : base(isAsync, mode)
         {
         }
 
         protected DeviceUpdateManagementTestBase(bool isAsync)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
         }
 
diff --git a/sdk/eventhub/Azure.ResourceManager.EventHubs/tests/Helpers/EventHubTestBase.cs b/sdk/eventhub/Azure.ResourceManager.EventHubs/tests/Helpers/EventHubTestBase.cs
@@ -20,12 +20,12 @@ public class EventHubTestBase:ManagementRecordedTestBase<EventHubsManagementTest
         internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";
         protected Subscription DefaultSubscription;
         protected ArmClient Client { get; private set; }
-        protected EventHubTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
+        protected EventHubTestBase(bool isAsync) : base(isAsync)
         {
             Sanitizer = new EventHubRecordedTestSanitizer();
         }
 
-        public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
+        public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
         {
             Sanitizer = new EventHubRecordedTestSanitizer();
         }
diff --git a/sdk/keyvault/Azure.ResourceManager.KeyVault/tests/VaultOperationsTestsBase.cs b/sdk/keyvault/Azure.ResourceManager.KeyVault/tests/VaultOperationsTestsBase.cs
@@ -40,7 +40,7 @@ public abstract class VaultOperationsTestsBase : ManagementRecordedTestBase<KeyV
         public ResourceGroup ResourceGroup { get; set; }
 
         protected VaultOperationsTestsBase(bool isAsync)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
         }
 
diff --git a/sdk/network/Azure.ResourceManager.Network/tests/Helpers/NetworkServiceClientTestBase.cs b/sdk/network/Azure.ResourceManager.Network/tests/Helpers/NetworkServiceClientTestBase.cs
@@ -19,11 +19,11 @@ namespace Azure.ResourceManager.Network.Tests.Helpers
     public class NetworkServiceClientTestBase : ManagementRecordedTestBase<NetworkManagementTestEnvironment>
     {
         private const string dummySSHKey = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+wWK73dCr+jgQOAxNsHAnNNNMEMWOHYEccp6wJm2gotpr9katuF/ZAdou5AaW1C61slRkHRkpRRX9FA9CYBiitZgvCCz+3nWNN7l/Up54Zps/pHWGZLHNJZRYyAB6j5yVLMVHIHriY49d/GZTZVNB8GoJv9Gakwc/fuEZYYl4YDFiGMBP///TzlI4jhiJzjKnEvqPFki5p2ZRJqcbCiF4pJrxUQR/RXqVFQdbRLZgYfJ8xGB878RENq3yQ39d8dVOkq4edbkzwcUmwwwkYVPIoDGsYLaRHnG+To7FvMeyO7xDVQkMKzopTQV8AuKpyvpqu0a9pWOMaiCyDytO7GGN you@me.com";
-        public NetworkServiceClientTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
+        public NetworkServiceClientTestBase(bool isAsync) : base(isAsync)
         {
         }
 
-        public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
+        public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
         {
         }
 
diff --git a/sdk/resourcemanager/Azure.ResourceManager/tests/Scenario/ResourceManagerTestBase.cs b/sdk/resourcemanager/Azure.ResourceManager/tests/Scenario/ResourceManagerTestBase.cs
@@ -19,12 +19,12 @@ public class ResourceManagerTestBase : ManagementRecordedTestBase<ResourceManage
         protected ArmClient Client { get; private set; }
 
         protected ResourceManagerTestBase(bool isAsync, RecordedTestMode mode)
-        : base(isAsync, mode, useLegacyTransport: true)
+        : base(isAsync, mode)
         {
         }
 
         protected ResourceManagerTestBase(bool isAsync)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
         }
 
diff --git a/sdk/resources/Azure.ResourceManager.Resources/tests/ResourcesTestBase.cs b/sdk/resources/Azure.ResourceManager.Resources/tests/ResourcesTestBase.cs
@@ -21,12 +21,12 @@ public class ResourcesTestBase : ManagementRecordedTestBase<ResourcesTestEnviron
         protected ArmClient Client { get; private set; }
 
         protected ResourcesTestBase(bool isAsync, RecordedTestMode mode)
-        : base(isAsync, mode, useLegacyTransport: true)
+        : base(isAsync, mode)
         {
         }
 
         protected ResourcesTestBase(bool isAsync)
-            : base(isAsync, useLegacyTransport: true)
+            : base(isAsync)
         {
         }
 
diff --git a/sdk/servicebus/Azure.ResourceManager.ServiceBus/tests/Helpers/ServiceBusTestBase.cs b/sdk/servicebus/Azure.ResourceManager.ServiceBus/tests/Helpers/ServiceBusTestBase.cs
@@ -18,11 +18,11 @@ public class ServiceBusTestBase: ManagementRecordedTestBase<ServiceBusManagement
         internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";
         protected Subscription DefaultSubscription;
         protected ArmClient Client { get; private set; }
-        protected ServiceBusTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
+        protected ServiceBusTestBase(bool isAsync) : base(isAsync)
         {
             Sanitizer = new ServiceBusRecordedTestSanitizer();
         }
-        protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
+        protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
         {
             Sanitizer = new ServiceBusRecordedTestSanitizer();
         }
diff --git a/sdk/storage/Azure.ResourceManager.Storage/tests/Helpers/StorageTestBase.cs b/sdk/storage/Azure.ResourceManager.Storage/tests/Helpers/StorageTestBase.cs
@@ -31,11 +31,11 @@ public class StorageTestBase : ManagementRecordedTestBase<StorageManagementTestE
         };
         protected ArmClient Client { get; private set; }
         protected Subscription DefaultSubscription { get; private set; }
-        protected StorageTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)
+        protected StorageTestBase(bool isAsync) : base(isAsync)
         {
         }
 
-        public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)
+        public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)
         {
         }
 

Original file line number	Diff line number	Diff line change
`@@ -34,14 +34,14 @@ public abstract class ManagementRecordedTestBase<TEnvironment> : RecordedTestBas`
`34`	`34`	`private ArmClient _cleanupClient;`
`35`	`35`	`private bool _waitForCleanup;`
`36`	`36`
`37`		`- protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = false) : base(isAsync, useLegacyTransport: useLegacyTransport)`
	`37`	`+ protected ManagementRecordedTestBase(bool isAsync, bool useLegacyTransport = true) : base(isAsync, useLegacyTransport: useLegacyTransport)`
`38`	`38`	`{`
`39`	`39`	`SessionEnvironment = new TEnvironment();`
`40`	`40`	`SessionEnvironment.Mode = Mode;`
`41`	`41`	`Initialize();`
`42`	`42`	`}`
`43`	`43`
`44`		`- protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = false) : base(isAsync, mode, useLegacyTransport)`
	`44`	`+ protected ManagementRecordedTestBase(bool isAsync, RecordedTestMode mode, bool useLegacyTransport = true) : base(isAsync, mode, useLegacyTransport)`
`45`	`45`	`{`
`46`	`46`	`SessionEnvironment = new TEnvironment();`
`47`	`47`	`SessionEnvironment.Mode = Mode;`
Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,11 @@ public class ComputeTestBase : ManagementRecordedTestBase<ComputeTestEnvironment`
`15`	`15`	`protected Location DefaultLocation => Location.WestUS2;`
`16`	`16`	`protected ArmClient Client { get; private set; }`
`17`	`17`	`protected Subscription DefaultSubscription { get; private set; }`
`18`		`- public ComputeTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)`
	`18`	`+ public ComputeTestBase(bool isAsync) : base(isAsync)`
`19`	`19`	`{`
`20`	`20`	`}`
`21`	`21`
`22`		`- public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)`
	`22`	`+ public ComputeTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -18,12 +18,12 @@ public class DeviceUpdateManagementTestBase : ManagementRecordedTestBase<DeviceU`
`18`	`18`	`protected ArmClient Client { get; private set; }`
`19`	`19`
`20`	`20`	`protected DeviceUpdateManagementTestBase(bool isAsync, RecordedTestMode mode)`
`21`		`- : base(isAsync, mode, useLegacyTransport: true)`
	`21`	`+ : base(isAsync, mode)`
`22`	`22`	`{`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`protected DeviceUpdateManagementTestBase(bool isAsync)`
`26`		`- : base(isAsync, useLegacyTransport: true)`
	`26`	`+ : base(isAsync)`
`27`	`27`	`{`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -20,12 +20,12 @@ public class EventHubTestBase:ManagementRecordedTestBase<EventHubsManagementTest`
`20`	`20`	`internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";`
`21`	`21`	`protected Subscription DefaultSubscription;`
`22`	`22`	`protected ArmClient Client { get; private set; }`
`23`		`- protected EventHubTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)`
	`23`	`+ protected EventHubTestBase(bool isAsync) : base(isAsync)`
`24`	`24`	`{`
`25`	`25`	`Sanitizer = new EventHubRecordedTestSanitizer();`
`26`	`26`	`}`
`27`	`27`
`28`		`- public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)`
	`28`	`+ public EventHubTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)`
`29`	`29`	`{`
`30`	`30`	`Sanitizer = new EventHubRecordedTestSanitizer();`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public abstract class VaultOperationsTestsBase : ManagementRecordedTestBase<KeyV`
`40`	`40`	`public ResourceGroup ResourceGroup { get; set; }`
`41`	`41`
`42`	`42`	`protected VaultOperationsTestsBase(bool isAsync)`
`43`		`- : base(isAsync, useLegacyTransport: true)`
	`43`	`+ : base(isAsync)`
`44`	`44`	`{`
`45`	`45`	`}`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -19,11 +19,11 @@ namespace Azure.ResourceManager.Network.Tests.Helpers`
`19`	`19`	`public class NetworkServiceClientTestBase : ManagementRecordedTestBase<NetworkManagementTestEnvironment>`
`20`	`20`	`{`
`21`	`21`	`private const string dummySSHKey = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQC+wWK73dCr+jgQOAxNsHAnNNNMEMWOHYEccp6wJm2gotpr9katuF/ZAdou5AaW1C61slRkHRkpRRX9FA9CYBiitZgvCCz+3nWNN7l/Up54Zps/pHWGZLHNJZRYyAB6j5yVLMVHIHriY49d/GZTZVNB8GoJv9Gakwc/fuEZYYl4YDFiGMBP///TzlI4jhiJzjKnEvqPFki5p2ZRJqcbCiF4pJrxUQR/RXqVFQdbRLZgYfJ8xGB878RENq3yQ39d8dVOkq4edbkzwcUmwwwkYVPIoDGsYLaRHnG+To7FvMeyO7xDVQkMKzopTQV8AuKpyvpqu0a9pWOMaiCyDytO7GGN you@me.com";`
`22`		`- public NetworkServiceClientTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)`
	`22`	`+ public NetworkServiceClientTestBase(bool isAsync) : base(isAsync)`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`
`26`		`- public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)`
	`26`	`+ public NetworkServiceClientTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)`
`27`	`27`	`{`
`28`	`28`	`}`
`29`	`29`
Original file line number	Diff line number	Diff line change
`@@ -19,12 +19,12 @@ public class ResourceManagerTestBase : ManagementRecordedTestBase<ResourceManage`
`19`	`19`	`protected ArmClient Client { get; private set; }`
`20`	`20`
`21`	`21`	`protected ResourceManagerTestBase(bool isAsync, RecordedTestMode mode)`
`22`		`- : base(isAsync, mode, useLegacyTransport: true)`
	`22`	`+ : base(isAsync, mode)`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`protected ResourceManagerTestBase(bool isAsync)`
`27`		`- : base(isAsync, useLegacyTransport: true)`
	`27`	`+ : base(isAsync)`
`28`	`28`	`{`
`29`	`29`	`}`
`30`	`30`
Original file line number	Diff line number	Diff line change
`@@ -21,12 +21,12 @@ public class ResourcesTestBase : ManagementRecordedTestBase<ResourcesTestEnviron`
`21`	`21`	`protected ArmClient Client { get; private set; }`
`22`	`22`
`23`	`23`	`protected ResourcesTestBase(bool isAsync, RecordedTestMode mode)`
`24`		`- : base(isAsync, mode, useLegacyTransport: true)`
	`24`	`+ : base(isAsync, mode)`
`25`	`25`	`{`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`protected ResourcesTestBase(bool isAsync)`
`29`		`- : base(isAsync, useLegacyTransport: true)`
	`29`	`+ : base(isAsync)`
`30`	`30`	`{`
`31`	`31`	`}`
`32`	`32`
Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,11 @@ public class ServiceBusTestBase: ManagementRecordedTestBase<ServiceBusManagement`
`18`	`18`	`internal const string DefaultNamespaceAuthorizationRule = "RootManageSharedAccessKey";`
`19`	`19`	`protected Subscription DefaultSubscription;`
`20`	`20`	`protected ArmClient Client { get; private set; }`
`21`		`- protected ServiceBusTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)`
	`21`	`+ protected ServiceBusTestBase(bool isAsync) : base(isAsync)`
`22`	`22`	`{`
`23`	`23`	`Sanitizer = new ServiceBusRecordedTestSanitizer();`
`24`	`24`	`}`
`25`		`- protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)`
	`25`	`+ protected ServiceBusTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)`
`26`	`26`	`{`
`27`	`27`	`Sanitizer = new ServiceBusRecordedTestSanitizer();`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ public class StorageTestBase : ManagementRecordedTestBase<StorageManagementTestE`
`31`	`31`	`};`
`32`	`32`	`protected ArmClient Client { get; private set; }`
`33`	`33`	`protected Subscription DefaultSubscription { get; private set; }`
`34`		`- protected StorageTestBase(bool isAsync) : base(isAsync, useLegacyTransport: true)`
	`34`	`+ protected StorageTestBase(bool isAsync) : base(isAsync)`
`35`	`35`	`{`
`36`	`36`	`}`
`37`	`37`
`38`		`- public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode, useLegacyTransport: true)`
	`38`	`+ public StorageTestBase(bool isAsync, RecordedTestMode mode) : base(isAsync, mode)`
`39`	`39`	`{`
`40`	`40`	`}`
`41`	`41`