Skip to content

Commit 31431b9

Browse files
ArcturusZhangm-nashbquantumpnisha-bhatiaallenjzhang
authored
Compute mgmt track 2 library (Azure#22944)
* initial checkin for core / tests (Azure#18968) * initial checkin for core / tests * Add readme.md file * Fix header in readme * remove autorest until we convert off hand written types * update azure.core reference remove sets to tags ignore tests which require credentials for now * Add the proto client which will be used until the autogen work is complete * Add missing readmes for proto client * update to require linq 4.0.0 so that don't have to upgrade bcl * add changlog for CI * change system.linq.async to update * update to use source vs binary for the temporary generation of Azure.ResourceManager.Authorization * Add changelog for azure.resourcemanager.authorization and update version to be beta * update typos in readme * update name of proto client sln * merge in changes from proto repo this week * fixed unit test failures missed a few files from the merge from proto repo updated compute and network sdk version to use latest azure.core with readonly list types * ignore tests which require live azure until 5122 is closed * Update failing scenario test * Subnet Container list still returns SubnetOperations and not Subnet #5584 (Azure#19109) * 5584 * Update async test * Test * WIP: test * Update Proto.Authorization.csproj * Update Proto.Authorization.csproj * Update Proto.Authorization.csproj * Update Proto.Authorization.csproj * add param checking to resource (Azure#19134) * Adding parameter check for track 2 Azure.ResourceManager.core (Azure#19162) * initial checkin * adding test cases * nibhati-5142-add Params and testing for ApiVersionBase.cs (Azure#19193) * add tests for ApiVersionBase * update methods * nibhati - 5142 - add tests for ArmBuilder.cs (Azure#19231) * add tests for ArmBuilder * Update ArmBuilderTests.cs * Update SubscriptionContainer.cs * Update test project to consume framework for recorded tests (Azure#19171) * Update test project to consume framework for recorded tests * Changes required to get instrumentation working for the new armClient added support for session recording for onetimesetup and onetimeteardown * move unit test files * update tests to not use username for prefix * update targets to separate existing track 2 libraries from new core until autorest changes are finished * merge in armbuildertest and update to use new framework * remove necessity on session files if no onetimesetup * Address review comments * Move ApiVersionOverrides to ARMClientOptions class (Azure#19358) * Rename list operations (Azure#19386) * tenant resource sample (Azure#19195) * WIP: tenant resource * WIP: updates * Update ResourceIdentifier.cs * Update ResourceIdentifier.cs * Update ResourceType.cs * WIP update check * WIP * Add readme for billing * Stylecop * WIP * Remove style * wip: update * WIP: updates * WIP * WIP: update * WIP * Updates * WIP: updates * Update * WIP: updates * WIP * Update tests * WIP: updates * Remove reference for Azure.Identity (Azure#19434) * Remove reference for Azure.Identity * fixing ArmClient construction in proto client * resync and fix build error * 5521 - Rename TryGetValue to TryGet/TryGetAsync (Azure#19478) * Rename TryGetValue to TryGet/TryGetAsync * Update ContainerBase.cs * Update ContainerBase.cs * Update TryGet method and test class * Update CheckResourceExists.cs * Rename TryGetValue to TryGet/TryGetAsync * Update ContainerBase.cs * Update ContainerBase.cs * Update TryGet method and test class * Update CheckResourceExists.cs * Update ContainerBaseTest.cs * Update TryGet Test * Update tests * Update tests and framework to instrument all clients recursively (Azure#19443) * Framework changes * Azure.ResourceManager.Core changes to support client interceptors * Test changes * proto client changes * updates after merge * Address review comments * WIP * updates after WIP * Update the implicit operator (Azure#19720) * Remove System.Linq.Async dependency. (Azure#19745) * Change the accessibility to virtual for Resource.Id (Azure#19804) * Sku Serialization (Azure#19819) * Sku Serialization * Divide Sku class * Update Sku * Add lookup mechanism for ID to apiversion (Azure#19437) * WIP: updates * WIP: updates * Update test * Update ResourceListOperationsTest.cs * Update CreateSingleVmExample.cs * Update CreateSingleVmExample.cs * Update CreateSingleVmExample.cs * Update CreateSingleVmExample.cs * WIP: Updates * Add extra line * Update * WIP: * WIP: updates * WIp: updates * Remove API version extensions * WIP: updates * Updates * Update test * WIP updates * Updates * WIP * Remove blank lines * Update filtering * Updates * Update * WIP: updates * WIP: updates * Add space * Remove debug * Updates * WIP: updates * WIP * Change the accessbility to virtual for Resource.Id * WIP: updates * WIP Updates * WIP updates * WIP * WIP * WIP: * revert * WIP: updates * WIP: updates * WIP: updated * WIP Co-authored-by: YalinLi0312 <yall@microsoft.com> * Resource Identifier changes (Azure#19636) * Resource Identifier changes * Adapting Container classes to base class change in Id property * Fixing xml documentation comments for ResourceType * Cleaning up resource id ToStrign() and fixing ListLocations client creation * Adjusting new tenant resource operations for resource id scheme * Responding to review comments * Add test coverage, retain string reresentation of resource id * Fixing additional merge issues * Updating comparison tests to use concrete variable types * Plan Serialization (Azure#19820) * Plan Serialization * Divide Plan class * Update Plan * Mnash 5705 rename container (Azure#19932) * Change the accessbility to virtual for Resource.Id * rename ArmClient, ArmClientOptions, Get[Resource]Container * updates after merge * missing one file for rename Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> * 2 missing renames (Azure#19952) * Change the accessbility to virtual for Resource.Id * rename ArmClient, ArmClientOptions, Get[Resource]Container * updates after merge * missing one file for rename * Missed 2 renames Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> * nibhati - 5191 - add ClientContext.cs (Azure#19602) * WIP * WIP * Update ResourceOperationsBase.cs * update for tenant extensions * update csproj * Update Azure.ResourceManager.Network.csproj * update csproj * update csproj * WIP * WIP * update csproj * update csproj * update csproj * add tests * update test * update * fix test cases to use the diagnostics case fix a missing mocking constructor * WIP * update framework for tests * Update Azure.Test.Perf.csproj * merge * revert list json files * revert * WIP * fix ci * Update Program.cs * update proto * fix test * Update ClientContextTests.cs * update proto * Update Azure.ResourceManager.Billing.csproj * update version * update ci * Update Azure.ResourceManager.EventHubs.csproj * add packable Co-authored-by: m-nash <prognash@microsoft.com> * GenericResource Serialization (Azure#19898) * Resource Serialization * Plan Serialization * Divide Plan class * Divide Resource class * Update writer * Update Plan * TrackedResource Serialization * Update GenericResource * Clean Up * Update GenericResource * Remove read only * Update tests * TrackedResource Serialization (Azure#19855) * Resource Serialization * Divide Resource class * Update writer * TrackedResource Serialization * Update Deserialization * Update Test * Update Tests * Update Tracked Resource * Fix PR * Remove readonly * Remove the Get[Resource]Operations methods except for client extensions (Azure#20136) * Change the accessbility to virtual for Resource.Id * wip * ignore test temporarily * update to remove Get[Resource]Operations Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> * nibhati - 5572 - make Credentials and Options internal (Azure#20243) * Change the accessbility to virtual for Resource.Id * add transport * update test * add jsons * add json * remove transport Co-authored-by: YalinLi0312 <yall@microsoft.com> * Remove ignore on tests that were failing due to faulted tasks in interceptor (Azure#20341) * Change the accessbility to virtual for Resource.Id * remove ignore on tests and update intrumentation to handle faulted tasks Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <micnash@microsoft.com> * Make the Reference type generic (Azure#20358) * Change the accessbility to virtual for Resource.Id * Make the reference type generic Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * nibhati 5401 - add CancellationToken to GetResource() (Azure#20396) * Change the accessbility to virtual for Resource.Id * add token Co-authored-by: YalinLi0312 <yall@microsoft.com> * JonathanCrd 5574 - remove system.collections.immutable (Azure#20437) * Change the accessbility to virtual for Resource.Id * Removing package reference to System.Collections.Immutable * Removing use of ImmutableList Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * JonathanCrd 5003 - comparison methods for ResourceIdentifier (Azure#20456) * Change the accessbility to virtual for Resource.Id * Operators == and != overloads in ResourceIdentifier * Added EqualsToString Tests and TestCases Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * update constructors for reference types (Azure#20477) * update constructors for reference types * fix stylecop issue * fixes after merge * add two way implicit for autorest deserialization (Azure#20557) * update constructors for reference types * fix stylecop issue * add two way implicit for autorest deserialization * Add a common definition for sub-resource (Azure#20524) * add SubResource * serialization of the two classes * protected internal; full subresource namespace Co-authored-by: Yeming Liu <yeliu@microsoft.com> * Add default constructors to resource classes (Azure#20583) * update constructor signatures for autogen (Azure#20607) * update constructors for reference types * fix stylecop issue * add two way implicit for autorest deserialization * update constructor signatures for autogen * Remove ProxyResource since its intended to be used any longer (Azure#20608) * adding reference constructors attributes (Azure#20611) * update constructors for reference types * fix stylecop issue * add two way implicit for autorest deserialization * update constructor signatures for autogen * add attributes to define ctor types for autogen * Cache the creation of HTTP pipeline in ArmClient (Azure#20636) * Remove create from container base; remove ArmBuilder abstract class (Azure#20684) * Remove create from container base; remove ArmBuilder abstract class * UnTypedContainer->Container; fix doc issues * make createAsync() virtual Co-authored-by: Yeming Liu <yeliu@microsoft.com> * fixes after merge * adding singleton pattern in Arm.Core and Proto (Azure#20591) * adding initial singleton base classs and proto code * PR comment fix. * Completed singleton VMSS test case. * Fix merge issue around ArmBuilder removal * Fix build issue. * Fixing test failure * CR comment. * Flattend the builder to partial classes. * CR fix * Update arm response types to match current Azure.Core pattern (Azure#20738) * WIP * wip * Change the accessbility to virtual for Resource.Id * update strawman for operation changes * finalize changes before testing * update ph overloads * move pipeline creation into armoperation * wip * updates based on new OperationInternals * address PR comments * update test classes to use new pattern * final fixes for arm core tests * use mock response instead of null * updates to proto code * add null check around basetype Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> * Fix a bug in ArmClient (Azure#20897) * Move generic resource from resources to core (Azure#20927) * initial changes to move generic resource items over * wip updating tests * more work on test cases * updates to adapt the operation changes * remove arm response / operation * remove unused classes now and finish move resource test * update resourcegroup operation tests * update tests for genericresource operations * add genericresource container tests * update proto solution * update proto comments * address naming comments * update comments which no longer have inheritance address wildcard comment in csproj * update ResourceContainerBase (Azure#20981) Co-authored-by: Yeming Liu <yeliu@microsoft.com> * updates to subresource type (Azure#21010) clean up extensions meant for Operation now * VM image, extension image (edgezone not included as it is new not in Compute sdk yet) (Azure#20971) * update reference types and add unit tests to validate (Azure#21031) * updates to subresource type clean up extensions meant for Operation now * need protected internal serialization constructor for reference types, added unit tests to validate for future * updates after merge * update policy copying for clone and convert (Azure#21069) * 5771 - GetGenericResourceOperations in ArmClient (Azure#21066) * Change the accessbility to virtual for Resource.Id * GetGenericResourceOperations extension method implementation * Create ArmClientTests.cs * Scenario Tests * GetGenericResourceOperations for single ID * Single ID tests * Addressing comments * Tests recordings * Tests recordings Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * 5844 Rename SubResourceWritable to WritableSubResource (Azure#21092) * Rename symbol * Rename class * Rename serialization class * Merge Azure.ResourceManager.Resources.Models.Subscription with Azure.ResourceManager.Core.SubscriptionData (Azure#20751) * Initial * Merge * Update SubscriptionOperations.cs * Fix error * Update using * Update test * Fix tests * Update json * Update ClientContextTests.cs * update based on comments * Add get test * Remove unnecessary file * Update LocationListResult.cs * Update ClientContextTests.cs * Update operation class & add tests * move models to model folder Co-authored-by: m-nash <prognash@gmail.com> * remove id type from container base to match operation base (Azure#21150) * remove id type from container base to match operation base * update proto references * add support for root resource Id container (Azure#21175) * remove id type from container base to match operation base * update proto references * add support for root resource Id container * Merge ResourceGroup model in Resources with ResourceGroupData in Core (Azure#20904) * Change the accessbility to virtual for Resource.Id * Merge ResourceGroup model in Resources with Core ResourceGroupData * Add and update scenario tests * Resolve merge conflicts * Update scenario tests * Record ResourceGroupContainerTests * Initialize Tags in base class * Update ResourceGroupOperationsTests and re-record * Fix the errors in Proto.Client scenario tests * Move some files in Generated folder back * Address review comments * Add records * Fix the failing test StartExportTemplate * Address comments * Change tag lro operations to return its lro type * Change rg CreateOrUpdate lro operations to return its lro object * Update CreateOrUpdate lro object * Run tests Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Delete PhTaskDeferringAsyncPageable.cs (Azure#21183) * Remove PhArmResponse (Azure#21139) * Remove PhArmResponse part 1 * Remove PhArmResponse part 2 * Delete PhArmResponse.cs Co-authored-by: m-nash <prognash@gmail.com> * Remove PhArmOperation (Azure#21290) * Remove PhArmOperation * Disable TestResourceTypeFilterParamCheck Test * Disable SA warning * remove unused file Co-authored-by: m-nash <prognash@gmail.com> * 5841 - Update List methods from proto clients. (Azure#21314) * Remove List methods with inner Get() call in Compute * Remove List methods with inner Get() call in Network * Removing scenario tests referencing deleted List() methods * Add lambda wrapper in armclient for getting container objects in othe… (Azure#21390) * Add lambda wrapper in armclient for getting container objects in other RPs * update xml comments * 5285 Remove TrackedResource<TIdentifier, TModel> class. (Azure#21376) * Delete TrackedResource.cs * Removed class from Core added to individual Proto Libraries * Removing imported class in Proto.Client * Add missing new lines * update to allow external access to a constructor that doesn't have an operation base (Azure#21395) * Add lambda wrapper in armclient for getting container objects in other RPs * update xml comments * update to add externally accesible constructor that doesn't have an operation base like armclient as the parent * Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager,Core (Azure#21413) * Change the accessbility to virtual for Resource.Id * Move Azure.ResourceManager.Resources Tenants objects to Azure.ResourceManager.Core * Resolve conflicts Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Templetize SubResource and WritableSubResource classes, and added unit tests (Azure#21397) * Change the accessbility to virtual for Resource.Id * Sub resource template and tests * public class , public constructor * some PR comments * PR comments and phonecall around silent errors and casting Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Remove the suppression for namespace in mgmt sdks (Azure#21534) * remove no warn AZC0001 * remove the namespace warn suppression from mgmt plane sdks * remove old todo * update tenant and subscription list resource hooks to follow the same pattern (Azure#21568) * fix the attribute of subresource (Azure#21685) * fix the attribute of writableSubResource (Azure#21688) * Add ArmClient tests (Azure#21620) * Change the accessbility to virtual for Resource.Id * Add tests for ArmClient * Address review comment * Update recordings Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Add GenericResourceContainer tests (Azure#21759) * Change the accessbility to virtual for Resource.Id * Add CreateOrUpdate tests * Add StartCreateOrUpdate tests * Add Get tests * Add GetApiVersion and ListByResourceGroup tests * Update test records Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Bug System.ArgumentOutOfRangeException thrown in ResourceIdentifier - 5879 - nibhati (Azure#21537) * add list resources apis to resourceGroupOperations (Azure#21809) * [Azure.ResourceManager.Core] Introduce the `UseClientContext` to `SubscriptionOperations` and `ResourceGroupOperations` (Azure#21811) * introduce the useClientContext to subscriptionOperations and ResourceGroupOperations * resolve comments * resolve comments * fix compile errors in other solutions * Add ResourceGroupContainer tests (Azure#21832) * Change the accessbility to virtual for Resource.Id * Add ResourceGroupContainer tests Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * remove ph classes (Azure#21852) * remove ph classes * add temp files to proto * change Parent in ContainerBase to OperationsBase type (Azure#21872) * Add GenericResourceOperations tests (Azure#21828) * Change the accessbility to virtual for Resource.Id * Add GenericResourceOperations tests * Merge GenericResourceOperationsTests and GenericResourceTests Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Add ResourceGroupOperations tests (Azure#21893) * Change the accessbility to virtual for Resource.Id * Add ResourceGroupOperations tests * Remove parallelizable tag * Update session records Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * update to be inside core namespace (Azure#21892) * update to be inside core namespace * update proto references to removed namespace * remove references from test proj * remove unused interfaces (Azure#21898) * update to be inside core namespace * update proto references to removed namespace * remove unused interfaces * Add ResourceGroupBuilder tests (Azure#21897) * Change the accessbility to virtual for Resource.Id * Add ResourceGroupBuilder tests * Address comment * Extract the test for Build() to a seperate method Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Update Track 2 Mgmt Plane Template (Azure#21876) * Update Track 2 Mgmt Plane Template * Moving the package ref into the actual project file * Fixing Management tests and updating sln to include missed project * Update build for core.test and invert the mgmt shared test code include. * Fix CI * Add ResourceGroupDeleteOperation tests (Azure#21927) * 5966 sync code coverage fix (Azure#21925) * consolidate test classes * update interceptors to get code coverage on sync methods for LRO responses * Remove ArmResponse since that is no longer needed * update test cases that moved with recordings * remove TA dependency on core sln * put back ai dependency which we should remove * update to cover .net 5 case * consolidate code * remove extension sub classes since they aren't needed (Azure#21945) rename some parameters * Mnash apiview cleanup (Azure#21952) * remove extension sub classes since they aren't needed rename some parameters * update instrumentation for generic resource and tenant * remove Get() from ResourceOperationsBase (Azure#21963) Co-authored-by: Yeming Liu <yeliu@microsoft.com> * update to use zero wait on playback (Azure#22066) * update to use zero wait on playback * update resourcemanager ci to run when shared files change * one more mgmt shared folder * Update sub resource CC to 94%. (Azure#22117) * Add ResourceGroupsRestOperations tests (Azure#21981) * Added support for implicit provider resource type ResourceIdentifier p… (Azure#22142) * Added support for impicit provider resource type ResourceIdentifier parsing * Update clearer list name based on CR comment * Azure.ResourceManager.Core readmes and samples (Azure#21858) * Change the accessbility to virtual for Resource.Id * Readme and sample files * Fixing links * Fixing links * Fixing links * Delete OLD README.md * Migrating to new SDK * samples rename * Update ManagingResourceGroups.md Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * Addressing comments in Managing Resource Groups example * Hello World added * Update Sample1_HelloWorld.md * Delete README.md * Create README.md * Addressing HelloWorld comments * Apply suggestions from code review Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * Addressing comments in readme * Commenting relative links * Fix CI Link errors * Fixing CI errors * Snippets IDs deleted * Changing Prerequisites and Auth info * Don't use .Construct in rg example * Migration guides in future PR * Fix CI * Prerequisites * Remove Links comments temporarily * Typo in Readme * Apply suggestions from code review Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> * Changing all links to absolute links * Spelling * Commenting not existing links * Fix CI * Typo * Update Sample1_HelloWorld.md * Apply suggestions from code review Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> * Move Providers and ProviderOperations from Azure.ResourceManager.Resources into Azure.ResourceManager.Core-nibhati-5862 (Azure#21337) * Change the accessbility to virtual for Resource.Id * WIP * WIP * WIP * wip * Update TenantOperations.cs * wip * WIP * wip * wip * wip * wip * fix formatting * wip * Update ProviderContainer.cs * Update ProviderContainer.cs * wip * wip * Update ProviderContainerTests.cs * wip * wip * update to interceptor to handle targetinvocation on a failed task * remove expand parameter from LoadApiVersion methods Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * remove need to copy policies (Azure#22280) * Add ResourceListOperations tests (Azure#22279) * Change the accessbility to virtual for Resource.Id * Add ResourceListOperations tests Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * remove proto (Azure#22282) * Follow up PR - 5593 Azure.ResourceManager.Core Readme (Azure#22262) * Change the accessbility to virtual for Resource.Id * Changing temporary links to absolute ones. Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Add PropertyReferenceType attribute in ResourceIdentity (Azure#22255) * Add PropertyReferenceTypeAttribute attribute in ResourceIdentity * Feedback * remove resources dependency (Azure#22293) * wip * remove remaining references to azure.resourcemanager.resources * update tests to handle new changes * update summary for gets or sets * Updating GenericResource.Lists to return GenericResourceExpanded. (Azure#22284) * Updating GenericResourceList to return GenericResourceExpanded * Added missing expand and related test cases. * Adding missing test recordings. * cleanup the warnings that were supressed (Azure#22318) * fix CA1036 * remove CA1067 * remove CA1065 * remove SA1028 * Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest (Azure#22351) * Updating GenericResourceList to return GenericResourceExpanded * Added missing expand and related test cases. * Adding missing test recordings. * Exposing expand on ListAtContext as well in preparation to expose that in each of the generated ListAsGeneric methods in autorest * Catch TargetInvocationException in interceptor (Azure#22207) * Change the accessbility to virtual for Resource.Id * Catch TargetInvocationException in interceptor Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Add JsonConverter for ResourceIdentity (Azure#22373) * Add JsonConverter for ResourceIdentity * Feedback * Format file * Update to use common rest api for OperationsList (Azure#22343) * wip changes to add common rest api * update variable name * address pr comments * update recording * Add SubscriptionContainer tests (Azure#22348) * Add SubscriptionsRestOperations tests (Azure#22482) * ADO-5881 Move Azure.ResourceManager.Resources Tags objects to Azure.ResourceManager.Core (Azure#21439) * Initial * Intial part 2 * Update tests * Update Tags * Update operation and container * Update PreDefinedTags * Update ResourceIdentifier.cs * Update at scope Tag * Create TestUpdateAllTags.json * Update ResourceGroupOperations.cs * Update-1 * Update-2 * Update resource type * Update testing coverage * Update to use single * Update tags * Update-2 * Update-3 * Update-4 * Update for rename and move method * Update to use replacewith * Add test coverage * Update for remove LRO methods * Update TaggableResourceTests.cs * minor PR comment fixes * fix tag resource container ctor * update generic resource to use new implementation remove unused test recordings Co-authored-by: m-nash <prognash@gmail.com> * changes to arm core (Azure#22524) * [Bug Fix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params (Azure#22551) * [BugFix] Methods in ResourceGroupContainer.cs in Azure.ResourceManager.Core passes in null params * Add ResponseExtensions tests (Azure#22553) * Move feature operations to azure.resourcemanager.core (Azure#22570) * move features operations to core * update xml docs * Remove GetResource() from ResourceOperationsBase (Azure#22571) * Change the accessbility to virtual for Resource.Id * Add SubscriptionContainer tests (Azure#22348) * Remove GetResource() from ResourceOperationsBase * Remove GetResource() in ResourceGroup * Remove GetResource() in Feature Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * Updating code snippets in Samples and Readme (Azure#22518) * Change the accessbility to virtual for Resource.Id * Initial setup * Adding Snippets to tests\Samples * Generate snippets in markdown files * Sample 3 code snippets * Update Sample2_ManagingResourceGroups.cs * Update Snippets with generator * Fix Sample2 snippets * Delete Azure - Backup.ResourceManager.Core.Tests.csproj * Ignoring dummy subscription id tests * Adding namespaces to examples * Modify code snippets in main readme * Add ignore tags * Adding Azure.ResourceManager.Core namespace * Update code snippets * Adjust indentation * Removing auto-gen snippets for Sample3 Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * nibhati-5273-merge location (Azure#22483) * Change the accessbility to virtual for Resource.Id * wip * WIP * Update ResourceOperationsBase.cs * wip * wip * wip * wip * wip * update loc based on feedback * update after merge * update to core framework tests * update samples after location changes * update readme based on code changes Co-authored-by: YalinLi0312 <yall@microsoft.com> Co-authored-by: Nisha Bhatia <nibhati@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> * add management object group to core (Azure#22592) * wip * Add mgmt group to core * remove temp files * update to not have nullable but share the same operations between ManagementGroup and ManagementGroupInfo * address PR comments * change location to string to return name instead of display name (Azure#22606) * update location name and corresponding tests * update comments * setting up * initial generate * regenerate * update version of armcore * regenerate after the fix of put without body * regenerate after the list function fix * fix merge issues * bump arm core version * regenerate and remove test cases * regenerate * add test cases for availability sets * add test cases for disks * fix the merge issues... * regenerate * fix compile errors in test project after the renaming * add test cases for virtual machines * add test cases for vmss * add test cases for gallery * add test cases for gallery images * update the version of armcore * regenerate and fix tests * regenerate everything * fix test cases and rerecording * modify readme and add samples * regenerate and refresh the test result * change version number and remove unnecessary nowarn * fix readme * update version of armcore * update to latest armcore * clean autorest.md and regenerate * regenerate to change some function named Start to PowerOn * update readme * modify changelog.md accordingly * refresh readme * move test base and environment up a level * refresh public API * update armcore version * simplify test csproj * regenerate * regenerate * update test cases * add test case for DHG * clean up the tests * update links to feature branch until merge happens * comment out record mode * update to latest autorest and regen so CI can pass * update api * add package ref to identity in test project * regenerate * add new test for dedicated host container * update api * add test cases for dedicated host operations * add test for disk access * refactor test cases * regenerate to include the LRO changes * rerecord test cases for disk * introduce network sdk and rerecord test cases for vm and vmss * revert using network package * update changelog * remove the target test framework in the csproj of test project * regenerate * update api * regenerate and fix tests * regenrate using latest version of autorest.csharp * regenerate * update api * fix compile error in tests * rerun all test * regenerate * fix compile errors * regenerate * update api * update compute versoin in data.props update storage tests which reference compute client * comment out tests which are no longer valid due to old dependencies * update snippet in readme Co-authored-by: m-nash <64171366+m-nash@users.noreply.github.com> Co-authored-by: bquantump <53361486+bquantump@users.noreply.github.com> Co-authored-by: nisha-bhatia <67986960+nisha-bhatia@users.noreply.github.com> Co-authored-by: Allen Zhang <allenzhang@live.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: m-nash <prognash@microsoft.com> Co-authored-by: m-nash <prognash@gmail.com> Co-authored-by: m-nash <micnash@microsoft.com> Co-authored-by: Jonathan Cárdenas <JonathanCrd@users.noreply.github.com> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> Co-authored-by: Yeming Liu <yeliu@microsoft.com> Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com> Co-authored-by: Feng Zhou <55177366+fengzhou-msft@users.noreply.github.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Nisha Bhatia <nibhati@microsoft.com>
1 parent 7ee360a commit 31431b9

File tree

1,410 files changed

+1119654
-6556849
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,410 files changed

+1119654
-6556849
lines changed

eng/Packages.Data.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
<PackageReference Update="ApprovalUtilities" Version="3.0.22" />
160160
<PackageReference Update="Azure.Messaging.EventHubs" Version="5.2.0" />
161161
<PackageReference Update="Azure.Messaging.EventGrid" Version="4.0.0" />
162-
<PackageReference Update="Azure.ResourceManager.Compute" Version="1.0.0-preview.2" />
162+
<PackageReference Update="Azure.ResourceManager.Compute" Version="1.0.0-alpha.20210824.1" />
163163
<PackageReference Update="Azure.ResourceManager.Network" Version="1.0.0-preview.2" />
164164
<PackageReference Update="Azure.ResourceManager.Resources" Version="1.0.0-preview.2" />
165165
<PackageReference Update="Azure.ResourceManager.Storage" Version="1.0.0-preview.2" />

sdk/compute/Azure.ResourceManager.Compute/CHANGELOG.md

Lines changed: 42 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,8 @@
11
# Release History
22

3-
## 1.0.0-preview.3 (Unreleased)
3+
## 1.0.0-beta.1 (Unreleased)
44

55

6-
## 1.0.0-preview.2 (2020-09-23)
7-
8-
- Accept header added to all requests.
9-
- Collections are now always initialized and collection properties are readonly by default.
10-
11-
## 1.0.0-preview.1
12-
13-
This package follows the [Azure SDK Design Guidelines for .NET](https://azure.github.io/azure-sdk/dotnet_introduction.html) which provide a number of core capabilities that are shared amongst all Azure SDKs, including the intuitive Azure Identity library, an HTTP Pipeline with custom policies, error-handling, distributed tracing, and much more.
14-
15-
This is a Public Preview version, so expect incompatible changes in subsequent releases as we improve the product. To provide feedback, please submit an issue in our [Azure SDK for .NET GitHub repo](https://github.com/Azure/azure-sdk-for-net/issues).
16-
17-
### General New Features
18-
19-
- Support MSAL.NET, Azure.Identity is out of box for supporting MSAL.NET
20-
- Support [OpenTelemetry](https://opentelemetry.io/) for distributed tracing
21-
- HTTP pipeline with custom policies
22-
- Better error-handling
23-
- Support uniform telemetry across all languages
24-
25-
> NOTE: For more information about unified authentication, please refer to [Azure Identity documentation for .NET](https://docs.microsoft.com//dotnet/api/overview/azure/identity-readme?view=azure-dotnet)
26-
276
### Migration from Previous Version of Azure Management SDK
287

298
#### Package Name
@@ -62,7 +41,7 @@ computeClient.SubscriptionId = subscriptionId;
6241

6342
var location = "westus";
6443
// Create Resource Group
65-
await resourceClient.ResourceGroups.CreateOrUpdateAsync(resourceGroup, new ResourceGroup(location));
44+
await resourceClient.ResourceGroups.CreateOrUpdateAsync(resourceGroupName, new ResourceGroup(location));
6645

6746
// Create Availability Set
6847
var availabilitySet = new AvailabilitySet(location)
@@ -73,7 +52,7 @@ var availabilitySet = new AvailabilitySet(location)
7352
};
7453

7554
availabilitySet = await computeClient.AvailabilitySets
76-
.CreateOrUpdateAsync(resourceGroup, vmName + "_aSet", availabilitySet);
55+
.CreateOrUpdateAsync(resourceGroupName, vmName + "_aSet", availabilitySet);
7756

7857
// Create IP Address
7958
var ipAddress = new PublicIPAddress()
@@ -84,7 +63,7 @@ var ipAddress = new PublicIPAddress()
8463
};
8564

8665
ipAddress = await networkClient
87-
.PublicIPAddresses.BeginCreateOrUpdateAsync(resourceGroup, vmName + "_ip", ipAddress);
66+
.PublicIPAddresses.BeginCreateOrUpdateAsync(resourceGroupName, vmName + "_ip", ipAddress);
8867

8968
// Create VNet
9069
var vnet = new VirtualNetwork()
@@ -102,7 +81,7 @@ var vnet = new VirtualNetwork()
10281
};
10382

10483
vnet = await networkClient.VirtualNetworks
105-
.BeginCreateOrUpdateAsync(resourceGroup, vmName + "_vent", vnet);
84+
.BeginCreateOrUpdateAsync(resourceGroupName, vmName + "_vent", vnet);
10685

10786
// Create Network interface
10887
var nic = new NetworkInterface()
@@ -122,7 +101,7 @@ var nic = new NetworkInterface()
122101
};
123102

124103
nic = await networkClient.NetworkInterfaces
125-
.BeginCreateOrUpdateAsync(resourceGroup, vmName + "_nic", nic);
104+
.BeginCreateOrUpdateAsync(resourceGroupName, vmName + "_nic", nic);
126105

127106
var vm = new VirtualMachine(location)
128107
{
@@ -149,7 +128,7 @@ var vm = new VirtualMachine(location)
149128
HardwareProfile = new HardwareProfile() { VmSize = VirtualMachineSizeTypes.StandardB1ms },
150129
};
151130

152-
await computeClient.VirtualMachines.BeginCreateOrUpdateAsync(resourceGroup, vmName, vm);
131+
await computeClient.VirtualMachines.BeginCreateOrUpdateAsync(resourceGroupName, vmName, vm);
153132

154133
```
155134

@@ -160,72 +139,65 @@ using System.Linq;
160139
using System.Threading.Tasks;
161140

162141
using Azure.Identity;
142+
using Azure.ResourceManager;
163143
using Azure.ResourceManager.Compute.Models;
164144
using Azure.ResourceManager.Network;
165145
using Azure.ResourceManager.Network.Models;
146+
using Azure.ResourceManager.Resources;
147+
using Azure.ResourceManager.Resources.Models;
166148

149+
var armClient = new ArmClient(new DefaultAzureCredential());
167150

168-
var computeClient = new ComputeManagementClient(subscriptionId, new DefaultAzureCredential());
169-
var networkClient = new NetworkManagementClient(subscriptionId, new DefaultAzureCredential());
151+
var location = Location.WestUS;
152+
// Create ResourceGroup
153+
ResourceGroup resourceGroup = await armClient.GetResourceGroups().CreateOrUpdateAsync(resourceGroupName, new ResourceGroupData(location));
170154

171-
var availabilitySetsClient = computeClient.AvailabilitySets;
172-
var virtualNetworksClient = networkClient.VirtualNetworks;
173-
var networkInterfaceClient = networkClient.NetworkInterfaces;
174-
var virtualMachinesClient = computeClient.VirtualMachines;
175-
176-
var location = "westus";
177155
// Create AvailabilitySet
178-
var availabilitySet = new AvailabilitySet(location)
156+
var availabilitySetData = new AvailabilitySetData(location)
179157
{
180158
PlatformUpdateDomainCount = 5,
181159
PlatformFaultDomainCount = 2,
182-
Sku = new Sku() { Name = "Aligned" } // TODO. Verify new codegen on AvailabilitySetSkuTypes.Aligned
160+
Sku = new Compute.Models.Sku() { Name = "Aligned" }
183161
};
184-
185-
availabilitySet = await availabilitySetsClient.CreateOrUpdateAsync(resourceGroup, vmName + "_aSet", availabilitySet);
162+
AvailabilitySet availabilitySet = await resourceGroup.GetAvailabilitySets().CreateOrUpdateAsync(vmName + "_aSet", availabilitySetData);
186163

187164
// Create VNet
188-
var vnet = new VirtualNetwork()
165+
var vnetData = new VirtualNetworkData()
189166
{
190167
Location = location,
191-
AddressSpace = new AddressSpace() { AddressPrefixes = new List<string>() { "10.0.0.0/16" } },
192-
Subnets = new List<Subnet>()
168+
AddressSpace = new AddressSpace() { AddressPrefixes = { "10.0.0.0/16" } },
169+
Subnets =
193170
{
194-
new Subnet()
171+
new SubnetData()
195172
{
196173
Name = "mySubnet",
197174
AddressPrefix = "10.0.0.0/24",
198175
}
199176
},
200177
};
201-
202-
vnet = await virtualNetworksClient
203-
.StartCreateOrUpdate(resourceGroup, vmName + "_vent", vnet)
204-
.WaitForCompletionAsync();
178+
VirtualNetwork vnet = await resourceGroup.GetVirtualNetworks().CreateOrUpdateAsync(vmName + "_vent", vnetData);
205179

206180
// Create Network interface
207-
var nic = new NetworkInterface()
181+
var nicData = new NetworkInterfaceData()
208182
{
209183
Location = location,
210-
IpConfigurations = new List<NetworkInterfaceIPConfiguration>()
184+
IpConfigurations =
211185
{
212186
new NetworkInterfaceIPConfiguration()
213187
{
214188
Name = "Primary",
215189
Primary = true,
216-
Subnet = new Subnet() { Id = vnet.Subnets.First().Id },
190+
Subnet = new SubnetData() { Id = vnet.Data.Subnets.First().Id },
217191
PrivateIPAllocationMethod = IPAllocationMethod.Dynamic,
218192
}
219193
}
220194
};
195+
NetworkInterface nic = await resourceGroup.GetNetworkInterfaces().CreateOrUpdateAsync(vmName + "_nic", nicData);
221196

222-
nic = await networkInterfaceClient
223-
.StartCreateOrUpdate(resourceGroup, vmName + "_nic", nic)
224-
.WaitForCompletionAsync();
225-
226-
var vm = new VirtualMachine(location)
197+
var vmData = new VirtualMachineData(location)
227198
{
228-
NetworkProfile = new Compute.Models.NetworkProfile { NetworkInterfaces = new[] { new NetworkInterfaceReference() { Id = nic.Id } } },
199+
AvailabilitySet = new Compute.Models.SubResource() { Id = availabilitySet.Id },
200+
NetworkProfile = new Compute.Models.NetworkProfile { NetworkInterfaces = { new NetworkInterfaceReference() { Id = nic.Id } } },
229201
OsProfile = new OSProfile
230202
{
231203
ComputerName = "testVM",
@@ -241,16 +213,11 @@ var vm = new VirtualMachine(location)
241213
Publisher = "Canonical",
242214
Sku = "18.04-LTS",
243215
Version = "latest"
244-
},
245-
DataDisks = new List<DataDisk>()
216+
}
246217
},
247218
HardwareProfile = new HardwareProfile() { VmSize = VirtualMachineSizeTypes.StandardB1Ms },
248219
};
249-
vm.AvailabilitySet.Id = availabilitySet.Id;
250-
251-
var operaiontion = await virtualMachinesClient.StartCreateOrUpdateAsync(resourceGroup, vmName, vm);
252-
await operaiontion.WaitForCompletionAsync();
253-
220+
VirtualMachine vm = await resourceGroup.GetVirtualMachines().CreateOrUpdateAsync(vmName, vmData);
254221
```
255222

256223
#### Object Model Changes
@@ -277,14 +244,15 @@ var vmExtension = new VirtualMachineExtension
277244

278245
After upgrade:
279246
```csharp
280-
var vmExtension = new VirtualMachineExtension(
281-
null,
282-
"vmext01",
283-
"Microsoft.Compute/virtualMachines/extensions",
284-
"westus",
285-
new Dictionary<string, string>() { { "extensionTag1", "1" }, { "extensionTag2", "2" } },
286-
"RerunExtension",
287-
"Microsoft.Compute",
288-
"VMAccessAgent", "2.0", true, "{}", "{}", null, null
289-
);
247+
var vmExtension = new VirtualMachineExtensionData(Location.WestUS)
248+
{
249+
Tags = { { "extensionTag1", "1" }, { "extensionTag2", "2" } },
250+
Publisher = "Microsoft.Compute",
251+
VirtualMachineExtensionType = "VMAccessAgent",
252+
TypeHandlerVersion = "2.0",
253+
AutoUpgradeMinorVersion = true,
254+
ForceUpdateTag = "RerunExtension",
255+
Settings = "{}",
256+
ProtectedSettings = "{}"
257+
};
290258
```

0 commit comments

Comments
 (0)