Add more system event mappings (Azure#19280)

* Add more system event mappings

* Update comment

* PR FB

Author: JoshLove-msft

sdk/eventgrid/Azure.Messaging.EventGrid/api/Azure.Messaging.EventGrid.netstandard2.0.cs

@@ -128,6 +128,10 @@ public static partial class SystemEventNames
         public const string MediaLiveEventIncomingVideoStreamsOutOfSync = "Microsoft.Media.LiveEventIncomingVideoStreamsOutOfSync";
         public const string MediaLiveEventIngestHeartbeat = "Microsoft.Media.LiveEventIngestHeartbeat";
         public const string MediaLiveEventTrackDiscontinuityDetected = "Microsoft.Media.LiveEventTrackDiscontinuityDetected";
+        public const string RedisExportRDBCompleted = "Microsoft.Cache.ExportRDBCompleted";
+        public const string RedisImportRDBCompleted = "Microsoft.Cache.ImportRDBCompleted";
+        public const string RedisPatchingCompleted = "Microsoft.Cache.PatchingCompleted";
+        public const string RedisScalingCompleted = "Microsoft.Cache.ScalingCompleted";
         public const string ResourceActionCancel = "Microsoft.Resources.ResourceActionCancel";
         public const string ResourceActionFailure = "Microsoft.Resources.ResourceActionFailure";
         public const string ResourceActionSuccess = "Microsoft.Resources.ResourceActionSuccess";
@@ -141,6 +145,8 @@ public static partial class SystemEventNames
         public const string ServiceBusActiveMessagesAvailableWithNoListeners = "Microsoft.ServiceBus.ActiveMessagesAvailableWithNoListeners";
         public const string ServiceBusDeadletterMessagesAvailablePeriodicNotifications = "Microsoft.ServiceBus.DeadletterMessagesAvailablePeriodicNotifications";
         public const string ServiceBusDeadletterMessagesAvailableWithNoListener = "Microsoft.ServiceBus.DeadletterMessagesAvailableWithNoListener";
+        public const string SignalRServiceClientConnectionConnected = "Microsoft.SignalRService.ClientConnectionConnected";
+        public const string SignalRServiceClientConnectionDisconnected = "Microsoft.SignalRService.ClientConnectionDisconnected";
         public const string StorageBlobCreated = "Microsoft.Storage.BlobCreated";
         public const string StorageBlobDeleted = "Microsoft.Storage.BlobDeleted";
         public const string StorageBlobRenamed = "Microsoft.Storage.BlobRenamed";

sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/SystemEventExtensions.cs

@@ -22,7 +22,7 @@ public static object AsSystemEventData(string eventType, JsonElement data)
             }
         }
 
-        private static readonly IReadOnlyDictionary<string, Func<JsonElement, object>> s_systemEventDeserializers = new Dictionary<string, Func<JsonElement, object>>(StringComparer.OrdinalIgnoreCase)
+        internal static readonly IReadOnlyDictionary<string, Func<JsonElement, object>> s_systemEventDeserializers = new Dictionary<string, Func<JsonElement, object>>(StringComparer.OrdinalIgnoreCase)
         {
             // KEEP THIS SORTED BY THE NAME OF THE PUBLISHING SERVICE
             // Add handling for additional event types here.
@@ -132,12 +132,22 @@ public static object AsSystemEventData(string eventType, JsonElement data)
             { SystemEventNames.ResourceActionFailure, ResourceActionFailureEventData.DeserializeResourceActionFailureEventData },
             { SystemEventNames.ResourceActionCancel, ResourceActionCancelEventData.DeserializeResourceActionCancelEventData },
 
+            // Redis
+            { SystemEventNames.RedisExportRDBCompleted, RedisExportRDBCompletedEventData.DeserializeRedisExportRDBCompletedEventData },
+            { SystemEventNames.RedisImportRDBCompleted, RedisImportRDBCompletedEventData.DeserializeRedisImportRDBCompletedEventData },
+            { SystemEventNames.RedisPatchingCompleted, RedisPatchingCompletedEventData.DeserializeRedisPatchingCompletedEventData },
+            { SystemEventNames.RedisScalingCompleted, RedisScalingCompletedEventData.DeserializeRedisScalingCompletedEventData },
+
             // ServiceBus events
             { SystemEventNames.ServiceBusActiveMessagesAvailableWithNoListeners, ServiceBusActiveMessagesAvailableWithNoListenersEventData.DeserializeServiceBusActiveMessagesAvailableWithNoListenersEventData },
             { SystemEventNames.ServiceBusDeadletterMessagesAvailableWithNoListener, ServiceBusDeadletterMessagesAvailableWithNoListenersEventData.DeserializeServiceBusDeadletterMessagesAvailableWithNoListenersEventData },
             { SystemEventNames.ServiceBusActiveMessagesAvailablePeriodicNotifications, ServiceBusActiveMessagesAvailablePeriodicNotificationsEventData.DeserializeServiceBusActiveMessagesAvailablePeriodicNotificationsEventData },
             { SystemEventNames.ServiceBusDeadletterMessagesAvailablePeriodicNotifications, ServiceBusDeadletterMessagesAvailablePeriodicNotificationsEventData.DeserializeServiceBusDeadletterMessagesAvailablePeriodicNotificationsEventData },
 
+            // SignalR
+            { SystemEventNames.SignalRServiceClientConnectionConnected, SignalRServiceClientConnectionConnectedEventData.DeserializeSignalRServiceClientConnectionConnectedEventData },
+            { SystemEventNames.SignalRServiceClientConnectionDisconnected, SignalRServiceClientConnectionDisconnectedEventData.DeserializeSignalRServiceClientConnectionDisconnectedEventData },
+
             // Storage events
             { SystemEventNames.StorageBlobCreated, StorageBlobCreatedEventData.DeserializeStorageBlobCreatedEventData },
             { SystemEventNames.StorageBlobDeleted, StorageBlobDeletedEventData.DeserializeStorageBlobDeletedEventData },

sdk/eventgrid/Azure.Messaging.EventGrid/src/Customization/SystemEventNames.cs

@@ -161,6 +161,7 @@ public static class SystemEventNames
         /// <see cref="ContainerRegistryChartPushedEventData"/> system event.
         /// </summary>
         public const string ContainerRegistryChartPushed = "Microsoft.ContainerRegistry.ChartPushed";
+
         #endregion
 
         #region Device events
@@ -682,5 +683,45 @@ public static class SystemEventNames
         /// </summary>
         public const string WebAppServicePlanUpdated = "Microsoft.Web.AppServicePlanUpdated";
         #endregion
+
+        #region Redis
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="RedisExportRDBCompletedEventData"/> system event.
+        /// </summary>
+        public const string RedisExportRDBCompleted = "Microsoft.Cache.ExportRDBCompleted";
+
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="RedisImportRDBCompletedEventData"/> system event.
+        /// </summary>
+        public const string RedisImportRDBCompleted = "Microsoft.Cache.ImportRDBCompleted";
+
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="RedisPatchingCompletedEventData"/> system event.
+        /// </summary>
+        public const string RedisPatchingCompleted = "Microsoft.Cache.PatchingCompleted";
+
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="RedisScalingCompletedEventData"/> system event.
+        /// </summary>
+        public const string RedisScalingCompleted = "Microsoft.Cache.ScalingCompleted";
+        #endregion
+
+        #region SignalR
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="SignalRServiceClientConnectionConnectedEventData"/> system event.
+        /// </summary>
+        public const string SignalRServiceClientConnectionConnected = "Microsoft.SignalRService.ClientConnectionConnected";
+
+        /// <summary>
+        /// The value of the Event Type stored in <see cref="EventGridEvent.EventType"/> and <see cref="CloudEvent.Type"/> for the
+        /// <see cref="SignalRServiceClientConnectionDisconnectedEventData"/> system event.
+        /// </summary>
+        public const string SignalRServiceClientConnectionDisconnected = "Microsoft.SignalRService.ClientConnectionDisconnected";
+        #endregion
     }
 }

sdk/eventgrid/Azure.Messaging.EventGrid/tests/SystemEventTests.cs

@@ -0,0 +1,30 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Linq;
+using System.Reflection;
+using Azure.Messaging.EventGrid.SystemEvents;
+using NUnit.Framework;
+
+namespace Azure.Messaging.EventGrid.Tests
+{
+    public class SystemEventTests
+    {
+        [Test]
+        public void MappingContainsAllSystemEvents()
+        {
+            foreach (var systemEvent in Assembly.GetAssembly(typeof(EventGridEvent)).GetTypes().Where(t => t.Name.EndsWith("EventData")))
+            {
+                // skip base types
+                if (systemEvent == typeof(ContainerRegistryArtifactEventData) ||
+                    systemEvent == typeof(ContainerRegistryEventData))
+                {
+                    continue;
+                }
+                Assert.IsTrue(
+                    SystemEventExtensions.s_systemEventDeserializers.Values.Any(
+                        f => f.Method.ReturnType == systemEvent), systemEvent.Name);
+            }
+        }
+    }
+}