[MetricsAdvisor] Fix Update methods issues (Azure#16696)

Author: kinelski

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/CHANGELOG.md

@@ -45,6 +45,8 @@
 
 ### Key Bug Fixes
 - Fixed a bug in sync and async `GetMetricEnrichedSeriesData` methods where a `NullReferenceException` was thrown if a returned data point had missing data.
+- Fixed a bug in sync and async `UpdateDataFeed` methods where a `RequestFailedException` was thrown if a data feed without custom `DataFeedMissingDataPointFillType` was updated.
+- Fixed a bug in sync and async `UpdateAlertConfiguration` methods where a `RequestFailedException` was thrown if a configuration with only one `MetricAnomalyAlertConfiguration` was updated.
 
 ## 1.0.0-beta.1 (2020-10-08)
 

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/AlertTriggering/AnomalyAlertConfiguration.cs

@@ -78,7 +78,7 @@ internal AnomalyAlertingConfigurationPatch GetPatchModel()
         {
             return new AnomalyAlertingConfigurationPatch()
             {
-                CrossMetricsOperator = CrossMetricsOperator.HasValue ? new AnomalyAlertingConfigurationPatchCrossMetricsOperator(CrossMetricsOperator.Value.ToString()) : default,
+                CrossMetricsOperator = CrossMetricsOperator.HasValue ? new AnomalyAlertingConfigurationPatchCrossMetricsOperator(CrossMetricsOperator.Value.ToString()) : default(AnomalyAlertingConfigurationPatchCrossMetricsOperator?),
                 Description = Description,
                 Name = Name,
                 HookIds = IdsOfHooksToAlert.Select(h => new Guid(h)).ToList(),

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/DataFeed/DataFeed.cs

@@ -244,7 +244,7 @@ internal DataFeedDetailPatch GetPatchModel()
             DataFeedDetailPatch patch = DataSource.InstantiateDataFeedDetailPatch();
 
             patch.DataFeedName = Name;
-            patch.Status = Status.HasValue ? new DataFeedDetailPatchStatus(Status.ToString()) : default;
+            patch.Status = Status.HasValue ? new DataFeedDetailPatchStatus(Status.ToString()) : default(DataFeedDetailPatchStatus?);
 
             patch.TimestampColumn = Schema.TimestampColumn;
 
@@ -256,19 +256,19 @@ internal DataFeedDetailPatch GetPatchModel()
 
             patch.DataFeedDescription = Description;
             patch.ActionLinkTemplate = ActionLinkTemplate;
-            patch.ViewMode = AccessMode.HasValue == true ? new DataFeedDetailPatchViewMode(AccessMode.ToString()) : default;
+            patch.ViewMode = AccessMode.HasValue == true ? new DataFeedDetailPatchViewMode(AccessMode.ToString()) : default(DataFeedDetailPatchViewMode?);
 
             if (RollupSettings != null)
             {
                 patch.AllUpIdentification = RollupSettings.AlreadyRollupIdentificationValue;
-                patch.NeedRollup = RollupSettings.RollupType.HasValue ? new DataFeedDetailPatchNeedRollup(RollupSettings.RollupType.ToString()) : default;
-                patch.RollUpMethod = RollupSettings.RollupMethod.HasValue ? new DataFeedDetailPatchRollUpMethod(RollupSettings.RollupMethod.ToString()) : default;
+                patch.NeedRollup = RollupSettings.RollupType.HasValue ? new DataFeedDetailPatchNeedRollup(RollupSettings.RollupType.ToString()) : default(DataFeedDetailPatchNeedRollup?);
+                patch.RollUpMethod = RollupSettings.RollupMethod.HasValue ? new DataFeedDetailPatchRollUpMethod(RollupSettings.RollupMethod.ToString()) : default(DataFeedDetailPatchRollUpMethod?);
                 patch.RollUpColumns = RollupSettings.AutoRollupGroupByColumnNames;
             }
 
             if (MissingDataPointFillSettings != null)
             {
-                patch.FillMissingPointType = MissingDataPointFillSettings.FillType.HasValue ? new DataFeedDetailPatchFillMissingPointType(MissingDataPointFillSettings.FillType.ToString()) : default;
+                patch.FillMissingPointType = MissingDataPointFillSettings.FillType.HasValue ? new DataFeedDetailPatchFillMissingPointType(MissingDataPointFillSettings.FillType.ToString()) : default(DataFeedDetailPatchFillMissingPointType?);
                 patch.FillMissingPointValue = MissingDataPointFillSettings.CustomFillValue;
             }
 

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/Models/DataFeed/DataFeedMissingDataPointFillSettings.cs

@@ -19,7 +19,9 @@ public DataFeedMissingDataPointFillSettings()
         internal DataFeedMissingDataPointFillSettings(DataFeedDetail dataFeedDetail)
         {
             FillType = dataFeedDetail.FillMissingPointType;
-            CustomFillValue = dataFeedDetail.FillMissingPointValue;
+            CustomFillValue = dataFeedDetail.FillMissingPointType == DataFeedMissingDataPointFillType.CustomValue
+                ? dataFeedDetail.FillMissingPointValue
+                : null;
         }
 
         /// <summary>

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/Samples/Sample01_DataFeedCrudOperations.cs

@@ -116,7 +116,6 @@ public async Task GetDataFeedAsync()
         }
 
         [Test]
-        [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/16168")]
         public async Task UpdateDataFeedAsync()
         {
             string endpoint = MetricsAdvisorUri;

sdk/metricsadvisor/Azure.AI.MetricsAdvisor/tests/Samples/Sample05_AlertConfigurationCrudOperations.cs

@@ -91,7 +91,6 @@ public async Task GetAlertConfigurationAsync()
         }
 
         [Test]
-        [Ignore("https://github.com/Azure/azure-sdk-for-net/issues/16168")]
         public async Task UpdateAlertConfigurationAsync()
         {
             string endpoint = MetricsAdvisorUri;