Adding Retries for InstallationCheck (Azure#23792)

* Adding Retries for InstallationCheck

* PR fix

* PR fix

* PR fix

* PR fix

Author: ckairen

eng/pipelines/templates/stages/archetype-net-release.yml

@@ -43,18 +43,6 @@ stages:
         dependsOn: Signing
         condition: and(succeeded(), ne(variables['SetDevVersion'], 'true'), ne(variables['Skip.Release'], 'true'), ne(variables['Build.Repository.Name'], 'Azure/azure-sdk-for-net-pr'))
         jobs:
-          - job: InstallationCheck
-            condition: ne('${{ artifact.skipPublishPackage }}', 'true')
-            displayName: "Installation Check"
-            steps:
-              - download: current
-                artifact: ${{parameters.ArtifactName}}-signed
-              - pwsh: mkdir InstallationCheck
-                displayName: Create Testing Directory
-              - pwsh: |
-                  $(System.DefaultWorkingDirectory)/eng/scripts/InstallationCheck.ps1 -ArtifactsDirectory ${{parameters.ArtifactName}} -Artifact ${{artifact.name}} -PipelineWorkspace $(Pipeline.Workspace)
-                displayName: Verify Package Installation
-                workingDirectory: $(System.DefaultWorkingDirectory)/InstallationCheck
           - deployment: TagRepository
             displayName: "Create release tag"
             condition: ne(variables['Skip.TagRepository'], 'true')
@@ -69,6 +57,8 @@ stages:
                 deploy:
                   steps:
                     - checkout: self
+                    - download: current
+                      artifact: ${{parameters.ArtifactName}}-signed
                     - template: /eng/common/pipelines/templates/steps/retain-run.yml
                     - template: /eng/common/pipelines/templates/steps/set-test-pipeline-version.yml
                       parameters:
@@ -80,6 +70,15 @@ stages:
                         PackageName: ${{artifact.name}}
                         ServiceName: ${{parameters.ServiceDirectory}}
                         ForRelease: true
+                    - task: PowerShell@2
+                      inputs:
+                        filePath: $(System.DefaultWorkingDirectory)/eng/scripts/InstallationCheck.ps1
+                        pwsh: true
+                        arguments: >
+                          -ArtifactsDirectory "$(Pipeline.Workspace)/${{parameters.ArtifactName}}-signed"
+                          -Artifact ${{artifact.name}}
+                      condition: and(succeeded(),ne('${{ artifact.skipPublishPackage }}', 'true'))
+                      displayName: Verify Package Installation
                     - template: /eng/common/pipelines/templates/steps/create-tags-and-git-release.yml
                       parameters:
                         ArtifactLocation: $(Pipeline.Workspace)/${{parameters.ArtifactName}}-signed/${{artifact.name}}

eng/scripts/InstallationCheck.ps1

@@ -6,27 +6,36 @@ param (
     [string] $Artifact,
 
     [Parameter()]
-    [string] $PipelineWorkspace
+    [string] $RetryLimit = 30
 )
 
-Write-Host "dotnet new console"
-dotnet new console
-$localFeed = "$PipelineWorkspace/$ArtifactsDirectory-signed/$Artifact"
-Write-Host "dotnet nuget add source $localFeed"
-dotnet nuget add source $localFeed
+mkdir InstallationCheck
+cd "InstallationCheck"
+
+Write-Host "dotnet new console --no-restore"
+dotnet new console --no-restore
+$localFeed = "$ArtifactsDirectory/$Artifact"
+
+$version = (Get-Content "$ArtifactsDirectory/PackageInfo/$Artifact.json" | ConvertFrom-Json).Version
 
-$version = (Get-ChildItem "$localFeed/*.nupkg" -Exclude "*.symbols.nupkg" -Name).replace(".nupkg","").replace("$Artifact.","")
 Write-Host "dotnet add package $Artifact --version $version --no-restore"
 dotnet add package $Artifact --version $version --no-restore
 if ($LASTEXITCODE) {
-    exit $LASTEXITCODE
+  exit $LASTEXITCODE
 }
 
-Write-Host "dotnet nuget locals all --clear"
-dotnet nuget locals all --clear
-
-Write-Host "dotnet restore -s https://api.nuget.org/v3/index.json -s $localFeed --no-cache --verbosity detailed"
-dotnet restore -s https://api.nuget.org/v3/index.json -s $localFeed --no-cache --verbosity detailed
-if ($LASTEXITCODE) {
-    exit $LASTEXITCODE
-}
+while ($retries++ -lt $RetryLimit) {
+  Write-Host "dotnet restore -s https://api.nuget.org/v3/index.json -s $localFeed --no-cache --verbosity detailed"
+  dotnet restore -s https://api.nuget.org/v3/index.json -s $localFeed --no-cache --verbosity detailed
+  if ($LASTEXITCODE) {
+    if ($retries -ge $RetryLimit) {
+      exit $LASTEXITCODE
+    }
+    Write-Host "dotnet clean"
+    dotnet clean
+    Write-Host "Restore failed, retrying in 1 minute..."
+    sleep 60
+  } else {
+    break
+  }
+}