Skip to content

Commit 19588fd

Browse files
authored
Removes Newtonsoft assembly targetting. Fixes flaky integration test. (Azure#15528)
* Removes Newtonsoft assembly targetting. Fixes flaky integration test. * minor
1 parent 7225f69 commit 19588fd

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

sdk/batch/Microsoft.Azure.Batch/src/app.config

Lines changed: 0 additions & 11 deletions
This file was deleted.

sdk/batch/Microsoft.Azure.Batch/tests/IntegrationTests/AddTaskCollectionIntegrationTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -467,7 +467,7 @@ await SynchronizationContextHelper.RunTestAsync(async () =>
467467
batchCli,
468468
testName,
469469
311,
470-
timeout: TimeSpan.FromSeconds(1),
470+
timeout: TimeSpan.FromSeconds(-1),
471471
useJobOperations: useJobOperations).ConfigureAwait(false)).ConfigureAwait(false);
472472

473473
Assert.IsType<TimeoutException>(exception.InnerException);

sdk/batch/Microsoft.Azure.Batch/tests/UnitTests/ComputeNodeUnitTests.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ public void TestComputeNodeCertificateReferencesAreReadOnly()
5353
CertificateReference computeNodeCertificateReference = computeNode.CertificateReferences.First();
5454

5555
// reads are allowed
56-
this.testOutputHelper.WriteLine("{0}", computeNodeCertificateReference.StoreLocation);
57-
this.testOutputHelper.WriteLine("{0}", computeNodeCertificateReference.StoreName);
58-
this.testOutputHelper.WriteLine("{0}", computeNodeCertificateReference.Thumbprint);
59-
this.testOutputHelper.WriteLine("{0}", computeNodeCertificateReference.ThumbprintAlgorithm);
60-
this.testOutputHelper.WriteLine("{0}", computeNodeCertificateReference.Visibility);
56+
this.testOutputHelper.WriteLine(computeNodeCertificateReference.StoreLocation.ToString());
57+
this.testOutputHelper.WriteLine(computeNodeCertificateReference.StoreName);
58+
this.testOutputHelper.WriteLine(computeNodeCertificateReference.Thumbprint);
59+
this.testOutputHelper.WriteLine(computeNodeCertificateReference.ThumbprintAlgorithm);
60+
this.testOutputHelper.WriteLine(computeNodeCertificateReference.Visibility.ToString());
6161

6262
// writes are foribdden
6363
Assert.Throws<InvalidOperationException>(() => { computeNodeCertificateReference.StoreLocation = CertStoreLocation.CurrentUser; });

0 commit comments

Comments
 (0)