Skip to content

Commit 0f869ce

Browse files
authored
Address cspell issues for Synapse (Azure#25689)
* address cspell issues for Synapse * rename nbformat * nits * fix spelling issues * fix
1 parent ac7e23a commit 0f869ce

File tree

7 files changed

+70
-23
lines changed

7 files changed

+70
-23
lines changed

.vscode/cspell.json

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"sdk/objectanchors/*/api/*.cs",
4444
"sdk/purview/*/api/*.cs",
4545
"sdk/remoterendering/*/api/*.cs",
46-
"sdk/synapse/*/api/*.cs",
4746
"sdk/videoanalyzer/*/api/*.cs"
4847
],
4948
// cspell is not case sensitive
@@ -235,6 +234,35 @@
235234
"Undelete"
236235
]
237236
},
237+
{
238+
"filename": "**/sdk/synapse/**/*.cs",
239+
"words": [
240+
"adla",
241+
"adls",
242+
"byoa",
243+
"distcp",
244+
"eloqua",
245+
"exfiltration",
246+
"fqdns",
247+
"hana",
248+
"hcatalog",
249+
"hdfs",
250+
"informix",
251+
"magento",
252+
"netezza",
253+
"oozie",
254+
"responsys",
255+
"sasl",
256+
"ssis",
257+
"ssisdb",
258+
"sybase",
259+
"sybase",
260+
"teradata",
261+
"usql",
262+
"vertica",
263+
"xero"
264+
]
265+
},
238266
{
239267
"filename": "**/sdk/synapse/**/*.md",
240268
"words": [

sdk/synapse/Azure.Analytics.Synapse.Artifacts/api/Azure.Analytics.Synapse.Artifacts.netstandard2.0.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4516,15 +4516,15 @@ public NetezzaTableDataset(Azure.Analytics.Synapse.Artifacts.Models.LinkedServic
45164516
}
45174517
public partial class Notebook
45184518
{
4519-
public Notebook(Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata metadata, int nbformat, int nbformatMinor, System.Collections.Generic.IEnumerable<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> cells) { }
4519+
public Notebook(Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata metadata, int notebookFormat, int notebookFormatMinor, System.Collections.Generic.IEnumerable<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> cells) { }
45204520
public System.Collections.Generic.IDictionary<string, object> AdditionalProperties { get { throw null; } }
45214521
public Azure.Analytics.Synapse.Artifacts.Models.BigDataPoolReference BigDataPool { get { throw null; } set { } }
45224522
public System.Collections.Generic.IList<Azure.Analytics.Synapse.Artifacts.Models.NotebookCell> Cells { get { throw null; } }
45234523
public string Description { get { throw null; } set { } }
45244524
public Azure.Analytics.Synapse.Artifacts.Models.NotebookFolder Folder { get { throw null; } set { } }
45254525
public Azure.Analytics.Synapse.Artifacts.Models.NotebookMetadata Metadata { get { throw null; } set { } }
4526-
public int Nbformat { get { throw null; } set { } }
4527-
public int NbformatMinor { get { throw null; } set { } }
4526+
public int NotebookFormat { get { throw null; } set { } }
4527+
public int NotebookFormatMinor { get { throw null; } set { } }
45284528
public Azure.Analytics.Synapse.Artifacts.Models.NotebookSessionProperties SessionProperties { get { throw null; } set { } }
45294529
}
45304530
public partial class NotebookCell
@@ -7132,7 +7132,7 @@ internal TriggerRunsQueryResponse() { }
71327132
private readonly int _dummyPrimitive;
71337133
public TriggerRunStatus(string value) { throw null; }
71347134
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Failed { get { throw null; } }
7135-
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Inprogress { get { throw null; } }
7135+
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus InProgress { get { throw null; } }
71367136
public static Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus Succeeded { get { throw null; } }
71377137
public bool Equals(Azure.Analytics.Synapse.Artifacts.Models.TriggerRunStatus other) { throw null; }
71387138
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]

sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/Notebook.Serialization.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/Notebook.cs

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/Generated/Models/TriggerRunStatus.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/synapse/Azure.Analytics.Synapse.Artifacts/src/autorest.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,3 +103,22 @@ directive:
103103
}
104104
}
105105
```
106+
107+
### Fix spelling issues
108+
109+
``` yaml
110+
directive:
111+
from: swagger-document
112+
where: $.definitions.Notebook.properties
113+
transform: >
114+
$.nbformat['x-ms-client-name'] = 'NotebookFormat';
115+
$.nbformat_minor['x-ms-client-name'] = 'NotebookFormatMinor';
116+
```
117+
118+
``` yaml
119+
directive:
120+
from: swagger-document
121+
where: $.definitions.TriggerRun.properties
122+
transform: >
123+
$.status["x-ms-enum"].values = [{value: "Succeeded", name: "Succeeded" },{value: "Failed", name: "Failed" },{value: "Inprogress", name: "InProgress" }];
124+
```

sdk/synapse/Azure.Analytics.Synapse.Artifacts/tests/NotebookClientLiveTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ public static async ValueTask<NotebookResource> CreateResource (NotebookClient c
4343

4444
Notebook notebook = new Notebook (
4545
new NotebookMetadata { LanguageInfo = new NotebookLanguageInfo(name: "Python") },
46-
nbformat: 4,
47-
nbformatMinor: 2,
46+
notebookFormat: 4,
47+
notebookFormatMinor: 2,
4848
new List<NotebookCell>()
4949
);
5050
NotebookCreateOrUpdateNotebookOperation createOperation = await client.StartCreateOrUpdateNotebookAsync(name, new NotebookResource(name, notebook));

0 commit comments

Comments
 (0)