[TSI] Refactor main and sample readme (Azure#21432)

Author: bikamani

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/README.md

@@ -1,8 +1,10 @@
-# Azure IoT Time Series Insights client library for .NET
+# Azure Time Series Insights client library for .NET
 
-This library provides access to the Azure Time Series Insights service.
+Azure Time Series Insights provides data exploration and telemetry tools to help you improve operational analysis. It's a fully managed analytics, storage, and visualization service where you can explore and analyze billions of Internet of Things (IoT) events simultaneously.
 
-  [Source code](https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/timeseriesinsights)
+Azure Time Series Insights gives you a global view of your data, so you can quickly validate your IoT solution and avoid costly downtime to mission-critical devices. It can help you discover hidden trends, spot anomalies, and conduct root-cause analysis in near real time.
+
+If you are new to Azure Time Series Insights and would like to learn more about the platform, please make sure you check out the Azure Time Series Insights official [documentation page][tsi_product_documentation].
 
 ## Getting started
 
@@ -25,13 +27,14 @@ In order to interact with the Azure Time Series Insights service, you will need
 
 ## Key concepts
 
-The main concepts of Time Series Insights client include:
+The Time Series Insights client library for .NET provides the following functionality:
+- Retrieving and being able to make changes to the Time Series Insights environment model settings, such as changing the model name or default type ID.
+- Retrieving and being able to add, update and remove Time Series instances.
+- Retrieving and being able to make changes to the Time Series Insights environment types, such as creating, updating and deleting Time Series types.
+- Retrieving and being able to make changes to the Time Series Insights hierarchies, such as creating, updating and deleting Time Series hierarchies.
+- Querying raw events, computed series and aggregate series.
 
-- Instances client: To perform operations such as creating, listing, replacing and deleting Time Series instances.
-- Types client: To perform operations such as creating, listing, replacing and deleting Time Series types.
-- Hierarchies client: To perform operations such as creating, listing, replacing and deleting Time Series hierarchies.
-- Model Settings client: To perform operations such as getting and updating Time Series Model configuration settings.
-- Query client: To query for events, series and aggregate series on Time Series Insights.
+[Source Code][tsi_client_src] | [Package (NuGet)][tsi_nuget] | [Product documentation][tsi_product_documentation] | [Samples][tsi_samples]
 
 ### Thread safety
 We guarantee that all client instance methods are thread-safe and independent of each other ([guideline](https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-service-methods-thread-safety)). This ensures that reusing client instances is always safe, even across threads.
@@ -49,7 +52,7 @@ We guarantee that all client instance methods are thread-safe and independent of
 
 ## Examples
 
-You can familiarize yourself with different APIs using [samples for Time Series Insights](https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples).
+You can familiarize yourself with different APIs using [samples for Time Series Insights][tsi_samples].
 
 ## Source code folder structure
 
@@ -146,3 +149,6 @@ For more information see the Code of Conduct FAQ or contact opencode@microsoft.c
 [iot_cli_doc]: https://docs.microsoft.com/cli/azure/ext/azure-iot/dt?view=azure-cli-latest
 [http_status_code]: https://docs.microsoft.com/dotnet/api/system.net.httpstatuscode?view=netcore-3.1
 [tsi_nuget]: https://www.nuget.org/packages/Azure.IoT.TimeSeriesInsights
+[tsi_client_src]: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/src
+[tsi_product_documentation]: https://docs.microsoft.com/azure/time-series-insights/
+[tsi_samples]: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/Readme.md

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/Readme.md

@@ -1,25 +1,5 @@
 # Introduction
 
-Azure Time Series Insights provides data exploration and telemetry tools to help you improve operational analysis. It's a fully managed analytics, storage, and visualization service where you can explore and analyze billions of Internet of Things (IoT) events simultaneously.
-
-Azure Time Series Insights gives you a global view of your data, so you can quickly validate your IoT solution and avoid costly downtime to mission-critical devices. It can help you discover hidden trends, spot anomalies, and conduct root-cause analysis in near real time.
-
-If you are new to Azure Time Series Insights and would like to learn more about the platform, please make sure you check out the Azure Time Series Insights official [documentation page][tsi_product_documentation].
-
-# Time Series Insights client library for .NET
-The Time Series Insights client library for .NET provides the following functionality:
-- Retrieving and being able to make changes to the Time Series Insights environment model settings, such as changing the model name or default type ID.
-- Retrieving and being able to add, update and remove Time Series instances.
-- Retrieving and being able to make changes to the Time Series Insights environment types, such as creating, updating and deleting Time Series types.
-- Retrieving and being able to make changes to the Time Series Insights hierarchies, such as creating, updating and deleting Time Series hierarchies.
-- Querying raw events, computed series and aggregate series
-
-[Source Code][tsi_client_src] | [Package (NuGet)][tsi_nuget_package] | [Product documentation][tsi_product_documentation] | [Samples][tsi_samples]
-
-# Key concepts
-
-## TimeSeriesInsightsClient
-
 A `TimeSeriesInsightsClient` is the primary interface for developers using the Time Series Insights client library. It provides both synchronous and asynchronous operations to perform operations on a Time Series Insights environment. The `TimeSeriesInsightsClient` exposes several properties that a developer will use to perform specific operations on a Time Series Insights environment. For example, `ModelSettings` is the property that a developer can use to perform operations on the model settings of the TSI environment. `Instances` can be used to perform operations on TSI instances. Other properties include `Types`, `Hierarchies` and `Query`.
 
 ## Creating TimeSeriesInsightsClient
@@ -62,7 +42,7 @@ A single Time Series ID value is composed of up to 3 string values that uniquely
 var instanceId =  new TimeSeriesId("Millennium", "Floor2", "2A01");
 ```
 
-> **Please note that this sample is set up to work best when the Time Series Insights ID key that is configured with your environment is not one of the default telemetry system properties, such as iothub-connection-device-id. The reason being is that this sample will generate random unique strings for each TSI ID key that you have set up for your TSI environment, and use these randomly generated strings when sending telemetry to IoT Hub. But since the iothub-connection-device-id is already a random identifier for a device, setting up your TSI environment with ID key as iothub-connection-device-id will not make the sample run as expected. For this sample to mimic a more realistic TSI environment, use Building, Floor and Room as properties for your Time Series Insights IDs.**
+> **Please note that this sample is set up to work best when the Time Series Insights ID key that is configured with your environment is not one of the default telemetry system properties, such as iothub-connection-device-id. The reason being is that this sample will generate random unique strings for each TSI ID key that you have set up for your TSI environment, and use these randomly generated strings when sending telemetry to IoT Hub. But since the iothub-connection-device-id is already a random identifier for a device, setting up your TSI environment with ID key as iothub-connection-device-id will not make the sample run as expected since TSI will create an instance per device. For this sample to mimic a more realistic TSI environment, use Building, Floor and Room as properties for your Time Series Insights IDs.**
 
 ## Time Series Insights Model Settings
 
@@ -706,10 +686,6 @@ await foreach (TimeSeriesPoint point in query.GetResultsAsync())
 ```
 
 <!-- LINKS -->
-[tsi_client_src]: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/src
-[tsi_nuget_package]: https://www.bing.com
-[tsi_product_documentation]: https://docs.microsoft.com/azure/time-series-insights/
-[tsi_samples]: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/Readme.md
 [DefaultAzureCredential]: https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/identity/Azure.Identity/README.md
 [tsi_instances_learn_more]: https://docs.microsoft.com/azure/time-series-insights/concepts-model-overview#time-series-model-instances
 [tsi_id_learn_more]: https://docs.microsoft.com/azure/time-series-insights/how-to-select-tsid

sdk/timeseriesinsights/Azure.IoT.TimeSeriesInsights/samples/TimeSeriesInsightsClientSample/QuerySamples.cs

@@ -4,11 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Text.Json;
-using System.Threading;
 using System.Threading.Tasks;
-using Microsoft.Azure.Devices.Client;
 using static Azure.IoT.TimeSeriesInsights.Samples.SampleLogger;
 
 namespace Azure.IoT.TimeSeriesInsights.Samples