Commit 0cdd118
authored
Avoid exception when setting the network stream timeout (Azure#17791)
Fixes: Azure#17781
Also avoids an annoying exception that shows up in VS Debug Output windows constantly.
Before (using `dotnet run -c Release -f netcoreapp2.1 -- Download -s 10000`):
```
=== Test ===
Current Total
3206 3206
3354 6560
3291 9851
3323 13174
3371 16545
3434 19979
3563 23542
3677 27219
3323 30542
3265 33807
=== Results ===
Completed 33807 operations in a weighted-average of 10.01s (3,378.15 ops/s, 0.000 s/op)
```
After:
```
=== Test ===
Current Total
4182 4182
4169 8351
4153 12504
4268 16772
4246 21018
4158 25176
4195 29371
4199 33570
4270 37840
3851 41691
=== Results ===
Completed 41691 operations in a weighted-average of 10.02s (4,160.27 ops/s, 0.000 s/op)
```
**Azure.Core 1.0.2**
```
=== Test ===
Current Total
4215 4215
4265 8480
4105 12585
4679 17264
4376 21640
4385 26025
4132 30157
4518 34675
4575 39250
3728 42978
=== Results ===
Completed 42978 operations in a weighted-average of 10.00s (4,296.94 ops/s, 0.000 s/op)
```1 parent 11ab9fe commit 0cdd118
File tree
6 files changed
+17
-8
lines changed- sdk/core/Azure.Core
- perf
- src/Pipeline/Internal
- tests
6 files changed
+17
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
9 | 12 | | |
10 | | - | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | 9 | | |
12 | 10 | | |
13 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| 7 | + | |
8 | 8 | | |
9 | | - | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
| |||
21 | 20 | | |
22 | 21 | | |
23 | 22 | | |
24 | | - | |
| 23 | + | |
25 | 24 | | |
26 | 25 | | |
27 | 26 | | |
| |||
48 | 47 | | |
49 | 48 | | |
50 | 49 | | |
| 50 | + | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
141 | | - | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
142 | 145 | | |
143 | 146 | | |
144 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| 204 | + | |
| 205 | + | |
204 | 206 | | |
205 | 207 | | |
206 | 208 | | |
| |||
0 commit comments