[Storage] DataLakeFileClient RequestConditions validation (Azure#22150)

Author: seanmcc-msft

sdk/storage/Azure.Storage.Files.DataLake/src/Azure.Storage.Files.DataLake.csproj

@@ -27,6 +27,7 @@
     <ProjectReference Include="..\..\Azure.Storage.Blobs\src\Azure.Storage.Blobs.csproj" />
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="$(AzureCoreSharedSources)AppContextSwitchHelper.cs" LinkBase="SharedCore" />
     <Compile Include="$(AzureCoreSharedSources)AuthorizationChallengeParser.cs" LinkBase="Shared\Core" />
     <Compile Include="$(AzureCoreSharedSources)AzureResourceProviderNamespaceAttribute.cs" LinkBase="SharedCore" />
     <Compile Include="$(AzureCoreSharedSources)AzureSasCredentialSynchronousPolicy.cs" LinkBase="SharedCore" />

sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeExtensions.cs

@@ -831,5 +831,133 @@ internal static BlobStaticWebsite ToBlobStaticWebsite(this DataLakeStaticWebsite
                 DefaultIndexDocumentPath = dataLakeStaticWebsite.DefaultIndexDocumentPath
             };
         }
+
+        #region ValidateConditionsNotPresent
+        internal static void ValidateConditionsNotPresent(
+            this RequestConditions requestConditions,
+            DataLakeRequestConditionProperty invalidConditions,
+            string operationName,
+            string parameterName)
+        {
+            if (AppContextSwitchHelper.GetConfigValue(
+                Constants.DisableRequestConditionsValidationSwitchName,
+                Constants.DisableRequestConditionsValidationEnvVar))
+            {
+                return;
+            }
+
+            if (requestConditions == null)
+            {
+                return;
+            }
+
+            List<string> invalidList = null;
+            requestConditions.ValidateConditionsNotPresent(
+                invalidConditions,
+                ref invalidList);
+
+            if (invalidList?.Count > 0)
+            {
+                string unsupportedString = string.Join(", ", invalidList);
+                throw new ArgumentException(
+                    $"{operationName} does not support the {unsupportedString} condition(s).",
+                    parameterName);
+            }
+        }
+
+        internal static void ValidateConditionsNotPresent(
+            this DataLakeRequestConditions requestConditions,
+            DataLakeRequestConditionProperty invalidConditions,
+            string operationName,
+            string parameterName)
+        {
+            if (AppContextSwitchHelper.GetConfigValue(
+                Constants.DisableRequestConditionsValidationSwitchName,
+                Constants.DisableRequestConditionsValidationEnvVar))
+            {
+                return;
+            }
+
+            if (requestConditions == null)
+            {
+                return;
+            }
+
+            List<string> invalidList = null;
+            requestConditions.ValidateConditionsNotPresent(
+                invalidConditions,
+                ref invalidList);
+
+            if (invalidList?.Count > 0)
+            {
+                string unsupportedString = string.Join(", ", invalidList);
+                throw new ArgumentException(
+                    $"{operationName} does not support the {unsupportedString} condition(s).",
+                    parameterName);
+            }
+        }
+
+        internal static void ValidateConditionsNotPresent(
+            this RequestConditions requestConditions,
+            DataLakeRequestConditionProperty invalidConditions,
+            ref List<string> invalidList)
+        {
+            if (requestConditions == null)
+            {
+                return;
+            }
+
+            if ((invalidConditions & DataLakeRequestConditionProperty.IfModifiedSince) == DataLakeRequestConditionProperty.IfModifiedSince
+                && requestConditions.IfModifiedSince != null)
+            {
+                invalidList ??= new List<string>();
+                invalidList.Add(nameof(BlobRequestConditions.IfModifiedSince));
+            }
+
+            if ((invalidConditions & DataLakeRequestConditionProperty.IfUnmodifiedSince) == DataLakeRequestConditionProperty.IfUnmodifiedSince
+                && requestConditions.IfUnmodifiedSince != null)
+            {
+                invalidList ??= new List<string>();
+                invalidList.Add(nameof(BlobRequestConditions.IfUnmodifiedSince));
+            }
+
+            if ((invalidConditions & DataLakeRequestConditionProperty.IfMatch) == DataLakeRequestConditionProperty.IfMatch
+                && requestConditions.IfMatch != null)
+            {
+                invalidList ??= new List<string>();
+                invalidList.Add(nameof(BlobRequestConditions.IfMatch));
+            }
+
+            if ((invalidConditions & DataLakeRequestConditionProperty.IfNoneMatch) == DataLakeRequestConditionProperty.IfNoneMatch
+                && requestConditions.IfNoneMatch != null)
+            {
+                invalidList ??= new List<string>();
+                invalidList.Add(nameof(BlobRequestConditions.IfNoneMatch));
+            }
+        }
+
+        internal static void ValidateConditionsNotPresent(
+            this DataLakeRequestConditions requestConditions,
+            DataLakeRequestConditionProperty invalidConditions,
+            ref List<string> invalidList)
+        {
+            if (requestConditions == null)
+            {
+                return;
+            }
+
+            // Validate RequestConditions
+            ((RequestConditions)requestConditions).ValidateConditionsNotPresent(
+                invalidConditions, ref invalidList);
+
+            // Validate BlobRequestConditions specific conditions.
+            if ((invalidConditions & DataLakeRequestConditionProperty.LeaseId) == DataLakeRequestConditionProperty.LeaseId
+                && requestConditions.LeaseId != null)
+            {
+                invalidList ??= new List<string>();
+                invalidList.Add(nameof(BlobRequestConditions.LeaseId));
+            }
+        }
+        #endregion
     }
 }

sdk/storage/Azure.Storage.Files.DataLake/src/DataLakeFileSystemClient.cs

@@ -865,6 +865,14 @@ public virtual Response Delete(
         {
             DiagnosticScope scope = ClientConfiguration.ClientDiagnostics.CreateScope($"{nameof(DataLakeFileSystemClient)}.{nameof(Delete)}");
 
+            conditions.ValidateConditionsNotPresent(
+                invalidConditions:
+                    DataLakeRequestConditionProperty.TagConditions
+                    | DataLakeRequestConditionProperty.IfMatch
+                    | DataLakeRequestConditionProperty.IfNoneMatch,
+                operationName: nameof(DataLakeFileClient.Delete),
+                parameterName: nameof(conditions));
+
             try
             {
                 scope.Start();
@@ -914,6 +922,14 @@ public virtual async Task<Response> DeleteAsync(
         {
             DiagnosticScope scope = ClientConfiguration.ClientDiagnostics.CreateScope($"{nameof(DataLakeFileSystemClient)}.{nameof(Delete)}");
 
+            conditions.ValidateConditionsNotPresent(
+                invalidConditions:
+                    DataLakeRequestConditionProperty.TagConditions
+                    | DataLakeRequestConditionProperty.IfMatch
+                    | DataLakeRequestConditionProperty.IfNoneMatch,
+                operationName: nameof(DataLakeFileClient.Delete),
+                parameterName: nameof(conditions));
+
             try
             {
                 scope.Start();
@@ -966,6 +982,14 @@ public virtual Response<bool> DeleteIfExists(
         {
             DiagnosticScope scope = ClientConfiguration.ClientDiagnostics.CreateScope($"{nameof(DataLakeFileSystemClient)}.{nameof(DeleteIfExists)}");
 
+            conditions.ValidateConditionsNotPresent(
+                invalidConditions:
+                    DataLakeRequestConditionProperty.TagConditions
+                    | DataLakeRequestConditionProperty.IfMatch
+                    | DataLakeRequestConditionProperty.IfNoneMatch,
+                operationName: nameof(DataLakeFileClient.Delete),
+                parameterName: nameof(conditions));
+
             try
             {
                 scope.Start();

sdk/storage/Azure.Storage.Files.DataLake/src/Models/Internal/DataLakeRequestConditionProperty.cs

@@ -0,0 +1,19 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System;
+
+namespace Azure.Storage.Files.DataLake.Models
+{
+    [Flags]
+    internal enum DataLakeRequestConditionProperty
+    {
+        None = 0,
+        LeaseId = 1,
+        TagConditions = 2,
+        IfModifiedSince = 4,
+        IfUnmodifiedSince = 8,
+        IfMatch = 16,
+        IfNoneMatch = 32,
+    }
+}