[Service Bus] Fix linting problems in test files (Azure#13892)

This PR fixes about 150 linter errors and warnings in the test files of the Service Bus package.
Use `Hide whitespace changes" option to look at the real impacting changes
Related to Azure#10781

Author: ramya-rao-a

sdk/servicebus/service-bus/test/internal/batchReceiver.spec.ts

@@ -31,7 +31,7 @@ describe("Operation Options", () => {
   // This describe block ensures that abort signal works as expected and
   // the OperationOptions are plugged in for all the methods
   describe("Abort Signal", () => {
-    async function verifyAbortError(func: Function): Promise<void> {
+    async function verifyAbortError(func: () => Promise<any>): Promise<void> {
       try {
         await func();
         assert.fail();

sdk/servicebus/service-bus/test/internal/operationOptionsForATOM.spec.ts

@@ -81,7 +81,7 @@ describe("Message Lock Renewal", () => {
       await checkWithTimeout(
         async () => {
           [peekedMsg] = await receiver.peekMessages(1);
-          return peekedMsg != undefined;
+          return peekedMsg !== undefined;
         },
         100,
         5000

sdk/servicebus/service-bus/test/internal/renewLock.spec.ts

@@ -57,7 +57,7 @@ describe("Retries - ManagementClient", () => {
   }
 
   function mockManagementClientToThrowError(): void {
-    const fakeFunction = async function() {
+    const fakeFunction = async function(): Promise<never> {
       numberOfTimesManagementClientInvoked++;
       throw new MessagingError("Hello there, I'm an error");
     };
@@ -72,7 +72,7 @@ describe("Retries - ManagementClient", () => {
     receiverMgmtClient["_makeManagementRequest"] = fakeFunction;
   }
 
-  async function mockManagementClientAndVerifyRetries(func: Function): Promise<void> {
+  async function mockManagementClientAndVerifyRetries(func: () => Promise<void>): Promise<void> {
     mockManagementClientToThrowError();
     let errorThrown = false;
     try {
@@ -235,7 +235,7 @@ describe("Retries - MessageSender", () => {
     (sender as ServiceBusSenderImpl)["_sender"]["open"] = fakeFunction;
   }
 
-  async function mockInitAndVerifyRetries(func: Function): Promise<void> {
+  async function mockInitAndVerifyRetries(func: () => Promise<void>): Promise<void> {
     mockInitToThrowError();
     let errorThrown = false;
     try {
@@ -338,7 +338,7 @@ describe("Retries - Receive methods", () => {
   }
 
   function mockBatchingReceiveToThrowError(): void {
-    const fakeFunction = async function() {
+    const fakeFunction = async function(): Promise<never> {
       numberOfTimesTried++;
       throw new MessagingError("Hello there, I'm an error");
     };
@@ -362,7 +362,7 @@ describe("Retries - Receive methods", () => {
     }
   }
 
-  async function mockReceiveAndVerifyRetries(func: Function): Promise<void> {
+  async function mockReceiveAndVerifyRetries(func: () => Promise<void>): Promise<void> {
     mockBatchingReceiveToThrowError();
     let errorThrown = false;
     try {

sdk/servicebus/service-bus/test/internal/retries.spec.ts

@@ -588,7 +588,9 @@ describe("ServiceBusClient live tests", () => {
       let errorReceiveStream: string = "";
       try {
         receiver.subscribe({
-          async processMessage() {},
+          async processMessage() {
+            /** Nothing to do here */
+          },
           async processError(e) {
             console.log(e);
           }
@@ -837,7 +839,7 @@ describe("ServiceBusClient live tests", () => {
   });
 });
 
-function reduceRetries(receiver: ServiceBusReceiver) {
+function reduceRetries(receiver: ServiceBusReceiver): void {
   // for some tests the important thing is just to run a single retry cycle (and then report)
   // the error. This reduces everything so we run a short retry cycle.
   //

sdk/servicebus/service-bus/test/internal/serviceBusClient.spec.ts

@@ -167,7 +167,7 @@ describe("Streaming Receiver Tests", () => {
         body: "can stop and start a subscription message 1"
       });
 
-      const { subscription, msg: receivedMsg } = await new Promise<{
+      const { subscription: subscription1, msg: receivedMsg } = await new Promise<{
         subscription: { close(): Promise<void> };
         msg: string;
       }>((resolve, reject) => {
@@ -182,7 +182,7 @@ describe("Streaming Receiver Tests", () => {
       });
 
       receivedMsg.should.equal("can stop and start a subscription message 1");
-      await subscription.close();
+      await subscription1.close();
 
       await sender2.sendMessages({
         body: "can stop and start a subscription message 2"
@@ -982,7 +982,7 @@ export function createOnDetachedProcessErrorFake(): sinon.SinonSpy & {
     assertErrors: () => void;
   };
 
-  const assertErrors = () => {
+  const assertErrors = (): void => {
     const errors: string[] = [];
 
     for (const callArgs of processErrorFake.args) {

sdk/servicebus/service-bus/test/internal/streamingReceiver.spec.ts

@@ -172,7 +172,6 @@ describe("Streaming with sessions", () => {
             "MessageId is different than expected"
           );
           return Promise.resolve();
-          ``;
         },
         processError
       });
@@ -295,12 +294,11 @@ describe("Streaming with sessions", () => {
       receiver.subscribe(
         {
           async processMessage(msg: ServiceBusReceivedMessage) {
-            return receiver.abandonMessage(msg).then(() => {
+            return receiver.abandonMessage(msg).then(async () => {
               abandonFlag = 1;
               if ((receiver as ServiceBusSessionReceiverImpl)["_isReceivingMessages"]()) {
                 return receiver.close();
               }
-              return Promise.resolve();
             });
           },
           processError

sdk/servicebus/service-bus/test/internal/streamingReceiverSessions.spec.ts

@@ -205,7 +205,9 @@ describe("AbortSignal", () => {
 
       const sender = new MessageSender(
         createConnectionContextForTests({
-          onCreateAwaitableSenderCalled: () => {}
+          onCreateAwaitableSenderCalled: () => {
+            /** Nothing to do here */
+          }
         }),
         "fakeEntityPath",
         {}
@@ -242,7 +244,9 @@ describe("AbortSignal", () => {
       );
       closeables.push(sender);
 
-      sender["_negotiateClaim"] = async () => {};
+      sender["_negotiateClaim"] = async () => {
+        /** Nothing to do here */
+      };
 
       try {
         await sender.createBatch({ abortSignal: taggedAbortSignal });
@@ -316,7 +320,9 @@ describe("AbortSignal", () => {
       const messageReceiver = new StreamingReceiver(fakeContext, "fakeEntityPath", defaultOptions);
       closeables.push(messageReceiver);
 
-      messageReceiver["_negotiateClaim"] = async () => {};
+      messageReceiver["_negotiateClaim"] = async () => {
+        /** Nothing to do here */
+      };
 
       try {
         await messageReceiver["_init"]({} as ReceiverOptions, abortSignal);
@@ -354,7 +360,9 @@ describe("AbortSignal", () => {
 
         session.subscribe(
           {
-            processMessage: async (_msg) => {},
+            processMessage: async (_msg) => {
+              /** Nothing to do here */
+            },
             processError: async (args) => {
               receivedErrors.push(args.error);
             }
@@ -386,7 +394,9 @@ describe("AbortSignal", () => {
         await new Promise<void>((resolve) => {
           receiver.subscribe(
             {
-              processMessage: async (_msg: any) => {},
+              processMessage: async (_msg: any) => {
+                /** Nothing to do here */
+              },
               processError: async (args: ProcessErrorArgs) => {
                 resolve();
                 receivedErrors.push(args.error);

sdk/servicebus/service-bus/test/internal/unit/abortSignal.spec.ts

@@ -393,7 +393,7 @@ describe("ATOM Serializers", () => {
   }
 
   class MockSerializer implements AtomXmlSerializer {
-    serialize(resource: any): object {
+    serialize(resource: any): Record<string, unknown> {
       const property1 = "LockDuration";
       const property2 = "MaxSizeInMegabytes";
 

sdk/servicebus/service-bus/test/internal/unit/atomXml.spec.ts

@@ -51,7 +51,9 @@ describe("autoLockRenewer unit tests", () => {
     } as ManagementClient;
 
     renewLockSpy = sinon.spy(managementClient, "renewLock");
-    onErrorFake = sinon.fake(async (_err: Error | MessagingError) => {});
+    onErrorFake = sinon.fake(async (_err: Error | MessagingError) => {
+      /** Nothing to do here */
+    });
 
     autoLockRenewer = LockRenewer.create(
       {