Added default customDomainHttpsParameters value (Azure#11777)

Author: ChrisKlug

sdk/cdn/arm-cdn/package.json

@@ -2,7 +2,7 @@
   "name": "@azure/arm-cdn",
   "author": "Microsoft Corporation",
   "description": "CdnManagementClient Library with typescript type definitions for node.js and browser.",
-  "version": "5.0.0",
+  "version": "5.1.0",
   "dependencies": {
     "@azure/ms-rest-azure-js": "^2.0.1",
     "@azure/ms-rest-js": "^2.0.4",

sdk/cdn/arm-cdn/src/cdnManagementClientContext.ts

@@ -13,7 +13,7 @@ import * as msRest from "@azure/ms-rest-js";
 import * as msRestAzure from "@azure/ms-rest-azure-js";
 
 const packageName = "@azure/arm-cdn";
-const packageVersion = "5.0.0";
+const packageVersion = "5.1.0";
 
 export class CdnManagementClientContext extends msRestAzure.AzureServiceClient {
   credentials: msRest.ServiceClientCredentials;

sdk/cdn/arm-cdn/src/operations/customDomains.ts

@@ -14,6 +14,7 @@ import * as Models from "../models";
 import * as Mappers from "../models/customDomainsMappers";
 import * as Parameters from "../models/parameters";
 import { CdnManagementClientContext } from "../cdnManagementClientContext";
+import { Profiles } from "./profiles";
 
 /** Class representing a CustomDomains. */
 export class CustomDomains {
@@ -114,7 +115,7 @@ export class CustomDomains {
    * @returns Promise<Models.CustomDomainsCreateResponse>
    */
   create(resourceGroupName: string, profileName: string, endpointName: string, customDomainName: string, hostName: string, options?: msRest.RequestOptionsBase): Promise<Models.CustomDomainsCreateResponse> {
-    return this.beginCreate(resourceGroupName,profileName,endpointName,customDomainName,hostName,options)
+    return this.beginCreate(resourceGroupName, profileName, endpointName, customDomainName, hostName, options)
       .then(lroPoller => lroPoller.pollUntilFinished()) as Promise<Models.CustomDomainsCreateResponse>;
   }
 
@@ -128,7 +129,7 @@ export class CustomDomains {
    * @returns Promise<Models.CustomDomainsDeleteMethodResponse>
    */
   deleteMethod(resourceGroupName: string, profileName: string, endpointName: string, customDomainName: string, options?: msRest.RequestOptionsBase): Promise<Models.CustomDomainsDeleteMethodResponse> {
-    return this.beginDeleteMethod(resourceGroupName,profileName,endpointName,customDomainName,options)
+    return this.beginDeleteMethod(resourceGroupName, profileName, endpointName, customDomainName, options)
       .then(lroPoller => lroPoller.pollUntilFinished()) as Promise<Models.CustomDomainsDeleteMethodResponse>;
   }
 
@@ -200,16 +201,42 @@ export class CustomDomains {
    */
   enableCustomHttps(resourceGroupName: string, profileName: string, endpointName: string, customDomainName: string, options: Models.CustomDomainsEnableCustomHttpsOptionalParams, callback: msRest.ServiceCallback<Models.CustomDomain>): void;
   enableCustomHttps(resourceGroupName: string, profileName: string, endpointName: string, customDomainName: string, options?: Models.CustomDomainsEnableCustomHttpsOptionalParams | msRest.ServiceCallback<Models.CustomDomain>, callback?: msRest.ServiceCallback<Models.CustomDomain>): Promise<Models.CustomDomainsEnableCustomHttpsResponse> {
-    return this.client.sendOperationRequest(
-      {
-        resourceGroupName,
-        profileName,
-        endpointName,
-        customDomainName,
-        options
-      },
-      enableCustomHttpsOperationSpec,
-      callback) as Promise<Models.CustomDomainsEnableCustomHttpsResponse>;
+    // #region Added default values to add backwards compatibility
+    let newOptions: Models.CustomDomainsEnableCustomHttpsOptionalParams = {};
+
+    if (typeof options === "function") {
+      callback = options;
+    } else {
+      newOptions = options as Models.CustomDomainsEnableCustomHttpsOptionalParams;
+    }
+
+    if (!newOptions) {
+      newOptions = {};
+    }
+
+    let optionsPreparationPromise = Promise.resolve(options);
+
+    if (!newOptions.customDomainHttpsParameters) {
+      let profiles = new Profiles(this.client);
+      optionsPreparationPromise = profiles.get(resourceGroupName, profileName).then(profile => {
+        newOptions.customDomainHttpsParameters = getDefaultCustomDomainHttpsParameters(profile);
+        return newOptions;
+      })
+    }
+
+    return optionsPreparationPromise.then(options =>
+      this.client.sendOperationRequest(
+        {
+          resourceGroupName,
+          profileName,
+          endpointName,
+          customDomainName,
+          options
+        },
+        enableCustomHttpsOperationSpec,
+        callback) as Promise<Models.CustomDomainsEnableCustomHttpsResponse>
+    );
+    // #endregion
   }
 
   /**
@@ -287,6 +314,46 @@ export class CustomDomains {
   }
 }
 
+// #region Added default values to add backwards compatibility
+class SkuNames {
+  public static get standard_microsoft() { return "Standard_Microsoft"; }
+  public static get standard_verizon() { return "Standard_Verizon"; }
+  public static get standard_akamai() { return "Standard_Akamai"; }
+}
+
+function getDefaultCustomDomainHttpsParameters(profile: Models.Profile): Models.CdnManagedHttpsParameters | undefined {
+  switch (profile.sku.name) {
+    case SkuNames.standard_microsoft:
+      return {
+        certificateSource: "Cdn",
+        certificateSourceParameters: {
+          certificateType: "Dedicated"
+        },
+        protocolType: "ServerNameIndication"
+      }
+    case SkuNames.standard_akamai:
+      return {
+        certificateSource: "Cdn",
+        certificateSourceParameters: {
+          certificateType: "Shared"
+        },
+        protocolType: "ServerNameIndication"
+      }
+    case SkuNames.standard_verizon:
+      return {
+        certificateSource: "Cdn",
+        certificateSourceParameters: {
+          certificateType: "Shared"
+        },
+        protocolType: "IPBased"
+      }
+    default:
+      return undefined;
+  }
+}
+
+// #endregion
+
 // Operation Specifications
 const serializer = new msRest.Serializer(Mappers);
 const listByEndpointOperationSpec: msRest.OperationSpec = {