[Attestation] Migrate to core v2 (Azure#15504)

* [Attestation] Migrate to core v2

* revert swagger/README.md

* fix test failure

Author: deyaaeldeen

sdk/attestation/attestation/karma.conf.js

@@ -68,7 +68,7 @@ module.exports = function(config) {
       "ATTESTATION_ISOLATED_SIGNING_KEY",
       "AZURE_CLIENT_ID",
       "AZURE_CLIENT_SECRET",
-      "AZURE_TENANT_ID",
+      "AZURE_TENANT_ID"
     ],
 
     // test results reporter to use

sdk/attestation/attestation/package.json

@@ -5,7 +5,9 @@
   "description": "Describes the interface for the per-tenant enclave service.",
   "version": "1.0.0-beta.3",
   "dependencies": {
-    "@azure/core-http": "^1.2.0",
+    "@azure/core-auth": "^1.3.0",
+    "@azure/core-client": "^1.0.0",
+    "@azure/core-rest-pipeline": "^1.0.3",
     "@azure/core-tracing": "1.0.0-preview.11",
     "@azure/logger": "^1.0.0",
     "tslib": "^2.0.0",
@@ -89,7 +91,7 @@
     "clean": "rimraf dist dist-esm dist-test temp types *.tgz *.log",
     "execute:samples": "echo skipped",
     "extract-api": "api-extractor run --local",
-    "format": "echo skip format as this package has only auto generated code",
+    "format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
     "integration-test:browser": "karma start --single-run",
     "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 5000000 --full-trace \"dist-esm/test/{,!(browser)/**/}*.spec.js\"",
     "integration-test": "npm run integration-test:node && npm run integration-test:browser",

sdk/attestation/attestation/review/attestation.api.md

@@ -4,10 +4,11 @@
 
 ```ts
 
-import * as coreHttp from '@azure/core-http';
-import { OperationOptions } from '@azure/core-http';
-import { PipelineOptions } from '@azure/core-http';
-import { TokenCredential } from '@azure/core-http';
+import { CommonClientOptions } from '@azure/core-client';
+import * as coreAuth from '@azure/core-auth';
+import * as coreClient from '@azure/core-client';
+import { OperationOptions } from '@azure/core-client';
+import { TokenCredential } from '@azure/core-auth';
 
 // @public
 export class AttestationAdministrationClient {
@@ -24,16 +25,11 @@ export interface AttestationAdministrationClientOperationOptions extends Operati
 }
 
 // @public
-export interface AttestationAdministrationClientOptions extends PipelineOptions {
+export interface AttestationAdministrationClientOptions extends CommonClientOptions {
 }
 
 // @public
-export type AttestationAttestTpmResponse = TpmAttestationResponse & {
-    _response: coreHttp.HttpResponse & {
-        bodyAsText: string;
-        parsedBody: TpmAttestationResponse;
-    };
-};
+export type AttestationAttestTpmResponse = TpmAttestationResponse;
 
 // @public
 export interface AttestationCertificateManagementBody {
@@ -61,7 +57,7 @@ export interface AttestationClientOperationOptions extends OperationOptions {
 }
 
 // @public
-export interface AttestationClientOptions extends PipelineOptions {
+export interface AttestationClientOptions extends CommonClientOptions {
 }
 
 // @public
@@ -204,7 +200,7 @@ export type DataType = string;
 // @public (undocumented)
 export class GeneratedClient extends GeneratedClientContext {
     // Warning: (ae-forgotten-export) The symbol "GeneratedClientOptionalParams" needs to be exported by the entry point index.d.ts
-    constructor(credentials: coreHttp.TokenCredential | coreHttp.ServiceClientCredentials, instanceUrl: string, options?: GeneratedClientOptionalParams);
+    constructor(credentials: coreAuth.TokenCredential, instanceUrl: string, options?: GeneratedClientOptionalParams);
     // Warning: (ae-forgotten-export) The symbol "Attestation" needs to be exported by the entry point index.d.ts
     //
     // (undocumented)
@@ -228,8 +224,8 @@ export class GeneratedClient extends GeneratedClientContext {
 }
 
 // @public (undocumented)
-export class GeneratedClientContext extends coreHttp.ServiceClient {
-    constructor(credentials: coreHttp.TokenCredential | coreHttp.ServiceClientCredentials, instanceUrl: string, options?: GeneratedClientOptionalParams);
+export class GeneratedClientContext extends coreClient.ServiceClient {
+    constructor(credentials: coreAuth.TokenCredential, instanceUrl: string, options?: GeneratedClientOptionalParams);
     // (undocumented)
     apiVersion: string;
     // (undocumented)
@@ -294,26 +290,16 @@ export enum KnownPolicyModification {
 // @public
 export class PolicyCertificates {
     constructor(client: AttestationClient);
-    add(policyCertificateToAdd: string, options?: coreHttp.OperationOptions): Promise<PolicyCertificatesAddResponse>;
-    get(options?: coreHttp.OperationOptions): Promise<PolicyCertificatesGetResponse>;
-    remove(policyCertificateToRemove: string, options?: coreHttp.OperationOptions): Promise<PolicyCertificatesRemoveResponse>;
+    add(policyCertificateToAdd: string, options?: coreClient.OperationOptions): Promise<PolicyCertificatesAddResponse>;
+    get(options?: coreClient.OperationOptions): Promise<PolicyCertificatesGetResponse>;
+    remove(policyCertificateToRemove: string, options?: coreClient.OperationOptions): Promise<PolicyCertificatesRemoveResponse>;
 }
 
 // @public
-export type PolicyCertificatesAddResponse = PolicyCertificatesModifyResponse & {
-    _response: coreHttp.HttpResponse & {
-        bodyAsText: string;
-        parsedBody: PolicyCertificatesModifyResponse;
-    };
-};
+export type PolicyCertificatesAddResponse = PolicyCertificatesModifyResponse;
 
 // @public
-export type PolicyCertificatesGetResponse = PolicyCertificatesResponse & {
-    _response: coreHttp.HttpResponse & {
-        bodyAsText: string;
-        parsedBody: PolicyCertificatesResponse;
-    };
-};
+export type PolicyCertificatesGetResponse = PolicyCertificatesResponse;
 
 // @public
 export interface PolicyCertificatesModificationResult {
@@ -327,12 +313,7 @@ export interface PolicyCertificatesModifyResponse {
 }
 
 // @public
-export type PolicyCertificatesRemoveResponse = PolicyCertificatesModifyResponse & {
-    _response: coreHttp.HttpResponse & {
-        bodyAsText: string;
-        parsedBody: PolicyCertificatesModifyResponse;
-    };
-};
+export type PolicyCertificatesRemoveResponse = PolicyCertificatesModifyResponse;
 
 // @public
 export interface PolicyCertificatesResponse {