Skip to content

Commit dd6a399

Browse files
authored
[KeyVault] - Use error object for LRO errors (Azure#15500)
## What - Use `error.code` to check if there's an error (not just the presence of error) - Unpend the Admin LRO tests ## Why - Consistency with other languages - We used to require using StatusDetails or status because the AAD errors were not populated in the error object, now that this is fixed we can use the error object. - Even on a successful response `error` will still get sent over the wire, so we need to check the presence of `code` as well. This service-side issue will be fixed, but for now all languages will guard against this. Fixes Azure#15448
1 parent 082d18c commit dd6a399

File tree

7 files changed

+596
-15
lines changed

7 files changed

+596
-15
lines changed

sdk/keyvault/keyvault-admin/recordings/node/keyvaultbackupclient_beginbackup/recording_returns_the_correct_backup_result_when_fails_to_authenticate.js

Lines changed: 173 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/keyvault/keyvault-admin/recordings/node/keyvaultbackupclient_beginbackup/recording_throws_when_polling_errors.js

Lines changed: 207 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)