Remove external URL dependency (Azure#15300)

* Remove external URL dependency to address compatibility issues

Author: vicancy

sdk/web-pubsub/web-pubsub/CHANGELOG.md

@@ -1,4 +1,6 @@
 # Release History
+## 1.0.0-beta.2 (2021-05-19)
+Remove "url" dependency
 
 ## 1.0.0-beta.1 (2021-04-23)
 

sdk/web-pubsub/web-pubsub/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/web-pubsub",
-  "version": "1.0.0-beta.1",
+  "version": "1.0.0-beta.2",
   "description": "Azure client library for Azure Web PubSub",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -41,6 +41,9 @@
     "README.md",
     "LICENSE"
   ],
+  "browser": {
+    "./dist-esm/src/util/url.js": "./dist-esm/src/util/url.browser.js"
+  },
   "repository": "github:Azure/azure-sdk-for-js",
   "keywords": [
     "Azure",
@@ -114,7 +117,6 @@
     "sinon": "^9.0.2",
     "source-map-support": "^0.5.9",
     "typescript": "~4.2.0",
-    "url": "^0.11.0",
     "typedoc": "0.15.2"
   },
   "//sampleConfiguration": {

sdk/web-pubsub/web-pubsub/review/web-pubsub.api.md

@@ -179,7 +179,7 @@ export class WebPubSubServiceClient {
     sendToConnection(connectionId: string, message: JSONTypes, options?: HubSendToConnectionOptions): Promise<RestResponse>;
     sendToConnection(connectionId: string, message: HttpRequestBody | JSONTypes, options?: HubSendToConnectionOptions | HubSendTextToConnectionOptions): Promise<RestResponse>;
     sendToUser(username: string, message: string, options: HubSendTextToUserOptions): Promise<RestResponse>;
-    sendToUser(username: string, message: JSONTypes, options: HubSendTextToUserOptions): Promise<RestResponse>;
+    sendToUser(username: string, message: JSONTypes, options?: HubSendToUserOptions): Promise<RestResponse>;
     sendToUser(username: string, message: HttpRequestBody, options?: HubSendToUserOptions | HubSendTextToUserOptions): Promise<RestResponse>;
 }
 

sdk/web-pubsub/web-pubsub/src/dom.d.ts

@@ -0,0 +1,4 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+/// <reference lib="dom" />

sdk/web-pubsub/web-pubsub/src/hubClient.ts

@@ -344,7 +344,7 @@ export class WebPubSubServiceClient {
   ): Promise<RestResponse>;
 
   public async sendToAll(
-    message: HttpRequestBody | JSONTypes,
+    message: HttpRequestBody | string,
     options: HubSendToAllOptions | HubSendTextToAllOptions = {}
   ): Promise<RestResponse> {
     const normalizedOptions = normalizeSendToAllOptions(options);
@@ -389,7 +389,7 @@ export class WebPubSubServiceClient {
   public async sendToUser(
     username: string,
     message: JSONTypes,
-    options: HubSendTextToUserOptions
+    options?: HubSendToUserOptions
   ): Promise<RestResponse>;
 
   /**
@@ -406,7 +406,7 @@ export class WebPubSubServiceClient {
   ): Promise<RestResponse>;
   public async sendToUser(
     username: string,
-    message: JSONTypes | HttpRequestBody,
+    message: string | HttpRequestBody,
     options: HubSendToUserOptions = {}
   ): Promise<RestResponse> {
     const { span, updatedOptions } = createSpan("WebPubSubServiceClient-hub-sendToUser", options);

sdk/web-pubsub/web-pubsub/src/parseConnectionString.ts

@@ -1,5 +1,5 @@
 import { AzureKeyCredential } from "@azure/core-auth";
-import { URL } from "url";
+import { URL } from "./util/url";
 
 interface ParsedConnectionString {
   credential: AzureKeyCredential;

sdk/web-pubsub/web-pubsub/src/util/url.browser.ts

@@ -0,0 +1,6 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+const url = URL;
+
+export { url as URL };

sdk/web-pubsub/web-pubsub/src/util/url.ts

@@ -0,0 +1,4 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+export { URL } from "url";