Skip to content

Commit d5276ea

Browse files
authored
Update docsms packages (Azure#19009)
1 parent f73b3d8 commit d5276ea

File tree

4 files changed

+41
-10
lines changed

4 files changed

+41
-10
lines changed

eng/pipelines/docindex.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ jobs:
6969
inputs:
7070
pwsh: true
7171
filePath: eng/common/scripts/Update-DocsMsPackages.ps1
72-
arguments: -DocRepoLocation $(DocRepoLocation) -ImageId '$(DocValidationImageId)'
72+
arguments: -DocRepoLocation $(DocRepoLocation)
7373
displayName: Update Docs Onboarding for Daily branch
7474

7575
- template: /eng/common/pipelines/templates/steps/git-push-changes.yml

eng/pipelines/templates/stages/archetype-js-release.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,8 @@ stages:
140140
SparseCheckoutPaths:
141141
- docs-ref-services/
142142
- metadata/
143+
- ci-configs/packages-latest.json
144+
- ci-configs/packages-preview.json
143145

144146
- ${{if ne(artifact.skipPublishDocGithubIo, 'true')}}:
145147
- deployment: PublishDocsGitHubIO
@@ -307,3 +309,5 @@ stages:
307309
SparseCheckoutPaths:
308310
- docs-ref-services/
309311
- metadata/
312+
- ci-configs/packages-latest.json
313+
- ci-configs/packages-preview.json

eng/scripts/Language-Settings.ps1

Lines changed: 35 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ function Get-DocsMsPackageName($packageName, $packageVersion) {
233233
# registry = "<url>";
234234
# ...
235235
# }
236-
function ValidatePackagesForDocs($packages) {
236+
function ValidatePackagesForDocs($packages, $DocValidationImageId) {
237237
# Using GetTempPath because it works on linux and windows
238238
$tempDirectory = Join-Path ([System.IO.Path]::GetTempPath()) ([System.IO.Path]::GetRandomFileName())
239239
New-Item -ItemType Directory -Force -Path $tempDirectory | Out-Null
@@ -244,7 +244,7 @@ function ValidatePackagesForDocs($packages) {
244244
# Get value for variables outside of the Foreach-Object scope
245245
$scriptRoot = "$using:scriptRoot"
246246
$workingDirectory = "$using:tempDirectory"
247-
return ."$scriptRoot\validate-docs-package.ps1" -Package $_ -DocValidationImageId "$using:ImageId" -WorkingDirectory $workingDirectory
247+
return ."$scriptRoot\validate-docs-package.ps1" -Package $_ -DocValidationImageId "$using:DocValidationImageId" -WorkingDirectory $workingDirectory
248248
}
249249

250250
# Clean up temp folder
@@ -260,8 +260,7 @@ $PackageExclusions = @{
260260
'@azure/core-asynciterator-polyfill' = 'Docs CI fails https://github.com/Azure/azure-sdk-for-js/issues/16675';
261261
}
262262

263-
function Update-javascript-DocsMsPackages($DocsRepoLocation, $DocsMetadata) {
264-
263+
function Update-javascript-DocsMsPackages($DocsRepoLocation, $DocsMetadata, $DocValidationImageId) {
265264
Write-Host "Excluded packages:"
266265
foreach ($excludedPackage in $PackageExclusions.Keys) {
267266
Write-Host " $excludedPackage - $($PackageExclusions[$excludedPackage])"
@@ -273,16 +272,18 @@ function Update-javascript-DocsMsPackages($DocsRepoLocation, $DocsMetadata) {
273272
(Join-Path $DocsRepoLocation 'ci-configs/packages-preview.json') `
274273
'preview' `
275274
$FilteredMetadata `
276-
(Join-Path $DocsRepoLocation 'ci-configs/packages-preview.json.log') # Log file for package validation
277-
275+
(Join-Path $DocsRepoLocation 'ci-configs/packages-preview.json.log') `
276+
$DocValidationImageId
277+
278278
UpdateDocsMsPackages `
279279
(Join-Path $DocsRepoLocation 'ci-configs/packages-latest.json') `
280280
'latest' `
281281
$FilteredMetadata `
282-
(Join-Path $DocsRepoLocation 'ci-configs/packages-latest.json.log') # Log file for package validation
282+
(Join-Path $DocsRepoLocation 'ci-configs/packages-latest.json.log') `
283+
$DocValidationImageId
283284
}
284285

285-
function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata, $PackageHistoryLogFile) {
286+
function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata, $PackageHistoryLogFile, $DocValidationImageId) {
286287
Write-Host "Updating configuration: $DocConfigFile with mode: $Mode"
287288
$packageConfig = Get-Content $DocConfigFile -Raw | ConvertFrom-Json
288289

@@ -373,7 +374,7 @@ function UpdateDocsMsPackages($DocConfigFile, $Mode, $DocsMetadata, $PackageHist
373374
$outputPackages += @{ name = $packageName }
374375
}
375376

376-
$packageValidation = ValidatePackagesForDocs $outputPackages
377+
$packageValidation = ValidatePackagesForDocs $outputPackages $DocValidationImageId
377378
$validationHash = @{}
378379
foreach ($result in $packageValidation) {
379380
$validationHash[$result.Package.name] = $result
@@ -468,3 +469,28 @@ function GetExistingPackageVersions ($PackageName, $GroupId = $null)
468469
return $null
469470
}
470471
}
472+
473+
function Validate-javascript-DocMsPackages ($PackageInfo, $DocRepoLocation, $DocValidationImageId)
474+
{
475+
$fileLocation = ""
476+
if ($PackageInfo.DevVersion -or $PackageInfo.Version -contains "beta") {
477+
$fileLocation = (Join-Path $DocRepoLocation 'ci-configs/packages-preview.json')
478+
if ($PackageInfo.DevVersion) {
479+
$PackageInfo.Version = $PackageInfo.DevVersion
480+
}
481+
}
482+
else {
483+
$fileLocation = (Join-Path $DocRepoLocation 'ci-configs/packages-latest.json')
484+
}
485+
486+
$packageConfig = Get-Content $fileLocation -Raw | ConvertFrom-Json
487+
$outputPackage = $PackageInfo
488+
foreach ($package in $packageConfig.npm_package_sources) {
489+
if ($package.name -eq $PackageInfo.Name) {
490+
$outputPackage = $package
491+
$outputPackage.name = Get-DocsMsPackageName $package.name $PackageInfo.Version
492+
break
493+
}
494+
}
495+
ValidatePackagesForDocs -packages $outputPackage -DocValidationImageId $DocValidationImageId
496+
}

eng/scripts/validate-docs-package.ps1

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ function DockerValidation() {
6363
$commandLine = "$commandLine$folder"
6464
}
6565
$commandLine = "$commandLine $DocValidationImageId 2>&1"
66+
Write-Host $commandLine
6667
$installOutput = Invoke-Expression $commandLine
6768

6869
# The docker exit codes: https://docs.docker.com/engine/reference/run/#exit-status

0 commit comments

Comments
 (0)