[Tables] Expose client option allowInsecureConnection (Azure#15938)

In order for Tables to connect to Azurite and Storage emulator, the client needs to accept `allowInsecureConnection`. Also when using the emulator connection string shortcut, setting it by default.

Author: joheredi

sdk/core/core-client/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+## 1.2.0 (UNRELEASED)
+
+### Features Added
+
+- Moved `allowInsecureConnection` from `ServiceClientOptions` to `CommonClientOptions` [issue 15938](https://github.com/azure/azure-sdk-for-js/issues/15938)
+
 ## 1.1.3 (2021-06-17)
 
 ### Key Bugs Fixed

sdk/core/core-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/core-client",
-  "version": "1.1.3",
+  "version": "1.2.0",
   "description": "Core library for interfacing with AutoRest generated code",
   "sdk-type": "client",
   "main": "dist/index.js",

sdk/core/core-client/review/core-client.api.md

@@ -37,6 +37,7 @@ export interface BaseMapper {
 
 // @public
 export interface CommonClientOptions extends PipelineOptions {
+    allowInsecureConnection?: boolean;
     httpClient?: HttpClient;
 }
 
@@ -351,7 +352,6 @@ export class ServiceClient {
 
 // @public
 export interface ServiceClientOptions extends CommonClientOptions {
-    allowInsecureConnection?: boolean;
     baseUri?: string;
     credential?: TokenCredential;
     credentialScopes?: string | string[];

sdk/core/core-client/src/interfaces.ts

@@ -554,4 +554,8 @@ export interface CommonClientOptions extends PipelineOptions {
    * The HttpClient that will be used to send HTTP requests.
    */
   httpClient?: HttpClient;
+  /**
+   * Set to true if the request is sent over HTTP instead of HTTPS
+   */
+  allowInsecureConnection?: boolean;
 }

sdk/core/core-client/src/serviceClient.ts

@@ -49,10 +49,6 @@ export interface ServiceClientOptions extends CommonClientOptions {
    * A customized pipeline to use, otherwise a default one will be created.
    */
   pipeline?: Pipeline;
-  /**
-   * Set to true if the request is sent over HTTP instead of HTTPS
-   */
-  allowInsecureConnection?: boolean;
 }
 
 /**

sdk/tables/data-tables/CHANGELOG.md

@@ -17,6 +17,7 @@ Thank you to our developer community members who helped to make the Azure Tables
 - Fix [#15664](https://github.com/Azure/azure-sdk-for-js/issues/15701), adding check to make sure we always have only one forward slash (`/`) added to the end of the URL [#15698](https://github.com/Azure/azure-sdk-for-js/pull/15698) (A community contribution, courtesy of _[eestein](https://github.com/eestein))_
 - Fix [#15701](https://github.com/Azure/azure-sdk-for-js/issues/15701) by improving error handling and reporting on `submitTransaction`. [#15852](https://github.com/Azure/azure-sdk-for-js/pull/15852)
 - Fix [#15921](https://github.com/Azure/azure-sdk-for-js/issues/15921) incorrect `url` import and missing browser mapping for `computeHMACSHA256` [#15944](https://github.com/Azure/azure-sdk-for-js/pull/15944)
+- Fix [#15854](https://github.com/Azure/autorest.typescript/issues/892) by setting `allowInsecureConnection` to true when using the development connection string.
 
 ## 12.0.0 (2021-06-09)
 

sdk/tables/data-tables/src/utils/connectionString.ts

@@ -21,10 +21,11 @@ const DevelopmentConnectionString =
  */
 export function getClientParamsFromConnectionString(
   connectionString: string,
-  options?: TableServiceClientOptions
+  options: TableServiceClientOptions = {}
 ): ClientParamsFromConnectionString {
   if (connectionString.toLowerCase().indexOf("usedevelopmentstorage=true") !== -1) {
     connectionString = DevelopmentConnectionString;
+    options.allowInsecureConnection = true;
   }
   const extractedCreds = extractConnectionStringParts(connectionString);
   if (extractedCreds.kind === "AccountConnString") {