Skip to content

Commit cab60f4

Browse files
[Service Bus] Link messageSpanContexts while sending - for array of messages (Azure#12508)
For sending the array of messages case, we weren't linking the message span contexts while creating the send span. This PR attempts to fix that!
1 parent ba17f13 commit cab60f4

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

sdk/servicebus/service-bus/src/sender.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import {
2626
getParentSpan,
2727
OperationOptionsBase
2828
} from "./modelsToBeSharedWithEventHubs";
29-
import { CanonicalCode, SpanContext } from "@opentelemetry/api";
29+
import { CanonicalCode } from "@opentelemetry/api";
3030
import { senderLogger as logger } from "./log";
3131

3232
/**
@@ -189,12 +189,8 @@ export class ServiceBusSenderImpl implements ServiceBusSender {
189189
const invalidTypeErrMsg =
190190
"Provided value for 'messages' must be of type ServiceBusMessage, ServiceBusMessageBatch or an array of type ServiceBusMessage.";
191191

192-
// link message span contexts
193-
let spanContextsToLink: SpanContext[] = [];
194-
195192
let batch: ServiceBusMessageBatch;
196193
if (isServiceBusMessageBatch(messages)) {
197-
spanContextsToLink = messages._messageSpanContexts;
198194
batch = messages;
199195
} else {
200196
if (!Array.isArray(messages)) {
@@ -216,7 +212,7 @@ export class ServiceBusSenderImpl implements ServiceBusSender {
216212

217213
const sendSpan = createSendSpan(
218214
getParentSpan(options?.tracingOptions),
219-
spanContextsToLink,
215+
batch._messageSpanContexts,
220216
this.entityPath,
221217
this._context.config.host
222218
);

0 commit comments

Comments
 (0)