fix(service-bus): removing namespaceType from NamespaceProperties (Azure#11995)

Addressing Azure#11956

Author: pathway27

sdk/servicebus/service-bus/CHANGELOG.md

@@ -15,6 +15,7 @@
 - Added new "userId" property to `ServiceBusMessage` interface. [PR 11810](https://github.com/Azure/azure-sdk-for-js/pull/11810)
 
 - `NamespaceProperties` interface property "messageSku" type changed from "string" to string literal type "Basic" | "Premium" | "Standard". [PR 11810](https://github.com/Azure/azure-sdk-for-js/pull/11810)
+- `NamespaceProperties` interface property "namespaceType" has been removed. [PR 11995](https://github.com/Azure/azure-sdk-for-js/pull/11995)
 
 - Internal improvement - For the operations depending on `$management` link such as peek or lock renewals, the listeners for the "sender_error" and "receiver_error" events were added to the link for each new request made before the link is initialized which would have resulted in too many listeners and a warning such as `MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 sender_error listeners added to [Sender]. Use emittr.setMaxListeners() to increase limit`(same for `receiver_error`). This has been improved such that the listeners are reused.
   [PR 11738](https://github.com/Azure/azure-sdk-for-js/pull/11738)

sdk/servicebus/service-bus/review/service-bus.api.md

@@ -206,7 +206,6 @@ export interface NamespaceProperties {
     messagingUnits: number | undefined;
     modifiedAt: Date;
     name: string;
-    namespaceType: string;
 }
 
 // @public

sdk/servicebus/service-bus/samples/javascript/advanced/administrationClient.js

@@ -42,7 +42,7 @@ async function main() {
   console.log("Number of messages in the queue = ", queueRuntimeProperties.totalMessageCount);
 
   const namespaceInfo = await serviceBusAdministrationClient.getNamespaceProperties();
-  console.log("Type of the namespace - ", namespaceInfo.namespaceType);
+  console.log("Name of the namespace - ", namespaceInfo.name);
 
   await serviceBusAdministrationClient.deleteQueue(queueName);
   const queueExists = await serviceBusAdministrationClient.queueExists(queueName);

sdk/servicebus/service-bus/samples/typescript/src/advanced/administrationClient.ts

@@ -43,7 +43,7 @@ async function main() {
   console.log("Number of messages in the queue = ", queueRuntimeProperties.totalMessageCount);
 
   const namespaceInfo = await serviceBusAdministrationClient.getNamespaceProperties();
-  console.log("Type of the namespace - ", namespaceInfo.namespaceType);
+  console.log("Name of the namespace - ", namespaceInfo.name);
 
   await serviceBusAdministrationClient.deleteQueue(queueName);
   const queueExists = await serviceBusAdministrationClient.queueExists(queueName);

sdk/servicebus/service-bus/src/serializers/namespaceResourceSerializer.ts

@@ -33,10 +33,6 @@ export interface NamespaceProperties {
    * Name of the namespace.
    */
   name: string;
-  /**
-   * Type of entities present in the namespace.
-   */
-  namespaceType: string;
   /**
    * Number of messaging units allocated for namespace.
    * Valid only for Premium namespaces.
@@ -61,7 +57,6 @@ export function buildNamespace(rawNamespace: any): NamespaceProperties {
     messagingSku: messagingSku,
     modifiedAt: getDate(rawNamespace["ModifiedTime"], "modifiedAt"),
     name: getString(rawNamespace["Name"], "name"),
-    namespaceType: getString(rawNamespace["NamespaceType"], "namespaceType"),
     messagingUnits:
       messagingSku === "Premium"
         ? getInteger(rawNamespace["MessagingUnits"], "messagingUnits")

sdk/servicebus/service-bus/test/atomManagement.spec.ts

@@ -63,7 +63,7 @@ describe("Atom management - Namespace", function(): void {
     const namespaceProperties = await serviceBusAtomManagementClient.getNamespaceProperties();
     assert.deepEqualExcluding(
       namespaceProperties,
-      { messagingSku: "Standard", namespaceType: "Messaging", messagingUnits: undefined } as any,
+      { messagingSku: "Standard", messagingUnits: undefined } as any,
       ["_response", "createdAt", "modifiedAt", "name"]
     );
   });