Skip to content

Commit b200156

Browse files
authored
[eventgrid][servicebus] - Update tests to reflect tracingPolicy changes (Azure#19893)
**Checklists** - [x] Added impacted package name to the issue description **Packages impacted by this PR:** @azure/event-grid, @azure/service-bus **Describe the problem that is addressed by this PR:** In order to conform to the OTel spec and allow for easier aggregations we updated tracing policy to name the span `HTTP <method>` instead of `<path>`. Unfortunately we missed a few tests, so this updates those tests to reflect the core changes. While editing these tests, I realized I never added CHANGELOG entries for the original change. This PR addresses that as well. **Provide a list of related PRs**_(if any)_ Azure#19838 Resolves Azure#19887 Resolves Azure#19885
1 parent af71ca5 commit b200156

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

sdk/core/core-http/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
### Bugs Fixed
1010

11+
- Updated the HTTP tracing span names to conform to the [OpenTelemetry Specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#name). [#19838](https://github.com/Azure/azure-sdk-for-js/pull/19838)
12+
- New HTTP spans will use the `HTTP <VERB>` convention instead of using the URL path.
13+
1114
### Other Changes
1215

1316
## 2.2.3 (2022-01-06)

sdk/core/core-rest-pipeline/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@
88

99
### Bugs Fixed
1010

11+
- Updated the HTTP tracing span names to conform to the [OpenTelemetry Specification](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#name). [#19838](https://github.com/Azure/azure-sdk-for-js/pull/19838)
12+
- New HTTP spans will use the `HTTP <VERB>` convention instead of using the URL path.
13+
1114
### Other Changes
1215

1316
## 1.4.0 (2022-01-06)

sdk/eventgrid/eventgrid/test/public/eventGridClient.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ describe("EventGridPublisherClient", function (this: Suite) {
239239
assert.equal(spans.length, 3);
240240
assert.equal(spans[0].name, "root");
241241
assert.equal(spans[1].name, "Azure.Data.EventGrid.EventGridPublisherClient-send");
242-
assert.equal(spans[2].name, "/api/events");
243242

244243
resetTracer();
245244
});

sdk/servicebus/service-bus/test/internal/operationOptionsForATOM.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ describe("Operation Options", () => {
264264
children: [
265265
{
266266
children: [],
267-
name: "/$namespaceinfo",
267+
name: "HTTP GET",
268268
},
269269
],
270270
name: "Azure.ServiceBus.ServiceBusAdministrationClient-getResource",

0 commit comments

Comments
 (0)