[core-xml] Update fxp to v4 (Azure#19898)

* Update and fix breaking changes

* Bump minor

* update lock

Author: joheredi

common/config/rush/pnpm-lock.yaml

@@ -1,15 +1,11 @@
 # Release History
 
-## 1.1.1 (Unreleased)
-
-### Features Added
-
-### Breaking Changes
-
-### Bugs Fixed
+## 1.2.0 (Unreleased)
 
 ### Other Changes
 
+- Upgrade to `fast-xml-parser` to v4 [PR# 19898](https://github.com/Azure/azure-sdk-for-js/pull/19898)
+
 ## 1.1.0 (2022-01-06)
 
 ### Other Changes

sdk/core/core-xml/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@azure/core-xml",
-  "version": "1.1.1",
+  "version": "1.2.0",
   "description": "Core library for interacting with XML payloads",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -66,7 +66,7 @@
   "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json",
   "dependencies": {
     "tslib": "^2.2.0",
-    "fast-xml-parser": "^3.20.0"
+    "fast-xml-parser": "^4.0.1"
   },
   "devDependencies": {
     "@azure/dev-tool": "^1.0.0",

sdk/core/core-xml/package.json

@@ -1,14 +1,15 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { j2xParser, parse, validate } from "fast-xml-parser";
+import { XMLBuilder, XMLValidator, XMLParser } from "fast-xml-parser";
 import { XML_ATTRKEY, XML_CHARKEY, XmlOptions } from "./xml.common";
 
 function getCommonOptions(options: XmlOptions) {
   return {
-    attrNodeName: XML_ATTRKEY,
+    attributesGroupName: XML_ATTRKEY,
     textNodeName: options.xmlCharKey ?? XML_CHARKEY,
     ignoreAttributes: false,
+    suppressBooleanAttributes: false,
   };
 }
 
@@ -17,7 +18,7 @@ function getSerializerOptions(options: XmlOptions = {}) {
     ...getCommonOptions(options),
     attributeNamePrefix: "@_",
     format: true,
-    supressEmptyNode: true,
+    suppressEmptyNode: true,
     indentBy: "",
     rootNodeName: options.rootName ?? "root",
   };
@@ -27,7 +28,7 @@ function getParserOptions(options: XmlOptions = {}) {
   return {
     ...getCommonOptions(options),
     parseAttributeValue: false,
-    parseNodeValue: false,
+    parseTagValue: false,
     attributeNamePrefix: "",
   };
 }
@@ -39,11 +40,11 @@ function getParserOptions(options: XmlOptions = {}) {
  */
 export function stringifyXML(obj: unknown, opts: XmlOptions = {}): string {
   const parserOptions = getSerializerOptions(opts);
-  const j2x = new j2xParser(parserOptions);
+  const j2x = new XMLBuilder(parserOptions);
 
   const node = { [parserOptions.rootNodeName]: obj };
 
-  const xmlData: string = j2x.parse(node);
+  const xmlData: string = j2x.build(node);
   return `<?xml version="1.0" encoding="UTF-8" standalone="yes"?>${xmlData}`.replace(/\n/g, "");
 }
 
@@ -58,13 +59,14 @@ export async function parseXML(str: string, opts: XmlOptions = {}): Promise<any>
     throw new Error("Document is empty");
   }
 
-  const validation = validate(str);
+  const validation = XMLValidator.validate(str);
 
   if (validation !== true) {
     throw validation;
   }
 
-  const parsedXml = parse(unescapeHTML(str), getParserOptions(opts));
+  const parser = new XMLParser(getParserOptions(opts));
+  const parsedXml = parser.parse(unescapeHTML(str));
 
   if (!opts.includeRoot) {
     for (const key of Object.keys(parsedXml)) {