Skip to content

Commit 8a86351

Browse files
[monitor] Fix some of the more obvious breakages (CI is still broken afterwards, however) (Azure#13881)
(NOTE: CI is still broken as we have to investigate the rest of the breakages in the test) * Problem #1 - the underlying value has changed (it used to be a CanonicalCode.OK (0) but now is StatusCode.OK (1)). * Fixing issue where the test failing wasn't actually passed on to the test framework.
1 parent 4a6bb5c commit 8a86351

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export class BasicScenario implements Scenario {
9191
version: 1,
9292
name: "BasicScenario.Root",
9393
duration: msToTimeSpan(600),
94-
responseCode: "0",
94+
responseCode: SpanStatusCode.OK.toString(),
9595
success: true,
9696
properties: {
9797
foo: "bar"
@@ -108,7 +108,7 @@ export class BasicScenario implements Scenario {
108108
name: "BasicScenario.Child.1",
109109
duration: msToTimeSpan(100),
110110
success: true,
111-
resultCode: "0",
111+
resultCode: SpanStatusCode.OK.toString(),
112112
properties: {
113113
numbers: "123"
114114
}
@@ -125,7 +125,7 @@ export class BasicScenario implements Scenario {
125125
name: "BasicScenario.Child.2",
126126
duration: msToTimeSpan(100),
127127
success: true,
128-
resultCode: "0",
128+
resultCode: SpanStatusCode.OK.toString(),
129129
properties: {
130130
numbers: "1234"
131131
}

sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe("Trace Exporter Scenarios", () => {
4646
});
4747
})
4848
.catch((e) => {
49-
throw e;
49+
done(e);
5050
});
5151
});
5252
});

0 commit comments

Comments
 (0)