Skip to content

Commit 745290d

Browse files
authored
[Event Hubs] Allow linter errs to break build (Azure#13920)
Fixes the last error in Event Hubs package and allows future linter errors to break the build. We need to fix up the checkpoint store package before we can close the related issue Azure#10777
1 parent 2905176 commit 745290d

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

sdk/eventhub/event-hubs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 1200000 --full-trace dist-esm/test/internal/*.spec.js dist-esm/test/public/*.spec.js dist-esm/test/public/**/*.spec.js dist-esm/test/internal/**/*.spec.js",
6262
"integration-test": "npm run integration-test:node && npm run integration-test:browser",
6363
"lint:fix": "eslint package.json api-extractor.json src test --ext .ts --fix --fix-type [problem,suggestion]",
64-
"lint": "eslint package.json api-extractor.json src test --ext .ts -f html -o event-hubs-lintReport.html || exit 0",
64+
"lint": "eslint package.json api-extractor.json src test --ext .ts",
6565
"pack": "npm pack 2>&1",
6666
"perf-test:node": "tsc -p . --module \"commonjs\" && node dist-esm/test/perf/track-2/index.spec.js",
6767
"prebuild": "npm run clean",

sdk/eventhub/event-hubs/test/internal/utils.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ function getAbortSignalWithTracking(
324324
): AbortSignalLike & { ourListenersWereRemoved(): boolean } {
325325
const signal = (abortController.signal as any) as ReturnType<typeof getAbortSignalWithTracking>;
326326

327-
const allFunctions = new Set<Function>();
327+
const allFunctions = new Set();
328328

329329
const origAddEventListener = signal.addEventListener;
330330
const origRemoveEventListener = signal.removeEventListener;

sdk/eventhub/event-hubs/test/public/utils/testUtils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { NoOpTracer, TestTracer, setTracer } from "@azure/core-tracing";
99

1010
dotenv.config();
1111

12-
declare const window: any;
12+
declare const self: any;
1313

1414
export const isNode =
1515
!!process && !!process.version && !!process.versions && !!process.versions.node;
@@ -26,7 +26,7 @@ function getEnvVarValue(name: string): string | undefined {
2626
if (isNode) {
2727
return process.env[name];
2828
} else {
29-
return window.__env__[name];
29+
return self.__env__[name];
3030
}
3131
}
3232

0 commit comments

Comments
 (0)