Skip to content

Commit 64dfd08

Browse files
authored
Log ms-cv header for every request during tests (Azure#15083)
Remove condition that would not log the ms-cv header if the network request was successful
1 parent 5d8a485 commit 64dfd08

File tree

4 files changed

+20
-12
lines changed

4 files changed

+20
-12
lines changed

sdk/communication/communication-chat/test/public/utils/recordedClient.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,11 @@ function createTestHttpClient(): HttpClient {
8181
): Promise<HttpOperationResponse> {
8282
const requestResponse = await originalSendRequest.apply(this, [httpRequest]);
8383

84-
if (requestResponse.status < 200 || requestResponse.status > 299) {
85-
console.log(`MS-CV header for failed request: ${requestResponse.headers.get("ms-cv")}`);
86-
}
84+
console.log(
85+
`MS-CV header for request: ${requestResponse.headers.get("ms-cv")} (${
86+
requestResponse.status
87+
} - ${httpRequest.url})`
88+
);
8789

8890
return requestResponse;
8991
};

sdk/communication/communication-identity/test/public/utils/recordedClient.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,11 @@ function createTestHttpClient(): HttpClient {
129129
): Promise<HttpOperationResponse> {
130130
const requestResponse = await originalSendRequest.apply(this, [httpRequest]);
131131

132-
if (requestResponse.status < 200 || requestResponse.status > 299) {
133-
console.log(`MS-CV header for failed request: ${requestResponse.headers.get("ms-cv")}`);
134-
}
132+
console.log(
133+
`MS-CV header for request: ${requestResponse.headers.get("ms-cv")} (${
134+
requestResponse.status
135+
} - ${httpRequest.url})`
136+
);
135137

136138
return requestResponse;
137139
};

sdk/communication/communication-phone-numbers/test/public/utils/recordedClient.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,11 @@ function createTestHttpClient(): HttpClient {
125125
): Promise<HttpOperationResponse> {
126126
const requestResponse = await originalSendRequest.apply(this, [httpRequest]);
127127

128-
if (requestResponse.status < 200 || requestResponse.status > 299) {
129-
console.log(`MS-CV header for failed request: ${requestResponse.headers.get("ms-cv")}`);
130-
}
128+
console.log(
129+
`MS-CV header for request: ${requestResponse.headers.get("ms-cv")} (${
130+
requestResponse.status
131+
} - ${httpRequest.url})`
132+
);
131133

132134
return requestResponse;
133135
};

sdk/communication/communication-sms/test/public/utils/recordedClient.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,11 @@ function createTestHttpClient(): HttpClient {
8484
): Promise<HttpOperationResponse> {
8585
const requestResponse = await originalSendRequest.apply(this, [httpRequest]);
8686

87-
if (requestResponse.status < 200 || requestResponse.status > 299) {
88-
console.log(`MS-CV header for failed request: ${requestResponse.headers.get("ms-cv")}`);
89-
}
87+
console.log(
88+
`MS-CV header for request: ${requestResponse.headers.get("ms-cv")} (${
89+
requestResponse.status
90+
} - ${httpRequest.url})`
91+
);
9092

9193
return requestResponse;
9294
};

0 commit comments

Comments
 (0)