Skip to content

Commit 5864021

Browse files
service bus internal method rename Azure#13390 (Azure#13419)
Renamed `close` to `terminate` to resolve issue Azure#13390.
1 parent 976fb3f commit 5864021

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

sdk/servicebus/service-bus/src/core/batchingReceiver.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class BatchingReceiver extends MessageReceiver {
9292
);
9393
}
9494

95-
this._batchingReceiverLite.close(connectionError);
95+
this._batchingReceiverLite.terminate(connectionError);
9696
}
9797

9898
/**
@@ -301,7 +301,7 @@ export class BatchingReceiverLite {
301301
*
302302
* @param connectionError An optional error (rhea doesn't always deliver one for certain disconnection events)
303303
*/
304-
close(connectionError?: Error | AmqpError) {
304+
terminate(connectionError?: Error | AmqpError) {
305305
if (this._closeHandler) {
306306
this._closeHandler(connectionError);
307307
this._closeHandler = undefined;

sdk/servicebus/service-bus/src/session/messageSession.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ export class MessageSession extends LinkEntity<Receiver> {
545545

546546
await super.close();
547547

548-
await this._batchingReceiverLite.close();
548+
await this._batchingReceiverLite.terminate();
549549
} catch (err) {
550550
logger.logError(
551551
err,

sdk/servicebus/service-bus/test/internal/batchingReceiver.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ describe("BatchingReceiver unit tests", () => {
624624
await receiveIsReady;
625625
assert.exists(receiver["_closeHandler"]);
626626

627-
await receiver.close(new Error("actual error"));
627+
await receiver.terminate(new Error("actual error"));
628628

629629
try {
630630
await receiveMessagesPromise;
@@ -670,7 +670,7 @@ describe("BatchingReceiver unit tests", () => {
670670
assert.isFalse(resolveWasCalled);
671671
assert.isFalse(rejectWasCalled);
672672

673-
receiver.close();
673+
receiver.terminate();
674674

675675
// these are still false because we used setTimeout() (and we're using sinon)
676676
// so the clock is "frozen"

0 commit comments

Comments
 (0)