Skip to content

Commit 51bd3e0

Browse files
[Perf Tests][Storage Blob] Fixes to tsconfigs/package.json and adds NoOp test (Azure#14024)
@mikeharder found that there was a vast difference in perf for the NoOp test in track-1 vs track-2 folders. ⭐ Upon investigating, we have found that the differences in tsconfig and the different typescript versions being used for track-1 and track-2 to be the cause of the perf difference. For a perspective, with the existing configs and TS4.1.2 for track-2 and TS4.1.5(installed globally) for track-1, the track-1 was 4 times worse in the NoOp test. Upon changing the tsconfig for track-1 to the one we have for track-2 and adding the devDep on TS4.1.2 for track-1 similar to that of track-2, the difference was gone. This PR attempts to fix the differences. _(Note: Though the NoOp test had a huge perf difference, it would have been very negligible with the actual tests like downloading a blob given the work done at the SDK level and the service response time.)_
1 parent 204ecf1 commit 51bd3e0

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

sdk/storage/perf-tests/storage-blob-track-1/package.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,13 @@
99
"devDependencies": {
1010
"@azure/storage-blob": "^10.5.0",
1111
"@azure/test-utils-perfstress": "file:../../../test-utils/perfstress/azure-test-utils-perfstress-1.0.0.tgz",
12+
"@types/node": "^8.0.0",
1213
"@types/uuid": "^8.0.0",
1314
"dotenv": "^8.2.0",
14-
"uuid": "^8.3.0"
15+
"uuid": "^8.3.0",
16+
"tslib": "^2.0.0",
17+
"ts-node": "^8.3.0",
18+
"typescript": "4.1.2"
1519
},
1620
"private": true,
1721
"scripts": {
Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
11
{
22
"extends": "../../../../tsconfig.package",
33
"compilerOptions": {
4+
"target": "es5",
45
"module": "commonjs",
5-
"outDir": "./dist-esm"
6+
"declarationDir": "./typings/latest",
7+
"outDir": "./dist-esm",
8+
"lib": ["dom", "es5", "es6", "es7", "esnext"]
69
},
7-
"compileOnSave": true
10+
"compileOnSave": true,
11+
"exclude": ["node_modules"],
12+
"include": ["./test/**/*.ts"]
813
}

sdk/storage/perf-tests/storage-blob/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
"node-fetch": "^2.6.0",
2020
"uuid": "^8.3.0",
2121
"tslib": "^2.0.0",
22+
"ts-node": "^8.3.0",
2223
"typescript": "4.1.2"
2324
},
2425
"private": true,

0 commit comments

Comments
 (0)