Commit 2978b89
[storage-file-datalake] Allow DataLakePathClient.move() use sas to authenticate source and destination (Azure#12769)
* Make storage-file-datalake move() support adding both sasToken to x-ms-rename-source and the destination url
* Format
* Add comment to util function
* Fallback to use the source's SAS if both
- source authenticates with SAS
- destination isn't provided a SAS
* Reformat
* Do not encode sas query parameter values in x-ms-rename-source header
* Don't set query parameter for snapshot or versionid at the destination when fallback to use sas token in the source url
* Reformat
* Resolve merge conflict
* Remove fallback logic
Throw an error when the source path contains multiple ? query strings, causing ambiguity
* Encode source path segment by segment to avoid encoding "/" characters
* Add unit tests for move operation with SAS credentials
* Add move related test recordings
* Add a bullet for the fix in the change log
* Take PR suggestion
Co-authored-by: Lin Jian <lijian2@microsoft.com>1 parent 8d3c760 commit 2978b89
File tree
13 files changed
+1342
-224
lines changed- sdk/storage/storage-file-datalake
- recordings/node/datalakepathclient_nodejs_only
- src
- utils
- test
- node
- utils
13 files changed
+1342
-224
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
| |||
sdk/storage/storage-file-datalake/recordings/node/datalakepathclient_nodejs_only/recording_move.js
Lines changed: 73 additions & 61 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments