Skip to content

Commit 2978b89

Browse files
[storage-file-datalake] Allow DataLakePathClient.move() use sas to authenticate source and destination (Azure#12769)
* Make storage-file-datalake move() support adding both sasToken to x-ms-rename-source and the destination url * Format * Add comment to util function * Fallback to use the source's SAS if both - source authenticates with SAS - destination isn't provided a SAS * Reformat * Do not encode sas query parameter values in x-ms-rename-source header * Don't set query parameter for snapshot or versionid at the destination when fallback to use sas token in the source url * Reformat * Resolve merge conflict * Remove fallback logic Throw an error when the source path contains multiple ? query strings, causing ambiguity * Encode source path segment by segment to avoid encoding "/" characters * Add unit tests for move operation with SAS credentials * Add move related test recordings * Add a bullet for the fix in the change log * Take PR suggestion Co-authored-by: Lin Jian <lijian2@microsoft.com>
1 parent 8d3c760 commit 2978b89

13 files changed

+1342
-224
lines changed

sdk/storage/storage-file-datalake/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## 12.3.0-beta.2 (Unreleased)
44

5+
- Bug fix - `DataLakePathClient.move()` now supports source and destination authenticated with SAS. Fixed bug [12758](https://github.com/Azure/azure-sdk-for-js/issues/12758).
56
- Now you can get the functionality of the root directory via the `DataLakeDirectoryClient` created via `FileSystemClient.getDirectoryClient("")`. Fixed bug [12813](https://github.com/Azure/azure-sdk-for-js/issues/12813).
67

78
## 12.3.0-beta.1 (2020-12-09)

sdk/storage/storage-file-datalake/recordings/node/datalakepathclient_nodejs_only/recording_move.js

Lines changed: 73 additions & 61 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)