Skip to content

Commit 10395be

Browse files
authored
[Identity] Making MSAL extensions an unlisted dependency (Azure#14418)
`@azure/msal-node-extensions` has some very inconvenient requirements for our developers and for our community. It requires (besides Python in the three environments): - On Linux, to have installed `libsecret` and `build-essentials`. - On OSX, to have XCode configured. - On Windows: To have Visual Studio Code installed with C++ (this is reportedly about 60gb) While we move this dependency (and KeyTar) to a new package, this PR makes it so the dependency is "unlisted": If users try to use this feature, we will throw an error asking them to install the dependency. Tests that use this feature get skipped if the dependency is not present, and run if the dependency is present. I will add more clarity in the docs as part of this other PR: Azure#14405
1 parent 5bd519c commit 10395be

20 files changed

+547
-511
lines changed

common/config/rush/pnpm-lock.yaml

Lines changed: 0 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/identity/identity/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@
8787
"@azure/abort-controller": "^1.0.0",
8888
"@azure/msal-common": "~4.0.1",
8989
"@azure/msal-node": "^1.0.0",
90-
"@azure/msal-node-extensions": "~1.0.0-alpha.6",
9190
"@azure/msal-browser": "2.9.0",
9291
"@opentelemetry/api": "^0.10.2",
9392
"@types/stoppable": "^1.1.0",

sdk/identity/identity/recordings/node/clientcertificatecredential_internal/recording_accepts_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/clientcertificatecredential_internal_persistent_tests/recording_accepts_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/clientcertificatecredential_internal/recording_authenticates_silently_with_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/clientcertificatecredential_internal_persistent_tests/recording_authenticates_silently_with_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/clientsecretcredential_internal/recording_accepts_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/clientsecretcredential_internal_persistent_tests/recording_accepts_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/clientsecretcredential_internal/recording_authenticates_silently_with_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/clientsecretcredential_internal_persistent_tests/recording_authenticates_silently_with_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/devicecodecredential_internal/recording_accepts_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/devicecodecredential_internal_persistent_tests/recording_accepts_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/devicecodecredential_internal/recording_allows_passing_an_authenticationrecord_to_avoid_further_manual_authentications.js renamed to sdk/identity/identity/recordings/node/devicecodecredential_internal_persistent_tests/recording_allows_passing_an_authenticationrecord_to_avoid_further_manual_authentications.js

File renamed without changes.

sdk/identity/identity/recordings/node/devicecodecredential_internal/recording_authenticates_silently_with_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/devicecodecredential_internal_persistent_tests/recording_authenticates_silently_with_tokencachepersistenceoptions.js

File renamed without changes.

sdk/identity/identity/recordings/node/usernamepasswordcredential_internal/recording_accepts_tokencachepersistenceoptions.js renamed to sdk/identity/identity/recordings/node/usernamepasswordcredential_internal_persistent_tests/recording_accepts_tokencachepersistenceoptions.js

File renamed without changes.

0 commit comments

Comments
 (0)