Adding authentication type configuration key and fixing system default authentication type (Azure#28074)

* Adding authentication type as configuration key and setting the system default authentication type to NONE

* Updated unit test to check system default auth type is not null and Updated changelog

Author: ki1729

sdk/core/azure-core-amqp/CHANGELOG.md

@@ -7,6 +7,8 @@
 ### Breaking Changes
 
 ### Bugs Fixed
+- Fixed proxy authentication type not being read from configuration. ([#28073](https://github.com/Azure/azure-sdk-for-java/issues/28073))
+- Updated ProxyOptions.SYSTEM_DEFAULTS to use ProxyAuthenticationType.NONE
 
 ### Other Changes
 

sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/ProxyOptions.java

@@ -24,6 +24,15 @@ public class ProxyOptions implements AutoCloseable {
      * The configuration key for containing the password for the username who authenticates with the proxy.
      */
     public static final String PROXY_PASSWORD = "PROXY_PASSWORD";
+    /**
+     * The configuration key for containing the authentication type to be used by the proxy.
+     * This can one of three values -
+     *  - NONE
+     *  - BASIC
+     *  - DIGEST
+     *  as defined in ProxyAuthenticationType
+     */
+    public static final String PROXY_AUTHENTICATION_TYPE = "PROXY_AUTHENTICATION_TYPE";
 
     private static final ClientLogger LOGGER = new ClientLogger(ProxyOptions.class);
     private final PasswordAuthentication credentials;
@@ -38,7 +47,7 @@ public class ProxyOptions implements AutoCloseable {
     private ProxyOptions() {
         this.credentials = null;
         this.proxyAddress = null;
-        this.authentication = null;
+        this.authentication = ProxyAuthenticationType.NONE;
     }
 
     /**

sdk/core/azure-core-amqp/src/test/java/com/azure/core/amqp/ProxyOptionsTest.java

@@ -0,0 +1,22 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.azure.core.amqp;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import static com.azure.core.amqp.ProxyOptions.SYSTEM_DEFAULTS;
+
+public class ProxyOptionsTest {
+
+    /**
+     * Test System default proxy configuration properties are set
+     */
+    @Test
+    public void systemDefaultProxyConfiguration() {
+        Assertions.assertEquals(ProxyAuthenticationType.NONE, SYSTEM_DEFAULTS.getAuthentication());
+        Assertions.assertNull(SYSTEM_DEFAULTS.getCredential());
+        Assertions.assertNull(SYSTEM_DEFAULTS.getProxyAddress());
+    }
+}

sdk/eventhubs/azure-messaging-eventhubs/src/test/java/com/azure/messaging/eventhubs/models/ProxyOptionsTest.java

@@ -6,15 +6,12 @@
 import com.azure.core.amqp.ProxyAuthenticationType;
 import com.azure.core.amqp.ProxyOptions;
 import org.junit.jupiter.api.Assertions;
-import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.EnumSource;
 
 import java.net.InetSocketAddress;
 import java.net.Proxy;
 
-import static com.azure.core.amqp.ProxyOptions.SYSTEM_DEFAULTS;
-
 public class ProxyOptionsTest {
 
     private static final String PROXY_HOST = "127.0.0.1";
@@ -25,13 +22,6 @@ public class ProxyOptionsTest {
 
     private static Proxy proxyAddress = new Proxy(Proxy.Type.HTTP, new InetSocketAddress(PROXY_HOST, Integer.parseInt(PROXY_PORT)));
 
-    @Test
-    public void nullProxyConfiguration() {
-        Assertions.assertNull(SYSTEM_DEFAULTS.getAuthentication());
-        Assertions.assertNull(SYSTEM_DEFAULTS.getCredential());
-        Assertions.assertNull(SYSTEM_DEFAULTS.getProxyAddress());
-    }
-
     @ParameterizedTest
     @EnumSource(ProxyAuthenticationType.class)
     public void validateProxyConfiguration(ProxyAuthenticationType proxyAuthenticationType) {