mgmt, allow subclass of generic in SupportsBatchCreation.create (Azure#20924)

weidongxu-microsoft · web-flow · commit c417a436ae6c · 2021-04-26T13:10:54.000+08:00
diff --git a/sdk/resourcemanager/azure-resourcemanager-appplatform/pom.xml b/sdk/resourcemanager/azure-resourcemanager-appplatform/pom.xml
@@ -214,6 +214,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-authorization/pom.xml b/sdk/resourcemanager/azure-resourcemanager-authorization/pom.xml
@@ -153,6 +153,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-cdn/pom.xml b/sdk/resourcemanager/azure-resourcemanager-cdn/pom.xml
@@ -146,6 +146,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-compute/pom.xml b/sdk/resourcemanager/azure-resourcemanager-compute/pom.xml
@@ -212,6 +212,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-containerinstance/pom.xml b/sdk/resourcemanager/azure-resourcemanager-containerinstance/pom.xml
@@ -176,6 +176,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-containerregistry/pom.xml b/sdk/resourcemanager/azure-resourcemanager-containerregistry/pom.xml
@@ -153,6 +153,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
@@ -169,5 +171,4 @@
       </plugin>
     </plugins>
   </build>
-
 </project>
diff --git a/sdk/resourcemanager/azure-resourcemanager-cosmos/pom.xml b/sdk/resourcemanager/azure-resourcemanager-cosmos/pom.xml
@@ -163,6 +163,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-dns/pom.xml b/sdk/resourcemanager/azure-resourcemanager-dns/pom.xml
@@ -158,6 +158,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-eventhubs/pom.xml b/sdk/resourcemanager/azure-resourcemanager-eventhubs/pom.xml
@@ -152,6 +152,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-monitor/pom.xml b/sdk/resourcemanager/azure-resourcemanager-monitor/pom.xml
@@ -178,6 +178,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
@@ -194,5 +196,4 @@
       </plugin>
     </plugins>
   </build>
-
 </project>
diff --git a/sdk/resourcemanager/azure-resourcemanager-msi/pom.xml b/sdk/resourcemanager/azure-resourcemanager-msi/pom.xml
@@ -156,6 +156,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
@@ -172,5 +174,4 @@
       </plugin>
     </plugins>
   </build>
-
 </project>
diff --git a/sdk/resourcemanager/azure-resourcemanager-privatedns/pom.xml b/sdk/resourcemanager/azure-resourcemanager-privatedns/pom.xml
@@ -161,6 +161,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-resources/CHANGELOG.md b/sdk/resourcemanager/azure-resourcemanager-resources/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 2.4.0-beta.1 (Unreleased)
 
 - Added shared interfaces and classes for Private Link.
+- Updated parameter of `SupportsBatchCreation.create` from `List<Creatable<ResourceT>>` to `List<? extends Creatable<ResourceT>>`
 
 ## 2.3.0 (2021-03-30)
 
diff --git a/sdk/resourcemanager/azure-resourcemanager-resources/pom.xml b/sdk/resourcemanager/azure-resourcemanager-resources/pom.xml
@@ -184,6 +184,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/arm/collection/implementation/CreatableResourcesImpl.java b/sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/arm/collection/implementation/CreatableResourcesImpl.java
@@ -46,7 +46,7 @@ public final CreatedResources<T> create(Creatable<T>... creatables) {
     }
 
     @Override
-    public final CreatedResources<T> create(List<Creatable<T>> creatables) {
+    public final CreatedResources<T> create(List<? extends Creatable<T>> creatables) {
         return createAsyncNonStream(creatables)
                 .block();
     }
@@ -58,15 +58,15 @@ public final Flux<T> createAsync(Creatable<T>... creatables) {
     }
 
     @Override
-    public final Flux<T> createAsync(List<Creatable<T>> creatables) {
+    public final Flux<T> createAsync(List<? extends Creatable<T>> creatables) {
         if (creatables == null) {
             return Flux.empty();
         }
         return createWithRootResourceAsync(creatables)
             .flatMapMany(rootResource -> Flux.fromIterable(rootResource.createdTopLevelResources()));
     }
 
-    private Mono<CreatedResources<T>> createAsyncNonStream(List<Creatable<T>> creatables) {
+    private Mono<CreatedResources<T>> createAsyncNonStream(List<? extends Creatable<T>> creatables) {
         return createWithRootResourceAsync(creatables)
                 .map(CreatedResourcesImpl::new);
     }
@@ -76,7 +76,8 @@ private Mono<CreatedResources<T>> createAsyncNonStream(Creatable<T>... creatable
         return createAsyncNonStream(Arrays.asList(creatables));
     }
 
-    private Mono<CreatableUpdatableResourcesRoot<T>> createWithRootResourceAsync(List<Creatable<T>> creatables) {
+    private Mono<CreatableUpdatableResourcesRoot<T>> createWithRootResourceAsync(
+        List<? extends Creatable<T>> creatables) {
         CreatableUpdatableResourcesRootImpl<T> rootResource = new CreatableUpdatableResourcesRootImpl<>();
         rootResource.addCreatableDependencies(creatables);
         return rootResource.createAsync();
@@ -220,7 +221,7 @@ void addCreatableDependencies(Creatable<T>... creatables) {
             }
         }
 
-        void addCreatableDependencies(List<Creatable<T>> creatables) {
+        void addCreatableDependencies(List<? extends Creatable<T>> creatables) {
             for (Creatable<T> item : creatables) {
                 this.keys.add(this.addDependency(item));
             }
diff --git a/sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/collection/SupportsBatchCreation.java b/sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/fluentcore/collection/SupportsBatchCreation.java
@@ -34,7 +34,7 @@ public interface SupportsBatchCreation<ResourceT extends Indexable> {
      * @param creatables the list of creatables in the batch
      * @return the batch operation result from which created resources in this batch can be accessed.
      */
-    CreatedResources<ResourceT> create(List<Creatable<ResourceT>> creatables);
+    CreatedResources<ResourceT> create(List<? extends Creatable<ResourceT>> creatables);
 
     /**
      * Puts the requests to create a batch of resources into the queue and allow the HTTP client to execute it when
@@ -53,5 +53,5 @@ public interface SupportsBatchCreation<ResourceT extends Indexable> {
      * @param creatables the list of creatables in the batch
      * @return a {@link Mono} that emits the found resource asynchronously.
      */
-    Flux<ResourceT> createAsync(List<Creatable<ResourceT>> creatables);
+    Flux<ResourceT> createAsync(List<? extends Creatable<ResourceT>> creatables);
 }
diff --git a/sdk/resourcemanager/azure-resourcemanager-search/pom.xml b/sdk/resourcemanager/azure-resourcemanager-search/pom.xml
@@ -146,6 +146,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-servicebus/pom.xml b/sdk/resourcemanager/azure-resourcemanager-servicebus/pom.xml
@@ -146,6 +146,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-sql/pom.xml b/sdk/resourcemanager/azure-resourcemanager-sql/pom.xml
@@ -160,6 +160,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-storage/pom.xml b/sdk/resourcemanager/azure-resourcemanager-storage/pom.xml
@@ -145,6 +145,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager-trafficmanager/pom.xml b/sdk/resourcemanager/azure-resourcemanager-trafficmanager/pom.xml
@@ -145,6 +145,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
diff --git a/sdk/resourcemanager/azure-resourcemanager/CHANGELOG.md b/sdk/resourcemanager/azure-resourcemanager/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## 2.4.0-beta.1 (Unreleased)
 
+- Updated parameter of `SupportsBatchCreation.create` from `List<Creatable<ResourceT>>` to `List<? extends Creatable<ResourceT>>`
 
 ## 2.3.0 (2021-03-30)
 
diff --git a/sdk/resourcemanager/azure-resourcemanager/pom.xml b/sdk/resourcemanager/azure-resourcemanager/pom.xml
@@ -286,6 +286,8 @@
         <artifactId>revapi-maven-plugin</artifactId>
         <version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
         <configuration>
+          <skip>true</skip>
+
           <analysisConfiguration>
             <revapi.ignore>
               <item>
