Skip to content

Commit 8334cbb

Browse files
han-gaov-gaoh
andauthored
skip check for third party files (Azure#17112)
* skip check for third party files Co-authored-by: v-gaoh <v-gaoh@Microsoft.com>
1 parent 9f0eeaf commit 8334cbb

File tree

3 files changed

+20
-18
lines changed
  • eng/code-quality-reports/src/main/resources/revapi
  • sdk
    • keyvault/azure-security-keyvault-jca
    • spring/azure-spring-boot-starter-keyvault-certificates

3 files changed

+20
-18
lines changed

eng/code-quality-reports/src/main/resources/revapi/revapi.json

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,24 @@
7070
"new": "parameter java.lang.Iterable<P> com.azure.core.util.paging.ContinuablePagedIterable<C, T, P extends com.azure.core.util.paging.ContinuablePage<C extends java.lang.Object, T extends java.lang.Object>>::iterableByPage(===int===) @ com.azure.core.http.rest.PagedIterableBase<T, P extends com.azure.core.http.rest.PagedResponse<T extends java.lang.Object>>",
7171
"justification": "A new overload which shares the same number of parameters was introduced, confusing revapi. azure.core 1.3.0 will introduce a new base type for GAed PagedIterable. Since the base type is not in azure.core <= 1.2.0, revapi is reporting it. This entry should be removed after 1.3.0 release."
7272
},
73+
{
74+
"regex": true,
75+
"code": "java.class.nonPublicPartOfAPI",
76+
"new": "(class|interface) com\\.azure\\.keyvault\\.jca\\.com\\..*",
77+
"justification": "skip check for third party files."
78+
},
79+
{
80+
"regex": true,
81+
"code": "java.class.nonPublicPartOfAPI",
82+
"new": "(class|interface) com\\.azure\\.keyvault\\.jca\\.org\\..*",
83+
"justification": "skip check for third party files."
84+
},
85+
{
86+
"regex": true,
87+
"code": "java.class.nonPublicPartOfAPI",
88+
"new": "(class|enum|interface) org\\.conscrypt\\..*",
89+
"justification": "skip check for third party files."
90+
},
7391
{
7492
"code": "java.method.parameterTypeChanged",
7593
"new": "parameter java.lang.Iterable<P> com.azure.core.util.paging.ContinuablePagedIterable<C, T, P extends com.azure.core.util.paging.ContinuablePage<C extends java.lang.Object, T extends java.lang.Object>>::iterableByPage(===int===) @ com.azure.core.http.rest.PagedIterable<T>",

sdk/keyvault/azure-security-keyvault-jca/pom.xml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,6 @@
122122
</rules>
123123
</configuration>
124124
</plugin>
125-
<plugin>
126-
<groupId>org.revapi</groupId>
127-
<artifactId>revapi-maven-plugin</artifactId>
128-
<version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
129-
<configuration>
130-
<skip>true</skip>
131-
</configuration>
132-
</plugin>
133125
</plugins>
134126
</build>
135127
<dependencies>

sdk/spring/azure-spring-boot-starter-keyvault-certificates/pom.xml

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33
xmlns="http://maven.apache.org/POM/4.0.0"
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
6-
6+
77
<parent>
88
<groupId>com.azure</groupId>
99
<artifactId>azure-client-sdk-parent</artifactId>
1010
<version>1.7.0</version> <!-- {x-version-update;com.azure:azure-client-sdk-parent;current} -->
1111
<relativePath>../../parents/azure-client-sdk-parent</relativePath>
1212
</parent>
13-
13+
1414
<groupId>com.azure.spring</groupId>
1515
<artifactId>azure-spring-boot-starter-keyvault-certificates</artifactId>
1616
<version>3.0.0-beta.2</version> <!-- {x-version-update;com.azure.spring:azure-spring-boot-starter-keyvault-certificates;current} -->
@@ -168,14 +168,6 @@
168168
</executions>
169169
</plugin>
170170
<!-- END: Empty Java Doc & Sources -->
171-
<plugin>
172-
<groupId>org.revapi</groupId>
173-
<artifactId>revapi-maven-plugin</artifactId>
174-
<version>0.11.2</version> <!-- {x-version-update;org.revapi:revapi-maven-plugin;external_dependency} -->
175-
<configuration>
176-
<skip>true</skip>
177-
</configuration>
178-
</plugin>
179171
</plugins>
180172
</build>
181173
<properties>

0 commit comments

Comments
 (0)