Change Diagnostic-Id spelling to comply with other languages (Azure#23141)

Author: Liudmila Molkova

eng/code-quality-reports/src/main/resources/revapi/revapi.json

@@ -628,6 +628,12 @@
         "code": "java.method.added",
         "new": "method boolean com.google.gson.JsonArray::isEmpty()",
         "justification": "com.google.code.gson:gson:jar:2.8.7 added this new method."
+      },
+      {
+        "code": "java.field.constantValueChanged",
+        "old": "field com.azure.core.util.tracing.Tracer.DIAGNOSTIC_ID_KEY",
+        "new": "field com.azure.core.util.tracing.Tracer.DIAGNOSTIC_ID_KEY",
+        "justification": "Old field value spelled incorrectly and was used in preview version of tracing package"
       }
     ]
   }

sdk/core/azure-core/CHANGELOG.md

@@ -6,6 +6,10 @@
  - Added a new constructor `HttpHeaders(int initialCapacity)` which allows configuration of the initial backing map 
    capacity may allow short-circuiting scenarios where the map would need to be resized and copied in memory.
 
+### Fixed
+
+- Fixed a bug with context propagation through EventHub and ServiceBus between Java and other languages.
+
 ## 1.19.0-beta.1 (2021-07-07)
 
 ### Features Added

sdk/core/azure-core/src/main/java/com/azure/core/util/tracing/Tracer.java

@@ -48,7 +48,7 @@ public interface Tracer {
     /**
      * Key for {@link Context} which indicates that the context contains a "Diagnostic Id" for the service call.
      */
-    String DIAGNOSTIC_ID_KEY = "diagnostic-id";
+    String DIAGNOSTIC_ID_KEY = "Diagnostic-Id";
 
     /**
      * Key for {@link Context} the scope of code where the given Span is in the current Context.

sdk/core/azure-core/src/samples/java/com/azure/core/util/tracing/TracerJavaDocCodeSnippets.java

@@ -41,7 +41,7 @@ public void startTracingSpan() {
         // END: com.azure.core.util.tracing.start#string-context-processKind-SEND
 
         // BEGIN: com.azure.core.util.tracing.start#string-context-processKind-MESSAGE
-        String diagnosticIdKey = "diagnostic-id";
+        String diagnosticIdKey = "Diagnostic-Id";
         // start a new tracing span with explicit parent, sets the diagnostic Id (traceparent headers) on the current
         // context when process kind MESSAGE
         Context updatedReceiveContext = tracer.start("azure.eventhubs.receive", traceContext,