Skip to content

Commit 69088d0

Browse files
authored
Add Component Check to Aggregate YML (Azure#17731)
* Create aggregate component check YML * Update aggregate reporting pipeline instead of creating a new pipeline * Fix task indentation * Add microsoft-opentelemetry-exporter-azuremonitor to the allowed list in enforcer as it is a track 2 library * Localize the Enforcer fix to Jacoco test coverage * Remove component check from individual library pipelines
1 parent d3d49f9 commit 69088d0

File tree

3 files changed

+34
-6
lines changed

3 files changed

+34
-6
lines changed

eng/jacoco-test-coverage/pom.xml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,22 @@
531531
</dependencies>
532532
<build>
533533
<plugins>
534+
<plugin>
535+
<groupId>org.apache.maven.plugins</groupId>
536+
<artifactId>maven-enforcer-plugin</artifactId>
537+
<version>3.0.0-M3</version> <!-- {x-version-update;org.apache.maven.plugins:maven-enforcer-plugin;external_dependency} -->
538+
<configuration>
539+
<rules>
540+
<bannedDependencies>
541+
<includes>
542+
<!-- Track 2 library with a non-standard groupId -->
543+
<include>com.microsoft:microsoft-opentelemetry-exporter-azuremonitor:[1.0.0-beta.2]</include> <!-- {x-include-update;com.microsoft:microsoft-opentelemetry-exporter-azuremonitor;current} -->
544+
</includes>
545+
</bannedDependencies>
546+
</rules>
547+
</configuration>
548+
</plugin>
549+
534550
<plugin>
535551
<groupId>org.jacoco</groupId>
536552
<artifactId>jacoco-maven-plugin</artifactId>

eng/pipelines/aggregate-reports.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,24 @@ jobs:
2121
parameters:
2222
Directory: ""
2323
CheckLinkGuidance: $true
24+
25+
- task: Maven@3
26+
displayName: 'Build All Libraries'
27+
inputs:
28+
mavenPomFile: pom.xml
29+
options: '$(DefaultOptions) -T 1C -DskipTests -Dgpg.skip -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Djacoco.skip=true -Drevapi.skip=true'
30+
mavenOptions: '$(MemoryOptions) $(LoggingOptions)'
31+
javaHomeOption: 'JDKVersion'
32+
jdkVersionOption: $(JavaBuildVersion)
33+
jdkArchitectureOption: 'x64'
34+
publishJUnitResults: false
35+
goals: 'clean install'
36+
37+
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
38+
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
39+
# builds should be sufficient.
40+
condition: and(succeededOrFailed(), ne(variables['Build.Reason'], 'PullRequest'))
41+
displayName: 'Component Detection'
2442

2543
- task: Maven@3
2644
displayName: 'Generate Reports'

eng/pipelines/templates/jobs/archetype-sdk-client.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,6 @@ jobs:
210210
jdkArchitectureOption: 'x64'
211211
publishJUnitResults: false
212212

213-
- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
214-
# ComponentGovernance is currently unable to run on pull requests of public projects. Running on non-PR
215-
# builds should be sufficient.
216-
condition: and(succeededOrFailed(), ne(variables['Build.Reason'], 'PullRequest'))
217-
displayName: 'Component Detection'
218-
219213
- task: Maven@3
220214
displayName: 'Run SpotBugs, Checkstyle, RevApi, and Javadoc'
221215
inputs:

0 commit comments

Comments
 (0)